dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
Subsystems (3)
PATCH 1/1 dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
--- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma-buf/sw_sync.c +1 -1
@@ -85,7 +85,7 @@ static struct sync_timeline *sync_timeline_create(const char *name)kref_init (&obj->kref); obj->context =dma_fence_context_alloc (1 ); -strlcpy (obj->name, name,sizeof (obj->name)); +strscpy (obj->name, name,sizeof (obj->name)); obj->pt_tree =RB_ROOT ;INIT_LIST_HEAD (&obj->pt_list);
Quoted 8 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.
Quoted 4 lines
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by Azeem Shaikh <[email protected]>
Signature · 1 line
Kees Cook
Sumit Semwal
maintainerHello Azeem,
Quoted 10 lines · Kees Cook
Quoted 8 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.
Quoted 2 lines
Thank you for the patch; I'll queue it up.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Azeem Shaikh <[email protected]>Reviewed-by Kees Cook <[email protected]>--
Kees Cook
Best,
Sumit.
Signature · 5 lines
Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org │ Open source software for ARM SoCs