Skip to contentSkip to conversation

tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

PATCH In review Peter Ujfalusi 2 participants 2 messages May 24, 2023 – Jun 9, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only

The original patch which added the quirk would apply to all AAEON machines, which might or might not be valid.

The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the i12 (Alder Lake) version is affected.
UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing and confirmed by dmidecode).

Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.

Fixes 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")

---
Hi Jarkko,

Changes since v1:
- Findings from Paul Menzel in the commit message has been addressed

the patch is generated on top of your
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm

Regards,
Peter

 drivers/char/tpm/tpm_tis.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_tis.c +1 -0
index 7db3593941ea..4357d4ba8f9e 100644
@@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
 		.ident = "UPX-TGL",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
 		},
 	},
 	{}
Signature · 1 line
2.40.1
maintainer
#1 lore raw
Quoted 43 lines · Peter Ujfalusi

The original patch which added the quirk would apply to all AAEON machines, which might or might not be valid.

The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the i12 (Alder Lake) version is affected.
UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing and confirmed by dmidecode).

Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.

Fixes 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")

---
Hi Jarkko,

Changes since v1:
- Findings from Paul Menzel in the commit message has been addressed

the patch is generated on top of your
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm

Regards,
Peter

 drivers/char/tpm/tpm_tis.c | 1 +
 1 file changed, 1 insertion(+)
drivers/char/tpm/tpm_tis.c +1 -0
index 7db3593941ea..4357d4ba8f9e 100644
@@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
 		.ident = "UPX-TGL",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
 		},
 	},
 	{}
Signature · 1 line
2.40.1

I had this already applied:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=20e0e7d7ec975897f40b4ee635266d36f9083856

BR, Jarkko