adm1266.c: Fix error checking for debugfs_create_dir
PATCH 1/1 adm1266.c: Fix error checking for debugfs_create_dir
This patch fixes the error checking in adm1266.c in debugfs_create_dir. The correct way to check if an error occurred is using 'IS_ERR' inline function.
Signed-off-by Osama Muhammad <[email protected]>
--- drivers/hwmon/pmbus/adm1266.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/adm1266.c +1 -1
@@ -340,7 +340,7 @@ static void adm1266_init_debugfs(struct adm1266_data *data)return ; data->debugfs_dir =debugfs_create_dir (data->client->name, root); -if (!data->debugfs_dir) +if (IS_ERR (data->debugfs_dir))return ; debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
Signature · 1 line
2.34.1
Guenter Roeck
maintainerQuoted 14 lines · Osama Muhammad
This patch fixes the error checking in
adm1266.cindebugfs_create_dir. The correct way to check if an error occurred is using 'IS_ERR' inline function.Signed-off-by Osama Muhammad <[email protected]>--- drivers/hwmon/pmbus/adm1266.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/pmbus/adm1266.c +0
-0
drivers/hwmon/pmbus/adm1266.c static void adm1266_init_debugfs(struct adm1266_data *data) · line 344
Quoted 6 lines
drivers/hwmon/pmbus/adm1266.c +1
-1@@ -340,7 +340,7 @@ static void adm1266_init_debugfs(struct adm1266_data *data)return ; data->debugfs_dir =debugfs_create_dir (data->client->name, root); -if (!data->debugfs_dir) +if (IS_ERR (data->debugfs_dir))return ;
Just drop the error check entirely instead. It is not needed.
Thanks,
Guenter
Quoted 2 lines
drivers/hwmon/pmbus/adm1266.c +0
-0debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,