Skip to contentSkip to conversation

adm1266.c: Drop error checking for debugfs_create_dir

PATCH In review Osama Muhammad 2 participants 3 messages May 25, 2023 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 adm1266.c: Drop error checking for debugfs_create_dir

This patch fixes the error checking in adm1266.c. The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.

---
 drivers/hwmon/pmbus/adm1266.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/adm1266.c +0 -2
index 1ac2b2f4c570..184d75269d2b 100644
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
 		return;
 
 	data->debugfs_dir = debugfs_create_dir(data->client->name, root);
-	if (!data->debugfs_dir)
-		return;
 
 	debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
 				    adm1266_state_read);
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 6 lines · Osama Muhammad

This patch fixes the error checking in adm1266.c. The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.

Confusing. Is this v3 of the patch ?

Guenter

Quoted 20 lines
---
 drivers/hwmon/pmbus/adm1266.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/adm1266.c +0 -2
index 1ac2b2f4c570..184d75269d2b 100644
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
 		return;
 
 	data->debugfs_dir = debugfs_create_dir(data->client->name, root);
-	if (!data->debugfs_dir)
-		return;
 
 	debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
 				    adm1266_state_read);
Signature · 1 line
2.34.1
#2 lore raw

This is the new patch not v3. The patch I sent as v2 was a mistake. Please discard the patch I sent earlier as v2 . Apologies for the confusion.Hope it clarifies.

Regards,
Osmten

Quoted 33 lines · Guenter Roeck
Quoted 6 lines · Osama Muhammad

This patch fixes the error checking in adm1266.c. The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.

Confusing. Is this v3 of the patch ?

Guenter

Quoted 20 lines
---
 drivers/hwmon/pmbus/adm1266.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/adm1266.c +0 -3
index 1ac2b2f4c570..184d75269d2b 100644
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
              return;
 
      data->debugfs_dir = debugfs_create_dir(data->client->name, root);
-     if (!data->debugfs_dir)
-             return;
 
      debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
                                  adm1266_state_read);
--

2.34.1