Skip to contentSkip to conversation

arm64: tegra: Fix PCIe regulator for Orin Jetson AGX

PATCH Applied Jon Hunter 2 participants 4 messages May 26, 2023 – May 30, 2023

Subsystems (2)
Device tree bindings Tegra architecture support
lore
Share & tools
lore

Jon Hunter

author maintainer
#0 lore raw

PATCH 1/1 arm64: tegra: Fix PCIe regulator for Orin Jetson AGX

The PCIe slot on the Jetson Orin AGX is not working and PCIe cards are not detected. The regulator for the 3.3V regulator for the PCIe is using the wrong GPIO for turning on the regulator. Fix this by updating the 3.3V regulator to use the correct GPIO.

Signed-off-by Jon Hunter <[email protected]>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +1 -1
index e161618cfca8..4dce2e214002 100644
@@ -142,7 +142,7 @@ vdd_3v3_pcie: regulator-vdd-3v3-pcie {
 		regulator-name = "VDD_3V3_PCIE";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
 		regulator-boot-on;
 		enable-active-high;
 	};
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

Adding linux-tegra ...

Quoted 23 lines · Jon Hunter

The PCIe slot on the Jetson Orin AGX is not working and PCIe cards are not detected. The regulator for the 3.3V regulator for the PCIe is using the wrong GPIO for turning on the regulator. Fix this by updating the 3.3V regulator to use the correct GPIO.

Signed-off-by Jon Hunter <[email protected]>
---
  arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +1 -1
index e161618cfca8..4dce2e214002 100644
@@ -142,7 +142,7 @@ vdd_3v3_pcie: regulator-vdd-3v3-pcie {
  		regulator-name = "VDD_3V3_PCIE";
  		regulator-min-microvolt = <3300000>;
  		regulator-max-microvolt = <3300000>;
-		gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
+		gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
  		regulator-boot-on;
  		enable-active-high;
  	};
Signature · 1 line
nvpublic
author maintainer
#2 lore raw
Quoted 13 lines · Jon Hunter

Adding linux-tegra ...

Quoted 10 lines · Jon Hunter

The PCIe slot on the Jetson Orin AGX is not working and PCIe cards are not detected. The regulator for the 3.3V regulator for the PCIe is using the wrong GPIO for turning on the regulator. Fix this by updating the 3.3V regulator to use the correct GPIO.

Signed-off-by Jon Hunter <[email protected]>

---
  arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines

arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi vdd_3v3_pcie: regulator-vdd-3v3-pcie { · line 145

Quoted 10 lines
arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi +1 -1
index e161618cfca8..4dce2e214002 100644
@@ -142,7 +142,7 @@ vdd_3v3_pcie: regulator-vdd-3v3-pcie {
           regulator-name = "VDD_3V3_PCIE";
           regulator-min-microvolt = <3300000>;
           regulator-max-microvolt = <3300000>;
-        gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
+        gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;

Apparently the original GPIO we had was for pre-production boards and hence the mistake was made. Let me know if you want me to add that detail to the commit message.

Jon

Signature · 1 line
nvpublic
Applied
#3 lore raw
In reply to Jon Hunter
Quoted 9 lines · Jon Hunter

The PCIe slot on the Jetson Orin AGX is not working and PCIe cards are not detected. The regulator for the 3.3V regulator for the PCIe is using the wrong GPIO for turning on the regulator. Fix this by updating the 3.3V regulator to use the correct GPIO.

Signed-off-by Jon Hunter <[email protected]>
---
 arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Vidya, any ideas on why this ended up being wrong? Was the original based on an early version of the hardware, or is this something that we need to parameterized per SKU?

Thierry