hwmon:(pmbus/adm1266): Drop unnecessary error check for debugfs_create_dir
PATCH v3 1/1 hwmon:(pmbus/adm1266): Drop unnecessary error check for debugfs_create_dir
This patch removes the error checking for debugfs_create_dir in adm1266.c. This is because the debugfs_create_dir() does not return NULL but an ERR_PTR after an error.
The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary.
Link to the comment above debugfs_create_dir:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565
---
changes since v2
-Added more descriptive commit message.
changes since v1
-In v1 the IS_ERR was used for error checking which is dropped now.
--- drivers/hwmon/pmbus/adm1266.c | 2 -- 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/adm1266.c +0 -2
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)return ; data->debugfs_dir =debugfs_create_dir (data->client->name, root); -if (!data->debugfs_dir) -return ;debugfs_create_devm_seqfile (&data->client->dev,"sequencer_state" , data->debugfs_dir, adm1266_state_read);
Signature · 1 line
2.34.1
Quoted 8 lines · Osama Muhammad
This patch removes the error checking for
debugfs_create_dirinadm1266.c. This is because thedebugfs_create_dir()does not return NULL but anERR_PTRafter an error.
The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary.
Quoted 4 lines
Link to the comment above
debugfs_create_dir:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565Signed-off-by Osama Muhammad <[email protected]>
Applied.
Thanks,
Guenter
Quoted 23 lines
---
changes since v2
-Added more descriptive commit message.changes since v1
-In v1 theIS_ERRwas used for error checking which is dropped now.--- drivers/hwmon/pmbus/adm1266.c | 2 -- 1 file changed, 2 deletions(-)drivers/hwmon/pmbus/adm1266.c +0
-2@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)return ; data->debugfs_dir =debugfs_create_dir (data->client->name, root); -if (!data->debugfs_dir) -return ;debugfs_create_devm_seqfile (&data->client->dev,"sequencer_state" , data->debugfs_dir, adm1266_state_read);