dt-bindings: bridge: samsung-dsim: Make some flags optional
Subsystems (5)
PATCH v2 1/1 dt-bindings: bridge: samsung-dsim: Make some flags optional
In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list.
The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as sclk_mipi clock. If they are equal, this flag is not needed since the driver will use the sclk_mipi rate as a fallback.
---
V2: Split from driver series. Re-word updates for burst and pll-clock frequency.
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +5 -4
@@ -70,7 +70,9 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency. + DSIM high speed burst mode frequency. If absent, + the pixel clock from the attached device or bridge + will be used instead. samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32
@@ -80,7 +82,8 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. + DSIM oscillator clock frequency. If absent, the clock frequency + of sclk_mipi will be used instead. phys: maxItems: 1
@@ -134,9 +137,7 @@ required: - compatible - interrupts - reg - - samsung,burst-clock-frequency - samsung,esc-clock-frequency - - samsung,pll-clock-frequency allOf: - $ref: ../dsi-controller.yaml#
Signature · 1 line
2.39.2
Quoted 36 lines · Adam Ford
In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list.
The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as
sclk_mipiclock. If they are equal, this flag is not needed since the driver will use thesclk_mipirate as a fallback.Signed-off-by Adam Ford <[email protected]>Reviewed-by Conor Dooley <[email protected]>---
V2: Split from driver series. Re-word updates for burst and pll-clock frequency.Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +3
-1@@ -70,7 +70,9 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency. + DSIM high speed burst mode frequency. If absent, + the pixel clock from the attached device or bridge + will be used instead. samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml properties: · line 86
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +2
-1@@ -80,7 +82,8 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. + DSIM oscillator clock frequency. If absent, the clock frequency + of sclk_mipi will be used instead.
Maybe this explicit comment won't require as it is not listed in "required"
Quoted 35 lines · Jagan Teki
Quoted 33 lines · Adam Ford
In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list.
The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as
sclk_mipiclock. If they are equal, this flag is not needed since the driver will use thesclk_mipirate as a fallback.Signed-off-by Adam Ford <[email protected]>Reviewed-by Conor Dooley <[email protected]>---
V2: Split from driver series. Re-word updates for burst and pll-clock frequency.Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +3
-1@@ -70,7 +70,9 @@ properties: samsung,burst-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM high speed burst mode frequency. + DSIM high speed burst mode frequency. If absent, + the pixel clock from the attached device or bridge + will be used instead.
Quoted 11 lines
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml properties: · line 86
Quoted 9 lines
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +2
-1samsung,esc-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32@@ -80,7 +82,8 @@ properties: samsung,pll-clock-frequency: $ref: /schemas/types.yaml#/definitions/uint32 description: - DSIM oscillator clock frequency. + DSIM oscillator clock frequency. If absent, the clock frequency + of sclk_mipi will be used instead.Maybe this explicit comment won't require as it is not listed in "required"
I mostly listed it here to explain why it's being removed from the required list and what happens if it's missing.
Quoted 2 lines
Reviewed-by Jagan Teki <[email protected]>
Quoted 14 lines · Adam Ford
In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list.
The pll-clock frequency can be set by the device tree entry for samsung,pll-clock-frequency, but in some cases, the pll-clock may have the same clock rate as
sclk_mipiclock. If they are equal, this flag is not needed since the driver will use thesclk_mipirate as a fallback.
Quoted 5 lines
Signed-off-by Adam Ford <[email protected]>Reviewed-by Conor Dooley <[email protected]>---
V2: Split from driver series. Re-word updates for burst and pll-clock frequency.
Hi,
Quoted 8 lines · Adam Ford
In the event a device is connected to the samsung-dsim controller that doesn't support the burst-clock, the driver is able to get the requested pixel clock from the attached device or bridge. In these instances, the samsung,burst-clock-frequency isn't needed, so remove it from the required list.
[...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] dt-bindings: bridge: samsung-dsim: Make some flags optional
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=5769b45abedca0b9d14145e156c180af36139416
Signature · 1 line
Neil