Integrate igt_spin_new with Xe.
Subsystems (2)
cover Integrate igt_spin_new with Xe.
From: Sai Gowtham Ch <[email protected]>
Extending the spin_create implementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped around vm_bind and unbind as we are supposed to do it manually for xe.
Sai Gowtham Ch (2):
lib/xe/xe_spin: Integrate igt_spin_new with Xe. tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe.
lib/igt_dummyload.c | 24 ++++-- lib/igt_dummyload.h | 10 +++ lib/xe/xe_spin.c | 91 +++++++++++++++++++++ lib/xe/xe_spin.h | 7 ++ tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 6 files changed, 295 insertions(+), 6 deletions(-) create mode 100644 tests/xe/xe_spin_batch.c
Signature · 1 line
2.39.1
PATCH 1/2 lib/xe/xe_spin: Integrate igt_spin_new with Xe.
From: Sai Gowtham Ch <[email protected]>
Extending the spin_create implementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped around vm_bind and unbind as we are supposed to do it manually for xe.
--- lib/igt_dummyload.c | 24 +++++++++--- lib/igt_dummyload.h | 10 +++++ lib/xe/xe_spin.c | 91 +++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 7 ++++ 4 files changed, 126 insertions(+), 6 deletions(-)
lib/igt_dummyload.c +18 -6
@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload
@@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/**
@@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + } +if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;
@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }void igt_terminate_spins (void )
lib/igt_dummyload.h +10 -0
@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {
@@ -83,6 +85,14 @@ typedef struct igt_spin {#define SPIN_CLFLUSH (1 << 0)struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; + } igt_spin_t;
lib/xe/xe_spin.c +91 -0
103 lines not on this page · raw message
lib/xe/xe_spin.h +7 -0
@@ -13,19 +13,26 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ +struct xe_spin {uint32_t batch[16 ];uint64_t pad;uint32_t start;uint32_t end; + }; +igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt);void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin;
Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
Quoted 58 lines · On Tue, May 30, 2023 at 03:38:04PM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we are supposed to do it manually for xe.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 +++++++++--- lib/igt_dummyload.h | 10 +++++ lib/xe/xe_spin.c | 91 +++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 7 ++++ 4 files changed, 126 insertions(+), 6 deletions(-)lib/igt_dummyload.c +10
-4@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload @@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/** @@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + } +if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock);
lib/igt_dummyload.c void igt_spin_free(int fd, igt_spin_t *spin) · line 666
Quoted 10 lines
lib/igt_dummyload.c +8
-2- -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + }
At the moment I'm not sure but I think for failed subtests we may have spinners running and not cleared from igt_terminate_spinners(). I think you may add xe spinner to the list and handle this case.
Quoted 62 lines
lib/igt_dummyload.c +0
-0}void igt_terminate_spins (void )lib/igt_dummyload.h +10
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,14 @@ typedef struct igt_spin {#define SPIN_CLFLUSH (1 << 0)struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; + } igt_spin_t;lib/xe/xe_spin.c +16
-0@@ -15,6 +15,7 @@#include "intel_reg.h" #include "xe_ioctl.h" #include "xe_spin.h" +#include "lib/igt_dummyload.h" /** * xe_spin_init: @@ -82,6 +83,96 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; } +igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) +{ +size_t bo_size =xe_get_default_alignment (fd); +uint32_t bo; +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync),
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 110
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ }; + +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); + + spin->syncobj =syncobj_create (fd,0 ); +if (opt->engine) { + spin->opts.engine = opt->engine; + spin->opts.vm = opt->vm;
You may copy opt -> spin->opts (see how emit_recursive_batch() is doing this).
If user passed engine ensure vm is also not zeroed.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 123
Quoted 13 lines
lib/xe/xe_spin.c +13
-0+ + spin->handle =xe_bo_create (fd,0 , spin->opts.vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin->handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); +xe_vm_bind_sync (fd, spin->opts.vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->opts.engine; + exec.address = addr; + }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (!opt->hwe) + spin->engine =xe_engine_create_class (fd, spin->vm,DRM_XE_ENGINE_CLASS_RENDER );
On PVC there's no RENDER engine.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 125
Quoted 2 lines
lib/xe/xe_spin.c +2
-0+else + spin->engine =xe_engine_create (fd, spin->vm, opt->hwe,0 );
opt->engine == 0 and opt->hwe == NULL -> SIGSEGV.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 135
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ + bo =xe_bo_create (fd,0 , spin->vm, bo_size); + spin->handle = bo; + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin->handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); +xe_vm_bind_sync (fd, spin->vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr;
A lot of code is duplicated in if/else. Avoid this duplication.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 140
Quoted 5 lines
lib/xe/xe_spin.c +5
-0+ } + sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); +igt_info ("Spinner started\n" );
Unnecessary noise.
Quoted 13 lines
lib/xe/xe_spin.c +13
-0+ + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} + +void xe_spin_sync_wait (int fd,struct igt_spin *spin) +{ +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 , +NULL )); +}
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 163
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ +void xe_spin_free (int fd,struct igt_spin *spin) +{ +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); + +if (!spin->opts.vm) +xe_vm_unbind_sync (fd, spin->vm,0 , spin->address, spin->bo_size); +else +xe_vm_unbind_sync (fd, spin->opts.vm,0 , spin->address, spin->bo_size);
Hint: Assing spin->vm = spin->opts.vm always. If it will be 0 just create it then use hwe to create on top of it. And as you still have spin->opts available (I assume you'll copy it on spinner creation) you can use it when vm should be destroyed in spinner code. And above if/else may be totally dropped to single xe_vm_unbind_sync() line.
+ @Bhanu
Take a look to kms usecases Bhanu mentioned, I assume there're:kms_busy.c:
t = igt_spin_new(dpy->drm_fd,
.ahnd = ahnd, .fence = fence, .dependency = fb->gem_handle, .flags = IGT_SPIN_FENCE_IN);
igt_spin_t *t = igt_spin_new(dpy->drm_fd,
.ahnd = ahnd, .dependency = busy_fb->gem_handle, .flags = IGT_SPIN_NO_PREEMPTION);
or in kms_cursor_legacy.c:
spin = igt_spin_new(display->drm_fd,
.ahnd = ahnd,
.dependency = fb_info[1].gem_handle, .dependency_size = fb_info[1].size);
I'm not sure about prime_busy.c.
I think above usecases should be handled by xe spinner. Bhanu - may you confirm my concerns?
--
Zbigniew
Quoted 49 lines
lib/xe/xe_spin.c +12
-0+ +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->opts.engine) { +xe_engine_destroy (fd, spin->engine); +xe_vm_destroy (fd, spin->vm); + } +free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h +7
-0@@ -13,19 +13,26 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ +struct xe_spin {uint32_t batch[16 ];uint64_t pad;uint32_t start;uint32_t end; + }; +igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt);void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin;Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
In reply to [email protected]Hi Sai,
Quoted 2 lines · On 2023-05-30 at 15:38:04 +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
please remove dot from end of Subject line:
[PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe. --------------------------------------------------------------- ^
so it will be:
[PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe
The same follows for your second patch. I have few more nits, see below.
Quoted 102 lines
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we are supposed to do it manually for xe.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 +++++++++--- lib/igt_dummyload.h | 10 +++++ lib/xe/xe_spin.c | 91 +++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 7 ++++ 4 files changed, 126 insertions(+), 6 deletions(-)lib/igt_dummyload.c +18
-6@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload @@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/** @@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + } +if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }void igt_terminate_spins (void )lib/igt_dummyload.h +10
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,14 @@ typedef struct igt_spin {#define SPIN_CLFLUSH (1 << 0)struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; + } igt_spin_t;lib/xe/xe_spin.c +0
-0
lib/xe/xe_spin.c line 18
Quoted 4 lines
lib/xe/xe_spin.c +1
-0@@ -15,6 +15,7 @@#include "intel_reg.h" #include "xe_ioctl.h" #include "xe_spin.h" +#include "lib/igt_dummyload.h"
------------ ^
Do we need "lib/" here ? Please also put this in alphabetical order.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 85
Quoted 7 lines
lib/xe/xe_spin.c +0
-0/** * xe_spin_init: @@ -82,6 +83,96 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; }
Please describe each new public function you added.
Quoted 41 lines
lib/xe/xe_spin.c +41
-0+igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) +{ +size_t bo_size =xe_get_default_alignment (fd); +uint32_t bo; +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync), + }; + +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); + + spin->syncobj =syncobj_create (fd,0 ); +if (opt->engine) { + spin->opts.engine = opt->engine; + spin->opts.vm = opt->vm; + + spin->handle =xe_bo_create (fd,0 , spin->opts.vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin->handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); +xe_vm_bind_sync (fd, spin->opts.vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->opts.engine; + exec.address = addr; + }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (!opt->hwe) + spin->engine =xe_engine_create_class (fd, spin->vm,DRM_XE_ENGINE_CLASS_RENDER ); +else + spin->engine =xe_engine_create (fd, spin->vm, opt->hwe,0 ); +
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 136
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ bo =xe_bo_create (fd,0 , spin->vm, bo_size); + spin->handle = bo; + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin->handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); +xe_vm_bind_sync (fd, spin->vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr; + }
Put newline here.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 148
Quoted 12 lines
lib/xe/xe_spin.c +12
-0+ sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); +igt_info ("Spinner started\n" ); + + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} +
Write description.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 152
Quoted 4 lines
lib/xe/xe_spin.c +4
-0+void xe_spin_sync_wait (int fd,struct igt_spin *spin) +{ +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 , +NULL ));
imho you can have it in one line:
igt_assert(syncobj_wait(fd, &spin->syncobj, 1, INT64_MAX, 0, NULL));
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 154
Quoted 2 lines
lib/xe/xe_spin.c +2
-0+} +
Write description.
Quoted 8 lines
lib/xe/xe_spin.c +8
-0+void xe_spin_free (int fd,struct igt_spin *spin) +{ +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); + +if (!spin->opts.vm) +xe_vm_unbind_sync (fd, spin->vm,0 , spin->address, spin->bo_size); +else
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 172
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+xe_vm_unbind_sync (fd, spin->opts.vm,0 , spin->address, spin->bo_size); + +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->opts.engine) { +xe_engine_destroy (fd, spin->engine); +xe_vm_destroy (fd, spin->vm); + }
Put newline here.
Quoted 11 lines
lib/xe/xe_spin.c +3
-0+free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h +0
-0
lib/xe/xe_spin.h line 19
Quoted 7 lines
lib/xe/xe_spin.h +2
-0@@ -13,19 +13,26 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ +
Please do not make cleanups when adding new functionality, remove this newline.
lib/xe/xe_spin.h line 25
Quoted 6 lines
lib/xe/xe_spin.h +1
-0struct xe_spin {uint32_t batch[16 ];uint64_t pad;uint32_t start;uint32_t end; +
Same here, remove this line.
lib/xe/xe_spin.h line 28
Quoted 3 lines
lib/xe/xe_spin.h +1
-0}; +igt_spin_t *
-- ^
lib/xe/xe_spin.h line 29
Quoted 1 line
lib/xe/xe_spin.h +1
-0+xe_spin_create(int fd, const struct igt_spin_factory *opt);
-- ^
imho here one-liner is better:
igt_spin_t *xe_spin_create(int fd, const struct igt_spin_factory *opt);
Regards,
Kamil
Quoted 12 lines
lib/xe/xe_spin.h +2
-0void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin;Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
Quoted 97 lines
-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kamil Konieczny
Sent: 01 June 2023 10:42
To: [email protected]
Cc: Ch, Sai Gowtham <[email protected]>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2]lib/xe/xe_spin: Integrateigt_spin_newwith Xe.Hi Sai,
Quoted 2 lines · On 2023-05-30 at 15:38:04 +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
please remove dot from end of Subject line:
[PATCH i-g-t 1/2]
lib/xe/xe_spin: Integrateigt_spin_newwith Xe. --------------------------------------------------------------- ^so it will be:
[PATCH i-g-t 1/2]
lib/xe/xe_spin: Integrateigt_spin_newwith XeThe same follows for your second patch. I have few more nits, see below.
Quoted 3 lines
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we aresupposed to do it manually for xe.
Quoted 6 lines
Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 +++++++++--- lib/igt_dummyload.h | 10 +++++ lib/xe/xe_spin.c | 91+++++++++++++++++++++++++++++++++++++++++++++
Quoted 27 lines
lib/xe/xe_spin.h | 7 ++++ 4 files changed, 126 insertions(+), 6 deletions(-)lib/igt_dummyload.c index renamed from lib/igt_dummyload.c +0
-0
740a58f3..6e89b72d100644lib/igt_dummyload.c +5
-1@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload @@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts) igt_spin_t * __igt_spin_factory(int fd, const structigt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/** lib/igt_dummyload.c igt_spin_factory(int fd, const struct · line 479
Quoted 9 lines
lib/igt_dummyload.c +5
-0@@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) { igt_spin_t *spin; + if (is_xe_device(fd)) { + spin = xe_spin_create(fd, opts); + return spin; + } + if ((opts->flags & IGT_SPIN_POLL_RUN) && opts->engine !=
ALL_ENGINES) {Quoted 21 lines
lib/igt_dummyload.c +8
-5unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }
Quoted 11 lines
lib/igt_dummyload.h typedef struct igt_spin_factory { · line 58
Quoted 11 lines
lib/igt_dummyload.c +0
-0void igt_terminate_spins (void )lib/igt_dummyload.h index renamed from lib/igt_dummyload.h +0
-0
b247ab02..7bcc7b56100644lib/igt_dummyload.h +2
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm;
Add description of newly added variables
Quoted 6 lines
Quoted 6 lines
lib/igt_dummyload.h +0
-0} igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,14 @@ typedef struct igt_spin { #define SPIN_CLFLUSH (1 << 0)
Quoted 7 lines
lib/igt_dummyload.h typedef struct igt_spin { · line 93
Quoted 7 lines
lib/igt_dummyload.h +6
-0struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm;
vm defined inside spin_factory as well, can we avoid this if it is redundant
Thanks,
Rahul
Quoted 194 lines
Quoted 10 lines
lib/igt_dummyload.h +2
-0+uint32_t syncobj; + } igt_spin_t;lib/xe/xe_spin.c index renamed from lib/xe/xe_spin.c +0
-0
856d0ba2..bc0fbcc6100644lib/xe/xe_spin.c line 18
Quoted 4 lines
lib/xe/xe_spin.c +1
-0@@ -15,6 +15,7 @@#include "intel_reg.h" #include "xe_ioctl.h" #include "xe_spin.h" +#include "lib/igt_dummyload.h" ------------ ^
Do we need "lib/" here ? Please also put this in alphabetical order.lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 85
Quoted 7 lines
lib/xe/xe_spin.c +0
-0/** * xe_spin_init: @@ -82,6 +83,96 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; }Please describe each new public function you added.
Quoted 20 lines
lib/xe/xe_spin.c +20
-0+igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) { +size_t bo_size =xe_get_default_alignment (fd); +uint32_t bo; +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync), + }; + +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); +lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin)
Quoted 10 lines
lib/xe/xe_spin.c +9
-0+ spin->syncobj =syncobj_create (fd,0 ); +if (opt->engine) { + spin->opts.engine = opt->engine; + spin->opts.vm = opt->vm; + + spin->handle =xe_bo_create (fd,0 , spin->opts.vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin- handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); + xe_vm_bind_sync(fd, spin->opts.vm, spin->handle, 0, addr,
bo_size);Quoted 18 lines
lib/xe/xe_spin.c +15
-0+ +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->opts.engine; + exec.address = addr; + }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (!opt->hwe) + spin->engine =xe_engine_create_class (fd, spin- vm,DRM_XE_ENGINE_CLASS_RENDER ); +else + spin->engine =xe_engine_create (fd, spin->vm, opt- hwe,0 ); + + bo =xe_bo_create (fd,0 , spin->vm, bo_size); + spin->handle = bo; + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr = intel_allocator_alloc_with_strategy(ahnd, spin-handle,
bo_size, 0,ALLOC_STRATEGY_LOW_TO_HIGH);lib/xe/xe_spin.c
Quoted 1 line
lib/xe/xe_spin.c +1
-0+ xe_vm_bind_sync(fd, spin->vm, spin->handle, 0, addr,
bo_size);lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 136
Quoted 5 lines
lib/xe/xe_spin.c +5
-0+ +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr; + }Put newline here.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 148
Quoted 12 lines
lib/xe/xe_spin.c +12
-0+ sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); +igt_info ("Spinner started\n" ); + + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} +Write description.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 152
Quoted 3 lines
lib/xe/xe_spin.c +3
-0+void xe_spin_sync_wait (int fd,struct igt_spin *spin) { +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 , +NULL ));imho you can have it in one line:
igt_assert(syncobj_wait(fd, &spin->syncobj, 1, INT64_MAX, 0,NULL));
lib/xe/xe_spin.c
Quoted 2 lines
lib/xe/xe_spin.c +2
-0+} +Write description.
Quoted 9 lines
lib/xe/xe_spin.c +6
-0+void xe_spin_free (int fd,struct igt_spin *spin) { +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); + +if (!spin->opts.vm) + xe_vm_unbind_sync(fd, spin->vm, 0, spin->address, spin-
bo_size);lib/xe/xe_spin.c +2
-0+else + xe_vm_unbind_sync(fd, spin->opts.vm, 0, spin->address,lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 172
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+spin->bo_size); + +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->opts.engine) { +xe_engine_destroy (fd, spin->engine); +xe_vm_destroy (fd, spin->vm); + }Put newline here.
Quoted 11 lines
lib/xe/xe_spin.c +3
-0+free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h index renamed from lib/xe/xe_spin.h +0
-0
73f9a026..48867eb8100644lib/xe/xe_spin.h line 19
Quoted 7 lines
lib/xe/xe_spin.h +2
-0@@ -13,19 +13,26 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ +Please do not make cleanups when adding new functionality, remove this newline.
lib/xe/xe_spin.h line 25
Quoted 6 lines
lib/xe/xe_spin.h +1
-0struct xe_spin {uint32_t batch[16 ];uint64_t pad;uint32_t start;uint32_t end; +Same here, remove this line.
lib/xe/xe_spin.h line 28
Quoted 3 lines
lib/xe/xe_spin.h +1
-0}; +igt_spin_t *-- ^
lib/xe/xe_spin.h line 29
Quoted 1 line
lib/xe/xe_spin.h +1
-0+xe_spin_create(int fd, const struct igt_spin_factory *opt);-- ^
imho here one-liner is better:
igt_spin_t*xe_spin_create(int fd, const structigt_spin_factory*opt);Regards,
KamilQuoted 12 lines
lib/xe/xe_spin.h +2
-1void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin; --2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
Hi Kamil, Rahul,
Thanks for the review comments, I'm sending a new patch which addresses few corrections and addressing your comments.
Thanks,
Gowtham
Quoted 332 lines
-----Original Message-----
From: Kumar, Janga Rahul <[email protected]>
Sent: Thursday, June 1, 2023 1:30 PM
To: [email protected]; Ch, Sai Gowtham <[email protected]>
Cc: Kamil Konieczny <[email protected]>
Subject: RE: [igt-dev] [PATCH i-g-t 1/2]lib/xe/xe_spin: Integrateigt_spin_newwith Xe.Quoted 96 lines
-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kamil Konieczny
Sent: 01 June 2023 10:42
To: [email protected]
Cc: Ch, Sai Gowtham <[email protected]>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2]lib/xe/xe_spin: Integrateigt_spin_newwith Xe.Hi Sai,
Quoted 2 lines · On 2023-05-30 at 15:38:04 +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
please remove dot from end of Subject line:
[PATCH i-g-t 1/2]
lib/xe/xe_spin: Integrateigt_spin_newwith Xe. --------------------------------------------------------------- ^so it will be:
[PATCH i-g-t 1/2]
lib/xe/xe_spin: Integrateigt_spin_newwith XeThe same follows for your second patch. I have few more nits, see below.
Quoted 3 lines
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we aresupposed to do it manually for xe.
Quoted 6 lines
Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 +++++++++--- lib/igt_dummyload.h | 10 +++++ lib/xe/xe_spin.c | 91+++++++++++++++++++++++++++++++++++++++++++++
Quoted 28 lines
lib/xe/xe_spin.h | 7 ++++ 4 files changed, 126 insertions(+), 6 deletions(-)lib/igt_dummyload.c index renamed from lib/igt_dummyload.c +0
-0
740a58f3..6e89b72d100644lib/igt_dummyload.c +1
-0@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload @@ -447,7 +448,10 @@ spin_create(int fd, const struct
igt_spin_factory
*opts)igt_spin_t*__igt_spin_factory(int fd, const struct igt_spin_factory *opts){lib/igt_dummyload.c +4
-1-return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/** lib/igt_dummyload.c igt_spin_factory(int fd, const struct · line 479
Quoted 9 lines
lib/igt_dummyload.c +5
-0@@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) { igt_spin_t *spin; + if (is_xe_device(fd)) { + spin = xe_spin_create(fd, opts); + return spin; + } + if ((opts->flags & IGT_SPIN_POLL_RUN) && opts->engine !=
ALL_ENGINES) {Quoted 21 lines
lib/igt_dummyload.c +8
-5unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }Quoted 11 lines
lib/igt_dummyload.h typedef struct igt_spin_factory { · line 58
Quoted 11 lines
lib/igt_dummyload.c +0
-0void igt_terminate_spins (void )lib/igt_dummyload.h index renamed from lib/igt_dummyload.h +0
-0
b247ab02..7bcc7b56100644lib/igt_dummyload.h +2
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm;Add description of newly added variables
Quoted 6 lines
Quoted 6 lines
lib/igt_dummyload.h +0
-0} igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,14 @@ typedef struct igt_spin { #define SPIN_CLFLUSH (1 <<0 )Quoted 7 lines
lib/igt_dummyload.h typedef struct igt_spin { · line 93
Quoted 7 lines
lib/igt_dummyload.h +6
-0struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm;vm defined inside
spin_factoryas well, can we avoid this if it is redundantThanks,
RahulQuoted 194 lines
Quoted 10 lines
lib/igt_dummyload.h +2
-0+uint32_t syncobj; + } igt_spin_t;lib/xe/xe_spin.c index renamed from lib/xe/xe_spin.c +0
-0
856d0ba2..bc0fbcc6100644lib/xe/xe_spin.c line 18
Quoted 4 lines
lib/xe/xe_spin.c +1
-0@@ -15,6 +15,7 @@#include "intel_reg.h" #include "xe_ioctl.h" #include "xe_spin.h" +#include "lib/igt_dummyload.h" ------------ ^
Do we need "lib/" here ? Please also put this in alphabetical order.lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 85
Quoted 7 lines
lib/xe/xe_spin.c +0
-0/** * xe_spin_init: @@ -82,6 +83,96 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; }Please describe each new public function you added.
Quoted 20 lines
lib/xe/xe_spin.c +20
-0+igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) { +size_t bo_size =xe_get_default_alignment (fd); +uint32_t bo; +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync), + }; + +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); +lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin)
Quoted 10 lines
lib/xe/xe_spin.c +9
-0+ spin->syncobj =syncobj_create (fd,0 ); +if (opt->engine) { + spin->opts.engine = opt->engine; + spin->opts.vm = opt->vm; + + spin->handle =xe_bo_create (fd,0 , spin->opts.vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin- handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); + xe_vm_bind_sync(fd, spin->opts.vm, spin->handle, 0, addr,
bo_size);Quoted 18 lines
lib/xe/xe_spin.c +15
-0+ +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->opts.engine; + exec.address = addr; + }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (!opt->hwe) + spin->engine =xe_engine_create_class (fd, spin- vm,DRM_XE_ENGINE_CLASS_RENDER ); +else + spin->engine =xe_engine_create (fd, spin->vm, opt- hwe,0 ); + + bo =xe_bo_create (fd,0 , spin->vm, bo_size); + spin->handle = bo; + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr = intel_allocator_alloc_with_strategy(ahnd, spin-handle,
bo_size, 0,ALLOC_STRATEGY_LOW_TO_HIGH);lib/xe/xe_spin.c
Quoted 1 line
lib/xe/xe_spin.c +1
-0+ xe_vm_bind_sync(fd, spin->vm, spin->handle, 0, addr,
bo_size);lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 136
Quoted 5 lines
lib/xe/xe_spin.c +5
-0+ +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr; + }Put newline here.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 148
Quoted 12 lines
lib/xe/xe_spin.c +12
-0+ sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); +igt_info ("Spinner started\n" ); + + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} +Write description.
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 152
Quoted 3 lines
lib/xe/xe_spin.c +3
-0+void xe_spin_sync_wait (int fd,struct igt_spin *spin) { +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 , +NULL ));imho you can have it in one line:
igt_assert(syncobj_wait(fd, &spin->syncobj, 1, INT64_MAX, 0, NULL));lib/xe/xe_spin.c
Quoted 2 lines
lib/xe/xe_spin.c +2
-0+} +Write description.
Quoted 9 lines
lib/xe/xe_spin.c +6
-0+void xe_spin_free (int fd,struct igt_spin *spin) { +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); + +if (!spin->opts.vm) + xe_vm_unbind_sync(fd, spin->vm, 0, spin->address, spin-
bo_size);lib/xe/xe_spin.c +2
-0+else + xe_vm_unbind_sync(fd, spin->opts.vm, 0, spin->address,lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 172
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+spin->bo_size); + +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->opts.engine) { +xe_engine_destroy (fd, spin->engine); +xe_vm_destroy (fd, spin->vm); + }Put newline here.
Quoted 11 lines
lib/xe/xe_spin.c +3
-0+free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h index renamed from lib/xe/xe_spin.h +0
-0
73f9a026..48867eb8100644lib/xe/xe_spin.h line 19
Quoted 7 lines
lib/xe/xe_spin.h +2
-0@@ -13,19 +13,26 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ +Please do not make cleanups when adding new functionality, remove this newline.
lib/xe/xe_spin.h line 25
Quoted 6 lines
lib/xe/xe_spin.h +1
-0struct xe_spin {uint32_t batch[16 ];uint64_t pad;uint32_t start;uint32_t end; +Same here, remove this line.
lib/xe/xe_spin.h line 28
Quoted 3 lines
lib/xe/xe_spin.h +1
-0}; +igt_spin_t *-- ^
lib/xe/xe_spin.h line 29
Quoted 1 line
lib/xe/xe_spin.h +1
-0+xe_spin_create(int fd, const struct igt_spin_factory *opt);-- ^
imho here one-liner is better:
igt_spin_t*xe_spin_create(int fd, const structigt_spin_factory*opt);Regards,
KamilQuoted 12 lines
lib/xe/xe_spin.h +2
-1void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin; --2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe.
In reply to Kumar, Janga RahulOn Thu, Jun 01, 2023 at 07:59:49AM +0000, Kumar, Janga Rahul wrote:
<cut>
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
typedef struct
igt_spin{(quoted diff) +0
-0@@ -83,6 +85,14 @@ typedef struct igt_spin { #define SPIN_CLFLUSH (1 << 0)
Quoted 8 lines
Quoted 7 lines
lib/igt_dummyload.h typedef struct igt_spin { · line 93
Quoted 7 lines
lib/igt_dummyload.h +6
-0struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm;vm defined inside
spin_factoryas well, can we avoid this if it is redundant
I think it can be useful to assign external vm or create a new one in it. Then on free path you're destroying only vm you own.
--
Zbigniew
Quoted 5 lines
Thanks,
RahulQuoted 1 line
Quoted 1 line
lib/igt_dummyload.h +1
-0+uint32_t syncobj;
PATCH 2/2 tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe.
In reply to [email protected]From: Sai Gowtham Ch <[email protected]>
xe_spin_batch test exercises igt_spin_new submissions with different combinations.
--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.c
tests/meson.build +1 -0
@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [
tests/xe/xe_spin_batch.c new file +168 -0
168 lines not on this page · raw message
Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe.
Quoted 34 lines · On Tue, May 30, 2023 at 03:38:05PM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
xe_spin_batchtest exercisesigt_spin_newsubmissions with different combinations.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.ctests/meson.build +1
-0@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [tests/xe/xe_spin_batch.c new file +3
-0@@ -0,0 +1,168 @@ +#include "igt.h" +#include "lib/intel_reg.h" +#include "xe_drm.h"
tests/xe/xe_spin_batch.c line 13
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+#include "xe/xe_ioctl.h" +#include "xe/xe_query.h" + +#define MAX_INSTANCE 9 + +/** +* TEST: Basic test for spin batch submissons. +* +* SUBTEST: spin-basic +* Description: Basic test to submit spin batch submissons.
Add information to which engine it will submit the spinner.
tests/xe/xe_spin_batch.c line 25
Quoted 12 lines
tests/xe/xe_spin_batch.c new file +12
-0+* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_basic (int fd) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd);
Why not just igt_spin_new()?
tests/xe/xe_spin_batch.c line 30
Quoted 5 lines
tests/xe/xe_spin_batch.c new file +5
-0+igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +}
Rest is ok.
tests/xe/xe_spin_batch.c line 33
Quoted 3 lines
tests/xe/xe_spin_batch.c new file +3
-0+ +/** +* TEST:Test for spin batch submissons.
^ space.
tests/xe/xe_spin_batch.c line 36
Quoted 3 lines
tests/xe/xe_spin_batch.c new file +3
-0+* +* SUBTEST: spin-batch +* Description: Test to submit spin batch with engines and vm.
Maybe: Create vm and engine of hwe class and run the spinner on it.
Quoted 15 lines
tests/xe/xe_spin_batch.c new file +15
-0+* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin (int fd,struct drm_xe_engine_class_instance *hwe) +{ +uint64_t ahnd; +unsigned int engine; +uint32_t vm; +igt_spin_t *spin; + + vm =xe_vm_create (fd,0 ,0 ); + engine =xe_engine_create (fd, vm, hwe,0 ); + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC );
tests/xe/xe_spin_batch.c line 61
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+ + spin = __igt_spin_new(fd, .ahnd = ahnd, .engine = engine, .vm = vm); +igt_assert (spin); + +igt_spin_free (fd, spin); +xe_engine_destroy (fd, engine); +xe_vm_destroy (fd, vm); + +put_ahnd (ahnd); +}
Test itself looks good.
tests/xe/xe_spin_batch.c line 72
Quoted 11 lines
tests/xe/xe_spin_batch.c new file +11
-0+ +/** +* TEST: Basic test for spin batch submission on all hwe. +* +* SUBTEST: spin-basic-all +* Description: Basic test which validates the functionality of spinner on all hwe. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ +static void spin_basic_all (int fd,struct drm_xe_engine_class_instance *hwe)
^ ---- if for all what hwe is for here?
tests/xe/xe_spin_batch.c line 78
Quoted 6 lines
tests/xe/xe_spin_batch.c new file +6
-0+{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd, .hwe = hwe);
I would expect:
spin = igt_spin_new(fd, .ahnd = ahnd, .engine = ALL_ENGINES);
tests/xe/xe_spin_batch.c line 88
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST: Test for spin batch submissions. +* SUBTEST: spin-all +* Description: Spinner test to run on all the engines!
^ what ! is for?
tests/xe/xe_spin_batch.c line 94
Quoted 6 lines
tests/xe/xe_spin_batch.c new file +6
-0+* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_all (int fd,int gt,int class)
^ unnecessary space
tests/xe/xe_spin_batch.c line 98
Quoted 4 lines
tests/xe/xe_spin_batch.c new file +4
-0+{ +uint64_t ahnd; +uint32_t engines[MAX_INSTANCE ]; +uint32_t vm[MAX_INSTANCE ];
You may use single vm here. Let's see how spinners will share same address space.
tests/xe/xe_spin_batch.c line 110
Quoted 12 lines
tests/xe/xe_spin_batch.c new file +12
-0+int i, num_placements =0 ; +struct drm_xe_engine_class_instance eci[MAX_INSTANCE ]; +igt_spin_t *spin[MAX_INSTANCE ]; +struct drm_xe_engine_class_instance *hwe; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + +xe_for_each_hw_engine (fd, hwe) { +if (hwe->engine_class != class || hwe->gt_id != gt) +continue ; + eci[num_placements++] = *hwe; + }
What's your intention here? To run spinners on dedicated gt and some class?
--
Zbigniew
Quoted 61 lines
tests/xe/xe_spin_batch.c new file +58
-0+if (num_placements <2 ) +return ; + +for (i =0 ; i < num_placements; i++) { +struct drm_xe_engine_create create; + vm[i] =xe_vm_create (fd,0 ,0 ); + + create.vm_id = vm[i]; + create.width =1 ; + create.num_placements = num_placements; + create.instances =to_user_pointer (eci); + +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_ENGINE_CREATE , + &create),0 ); + engines[i] = create.engine_id; + spin[i] = __igt_spin_new(fd, .ahnd = ahnd, .engine = engines[i], .vm = vm[i]); + } + +for (i =0 ; i < num_placements; i++) { +igt_assert (spin[i]); +igt_spin_free (fd, spin[i]); + } +put_ahnd (ahnd); +} + +igt_main +{ +struct drm_xe_engine_class_instance *hwe; +int fd; +int gt, class; + + igt_fixture { + fd =drm_open_driver (DRIVER_XE ); +xe_device_get (fd); + } + + igt_subtest("spin-basic") +spin_basic (fd); + + igt_subtest("spin-batch") +xe_for_each_hw_engine (fd, hwe) +spin (fd, hwe); + + igt_subtest("spin-basic-all") +xe_for_each_hw_engine (fd, hwe) +spin_basic_all (fd, hwe); + + igt_subtest("spin-all") { +xe_for_each_gt (fd, gt) +xe_for_each_hw_engine_class (class) +spin_all (fd, gt, class); + } + + igt_fixture { +xe_device_put (fd); +close (fd); + } +}Signature · 1 line
2.39.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Integrate igt_spin_new with Xe. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Integrate igt_spin_new with Xe. (rev3)
URL : https://patchwork.freedesktop.org/series/118121/
State : success
== Summary ==
CI Bug Log - changes from IGT_7311 -> IGTPW_9070
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html
Participating hosts (36 -> 37)
------------------------------
Additional (1): bat-mtlp-6
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9070:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gem_contexts:
- {bat-mtlp-6}: NOTRUN -> [ABORT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-mtlp-6/igt@i915_selftest@live@gem_contexts.html
Known issues
------------
Here are the changes found in IGTPW_9070 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- bat-adlm-1: [PASS][2] -> [INCOMPLETE][3] ([i915#4983] / [i915#7677])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-adlm-1/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-adlm-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@migrate:
- bat-adlp-9: [PASS][4] -> [DMESG-FAIL][5] ([i915#7699] / [i915#7913])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-adlp-9/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-adlp-9/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][6] -> [ABORT][7] ([i915#7911] / [i915#7920] / [i915#7982])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-rpls-1/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][8] ([i915#6367])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@workarounds:
- bat-dg1-7: [PASS][9] -> [ABORT][10] ([i915#4983])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-dg1-7/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-dg1-7/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][11] ([i915#6687])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-rpls-2/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc:
- bat-adlp-9: NOTRUN -> [SKIP][12] ([i915#3546]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-adlp-9/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
- bat-dg1-5: [PASS][13] -> [FAIL][14] ([fdo#103375]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-dg1-5/igt@kms_pipe_crc_basic@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-dg1-5/igt@kms_pipe_crc_basic@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@requests:
- {bat-mtlp-8}: [DMESG-FAIL][15] ([i915#8497]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-mtlp-8/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-mtlp-8/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][17] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-rpls-2/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-mtlp-8}: [DMESG-WARN][19] ([i915#6367]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-mtlp-8/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-mtlp-8/igt@i915_selftest@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-d-dp-1:
- bat-dg2-8: [FAIL][21] ([i915#7932]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7677]: https://gitlab.freedesktop.org/drm/intel/issues/7677
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7311 -> IGTPW_9070
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9070: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html
IGT_7311: c031030f39aff973330668a5a2f1593408da78ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-0-25 +igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25 +igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-0-25 +igt@xe_spin_batch@spin-all
+igt@xe_spin_batch@spin-basic +igt@xe_spin_batch@spin-basic-all +igt@xe_spin_batch@spin-batch -igt@kms_plane_scaling@planes-downscale-factor-0-5-upscale-factor-0-25 -igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25 -igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-factor-0-25
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for Integrate igt_spin_new with Xe. (rev3)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Integrate igt_spin_new with Xe. (rev3)
URL : https://patchwork.freedesktop.org/series/118121/
State : success
== Summary ==
CI Bug Log - changes from IGT_7311_full -> IGTPW_9070_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in IGTPW_9070_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk5/igt@gem_exec_fair@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@massive:
- shard-apl: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl2/igt@[email protected]
* igt@gem_lmem_swapping@verify-ccs:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk7/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][5] ([i915#2658])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl2/igt@[email protected]
* igt@gem_userptr_blits@access-control:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271]) +59 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk6/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][7] -> [ABORT][8] ([i915#5566])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk8/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-apl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl7/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1937] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk1/igt@i915_pm_lpsp@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl1/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3886]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk7/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_mtl_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +44 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl3/igt@kms_ccs@pipe-d-bad-rotation-90-4_tiled_mtl_mc_ccs.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x32:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl4/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2122])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk6/igt@kms_flip@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk5/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#1188])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-apl6/igt@kms_hdr@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl4/igt@kms_hdr@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4579]) +15 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-snb1/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271]) +21 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-snb4/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4579]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk8/igt@kms_plane_scaling@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl6/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#658]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk2/igt@[email protected]
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [ABORT][25] ([i915#6333] / [i915#7461] / [i915#8234]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-dg1-17/igt@gem_barrier_race@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-dg1-14/igt@gem_barrier_race@[email protected]
- shard-glk: [ABORT][27] ([i915#7461] / [i915#8211]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk8/igt@gem_barrier_race@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk3/igt@gem_barrier_race@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][29] ([i915#6268]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-tglu-6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-tglu-4/igt@[email protected]
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][31] ([i915#5784]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-dg1-14/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-dg1-15/igt@[email protected]
* igt@gem_exec_fair@basic-none@bcs0:
- {shard-rkl}: [FAIL][33] ([i915#2842]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-rkl-4/igt@gem_exec_fair@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-rkl-7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][35] ([i915#2842]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk9/igt@gem_exec_fair@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: [ABORT][37] ([i915#180] / [i915#8213]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-apl2/igt@gem_exec_suspend@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl7/igt@gem_exec_suspend@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][39] ([i915#2346]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_hdmi_inject@inject-audio:
- {shard-rkl}: [SKIP][41] ([i915#433]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-rkl-7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-rkl-6/igt@[email protected]
- shard-snb: [SKIP][43] ([fdo#109271]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-snb7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-snb4/igt@[email protected]
- shard-glk: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7311/shard-glk1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/shard-glk8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6333]: https://gitlab.freedesktop.org/drm/intel/issues/6333
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7311 -> IGTPW_9070
CI-20190529: 20190529
CI_DRM_13200: 0ae4ee2c735979030a0219218081eee661606921 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9070: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html
IGT_7311: c031030f39aff973330668a5a2f1593408da78ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9070/index.html