Staging: rts5208: rtsx: Removed new line in else and else if
PATCH v5 1/1 Staging: rts5208: rtsx: Removed new line in else and else if
Removed new line in else and else if,
this warning was given by checkpatch.pl
Signed-off-by Deepanshu Kartikey <[email protected]>
---
Changes in V5
- Moved else and else if to the same line
- Moved comment on else and else if statement to inside of it
---
--- drivers/staging/rts5208/rtsx.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-)
drivers/staging/rts5208/rtsx.c +7 -13
@@ -382,27 +382,21 @@ static int rtsx_control_thread(void *__dev)if (chip->srb->sc_data_direction ==DMA_BIDIRECTIONAL ) {dev_err (&dev->pci->dev,"UNKNOWN data direction\n" ); chip->srb->result =DID_ERROR <<16 ; - } - -/* reject if target != 0 or if LUN is higher than -* the maximum known LUN -*/ -else if (chip->srb->device->id) { + }else if (chip->srb->device->id) { +/* reject if target != 0 or if LUN is higher than +* the maximum known LUN +*/ dev_err (&dev->pci->dev,"Bad target number (%d:%d)\n" , chip->srb->device->id, (u8 )chip->srb->device->lun); chip->srb->result =DID_BAD_TARGET <<16 ; - } - -else if (chip->srb->device->lun > chip->max_lun) { + }else if (chip->srb->device->lun > chip->max_lun) {dev_err (&dev->pci->dev,"Bad LUN (%d:%d)\n" , chip->srb->device->id, (u8 )chip->srb->device->lun); chip->srb->result =DID_BAD_TARGET <<16 ; - } - -/* we've got a command, let's do it! */ -else { + }else { +/* we've got a command, let's do it! */ scsi_show_command (chip);rtsx_invoke_transport (chip->srb, chip); }
Signature · 1 line
2.25.1
Quoted 9 lines · Deepanshu Kartikey
Removed new line in else and else if,
this warning was given by checkpatch.plSigned-off-by Deepanshu Kartikey <[email protected]>---
Changes in V5
- Moved else and else if to the same line
- Moved comment on else and else if statement to inside of it
LGTM. Thanks!
Reviewed-by Dan Carpenter <[email protected]>
regards,
dan carpenter