Hexagon: Replace all non-returning strlcpy with strscpy
PATCH 1/1 Hexagon: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
--- arch/hexagon/kernel/setup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/hexagon/kernel/setup.c +3 -3
@@ -66,9 +66,9 @@ void __init setup_arch(char **cmdline_p) on_simulator =0 ;if (p[0 ] !='\0' ) -strlcpy (boot_command_line, p,COMMAND_LINE_SIZE ); +strscpy (boot_command_line, p,COMMAND_LINE_SIZE );else -strlcpy (boot_command_line, default_command_line, +strscpy (boot_command_line, default_command_line,COMMAND_LINE_SIZE );/*
@@ -76,7 +76,7 @@ void __init setup_arch(char **cmdline_p)* are both picked up by the init code. If no reason to * make them different, pass the same pointer back. */ -strlcpy (cmd_line, boot_command_line,COMMAND_LINE_SIZE ); +strscpy (cmd_line, boot_command_line,COMMAND_LINE_SIZE ); *cmdline_p = cmd_line;parse_early_param ();
Quoted 8 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.
Quoted 4 lines
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by Azeem Shaikh <[email protected]>
Signature · 1 line
Kees Cook
Kees Cook
AppliedQuoted 9 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.[...]
Successfully build tested with Clang 17.
Applied to for-next/hardening, thanks!
[1/1] Hexagon: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/f0e212de87a1
Signature · 1 line
Kees Cook