Skip to contentSkip to conversation

ARM: dts: stm32: fix display pinmux for stm32f746-disco

PATCH Superseded Dario Binacchi 3 participants 4 messages Jun 1, 2023 – Jun 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: fix display pinmux for stm32f746-disco

As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9 -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/stm32f746-disco-u-boot.dtsi +1 -1
index 19b5451db441..522cffb1ac9f 100644
@@ -169,7 +169,7 @@
 	ltdc_pins: ltdc@0 {
 		pins {
 			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
-				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
+				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
 				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
 				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
 				 <STM32_PINMUX('I',14, AF14)>, /* CLK */
Signature · 1 line
2.32.0
#1 lore raw
Quoted 19 lines · Dario Binacchi

As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9 -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/stm32f746-disco-u-boot.dtsi +0 -0
index 19b5451db441..522cffb1ac9f 100644

arch/arm/dts/stm32f746-disco-u-boot.dtsi line 175

Quoted 8 lines
arch/arm/dts/stm32f746-disco-u-boot.dtsi +1 -1
@@ -169,7 +169,7 @@
 	ltdc_pins: ltdc@0 {
 		pins {
 			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
-				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
+				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
 				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
 				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
 				 <STM32_PINMUX('I',14, AF14)>, /* CLK */

Why is this whole stanza in a -u-boot.dtsi file and not an upstream file?

Signature · 1 line
Tom
#2 lore raw
Quoted 16 lines · Tom Rini
Quoted 14 lines · Dario Binacchi

As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9 -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines

arch/arm/dts/stm32f746-disco-u-boot.dtsi line 175

Quoted 13 lines
arch/arm/dts/stm32f746-disco-u-boot.dtsi +1 -1
index 19b5451db441..522cffb1ac9f 100644
@@ -169,7 +169,7 @@
      ltdc_pins: ltdc@0 {
              pins {
                      pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
-                              <STM32_PINMUX('G',12, AF14)>, /* B4 */
+                              <STM32_PINMUX('G',12, AF9)>,  /* B4 */
                               <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
                               <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
                               <STM32_PINMUX('I',14, AF14)>, /* CLK */

Why is this whole stanza in a -u-boot.dtsi file and not an upstream file?

I just submitted a series to the linux kernel to add support for display on stm32f746-disco.
https://lore.kernel.org/linux-arm-kernel/[email protected]/T/

Thanks and regards,
Dario

Quoted 3 lines

--
Tom

Signature · 17 lines
Dario Binacchi

Senior Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com
#3 lore raw
In reply to Tom Rini

Hi Tom

Quoted 15 lines · Tom Rini
Quoted 14 lines · Dario Binacchi

As reported by the datasheet (DocID027590 Rev 4) for PG12:
- AF9 -> LCD_B4
- AF14 -> LCD_B1

So replace AF14 with AF9 for PG12 in the dts.

Fixes fe63d3cfb77ef ("ARM: dts: stm32: Sync DT with v4.20 kernel for stm32f7")

---

 arch/arm/dts/stm32f746-disco-u-boot.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

arch/arm/dts/stm32f746-disco-u-boot.dtsi line 175

Quoted 13 lines
arch/arm/dts/stm32f746-disco-u-boot.dtsi +1 -1
index 19b5451db441..522cffb1ac9f 100644
@@ -169,7 +169,7 @@
 	ltdc_pins: ltdc@0 {
 		pins {
 			pinmux = <STM32_PINMUX('E', 4, AF14)>, /* B0 */
-				 <STM32_PINMUX('G',12, AF14)>, /* B4 */
+				 <STM32_PINMUX('G',12, AF9)>,  /* B4 */
 				 <STM32_PINMUX('I', 9, AF14)>, /* VSYNC */
 				 <STM32_PINMUX('I',10, AF14)>, /* HSYNC */
 				 <STM32_PINMUX('I',14, AF14)>, /* CLK */

Why is this whole stanza in a -u-boot.dtsi file and not an upstream file?

LTDC entry has been put in stm32f746-disco-u-boot.dtsi by anticipation as described in commit 01aabf97d1f0 ("ARM: dts: stm32: Migrate U-boot nodes to U-boot DT files for stm32f7")

So U-Boot DT will be synchronized with kernel one when Dario series will be available in kernel release. The LTDC entry located in stm32f746-disco-u-boot.dtsi will be then removed.

Thanks
Patrice