Skip to contentSkip to conversation

drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

PATCH Applied Min Li 3 participants 3 messages Jun 3, 2023 – Jun 5, 2023

Subsystems (3)
lore
Share & tools
lore

Min Li

author
#0 lore raw

PATCH v2 1/1 drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free.

---
Changes in v2:
- Remove unused robj, avoid compile complain

 drivers/gpu/drm/radeon/radeon_gem.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_gem.c +1 -3
index bdc5af23f005..d3f5ddbc1704 100644
@@ -459,7 +459,6 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
 	struct radeon_device *rdev = dev->dev_private;
 	struct drm_radeon_gem_set_domain *args = data;
 	struct drm_gem_object *gobj;
-	struct radeon_bo *robj;
 	int r;
 
 	/* for now if someone requests domain CPU -
@@ -472,13 +471,12 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
 		up_read(&rdev->exclusive_lock);
 		return -ENOENT;
 	}
-	robj = gem_to_radeon_bo(gobj);
 
 	r = radeon_gem_set_domain(gobj, args->read_domains, args->write_domain);
 
 	drm_gem_object_put(gobj);
 	up_read(&rdev->exclusive_lock);
-	r = radeon_gem_handle_lockup(robj->rdev, r);
+	r = radeon_gem_handle_lockup(rdev, r);
 	return r;
 }
 
Signature · 1 line
2.34.1
maintainer Reviewed-by on v2 1/1
#1 lore raw

Am 03.06.23 um 09:43 schrieb Min Li:

Quoted 5 lines

Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free.

Quoted 34 lines

---
Changes in v2:
- Remove unused robj, avoid compile complain

  drivers/gpu/drm/radeon/radeon_gem.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_gem.c +1 -3
index bdc5af23f005..d3f5ddbc1704 100644
@@ -459,7 +459,6 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
  	struct radeon_device *rdev = dev->dev_private;
  	struct drm_radeon_gem_set_domain *args = data;
  	struct drm_gem_object *gobj;
-	struct radeon_bo *robj;
  	int r;
 
  	/* for now if someone requests domain CPU -
@@ -472,13 +471,12 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
  		up_read(&rdev->exclusive_lock);
  		return -ENOENT;
  	}
-	robj = gem_to_radeon_bo(gobj);
 
  	r = radeon_gem_set_domain(gobj, args->read_domains, args->write_domain);
 
  	drm_gem_object_put(gobj);
  	up_read(&rdev->exclusive_lock);
-	r = radeon_gem_handle_lockup(robj->rdev, r);
+	r = radeon_gem_handle_lockup(rdev, r);
  	return r;
  }
 
Applied
#2 lore raw

Applied. Thanks!

Quoted 45 lines · Christian König

Am 03.06.23 um 09:43 schrieb Min Li:

Quoted 5 lines

Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free.

Quoted 34 lines

---
Changes in v2:
- Remove unused robj, avoid compile complain

  drivers/gpu/drm/radeon/radeon_gem.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/radeon/radeon_gem.c +1 -3
index bdc5af23f005..d3f5ddbc1704 100644
@@ -459,7 +459,6 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
      struct radeon_device *rdev = dev->dev_private;
      struct drm_radeon_gem_set_domain *args = data;
      struct drm_gem_object *gobj;
-     struct radeon_bo *robj;
      int r;
 
      /* for now if someone requests domain CPU -
@@ -472,13 +471,12 @@ int radeon_gem_set_domain_ioctl(struct drm_device *dev, void *data,
              up_read(&rdev->exclusive_lock);
              return -ENOENT;
      }
-     robj = gem_to_radeon_bo(gobj);
 
      r = radeon_gem_set_domain(gobj, args->read_domains, args->write_domain);
 
      drm_gem_object_put(gobj);
      up_read(&rdev->exclusive_lock);
-     r = radeon_gem_handle_lockup(robj->rdev, r);
+     r = radeon_gem_handle_lockup(rdev, r);
      return r;
  }