Skip to contentSkip to conversation

support trimed pca9450 new pmic

PATCH In review Joy Zou 2 participants 16 messages Jun 5, 2023 – Jun 6, 2023

Subsystems (2)
lore
Share & tools
lore

Joy Zou

author
#0 lore raw

cover support trimed pca9450 new pmic

The patchset supports trim pmic pca9451a. For the details, please check the patch commit log

Joy Zou (4):
power: pmic: Modify the BUCK1 voltage range
imx: imx93_evk: change VDD_SOC for new pmic trimed
DTS: imx93: modify the BUCK1 voltage range
configs: enable pmic regulator pca9450

 arch/arm/dts/imx93-11x11-evk.dts  | 20 ++------------------
 board/freescale/imx93_evk/spl.c   | 16 ++++++++++++++--
 configs/imx93_11x11_evk_defconfig |  2 ++
 drivers/power/regulator/pca9450.c | 29 ++++++++++++++++++++++++++++-
 include/power/pca9450.h           |  2 ++
 5 files changed, 48 insertions(+), 21 deletions(-)
Signature · 1 line
2.37.1
author
#1 lore raw

PATCH 1/4 power: pmic: Modify the BUCK1 voltage range

The new pmic trimed BUCK1. So need to modify the range.
The default value of Toff_Deb is used to distinguish the old and new pmic.

---
 drivers/power/regulator/pca9450.c | 29 ++++++++++++++++++++++++++++-
 include/power/pca9450.h           |  2 ++
 2 files changed, 30 insertions(+), 1 deletion(-)
drivers/power/regulator/pca9450.c +28 -1
index 7ca20d1f7f..f0b92ca037 100644
@@ -72,6 +72,10 @@ static struct pca9450_vrange pca9450_buck123_vranges[] = {
 	PCA_RANGE(600000, 12500, 0, 0x7f),
 };
 
+static struct pca9450_vrange pca9450_trim_buck13_vranges[] = {
+	PCA_RANGE(650000, 12500, 0, 0x7f),
+};
+
 static struct pca9450_vrange pca9450_buck456_vranges[] = {
 	PCA_RANGE(600000, 25000, 0, 0x70),
 	PCA_RANGE(3400000, 0, 0x71, 0x7f),
@@ -106,12 +110,18 @@ static struct pca9450_plat pca9450_reg_data[] = {
 	PCA_DATA("BUCK1", PCA9450_BUCK1CTRL, HW_STATE_CONTROL,
 		 PCA9450_BUCK1OUT_DVS0, PCA9450_DVS_BUCK_RUN_MASK,
 		 pca9450_buck123_vranges),
+	PCA_DATA("BUCK1_TRIM", PCA9450_BUCK1CTRL, HW_STATE_CONTROL,
+		 PCA9450_BUCK1OUT_DVS0, PCA9450_DVS_BUCK_RUN_MASK,
+		 pca9450_trim_buck13_vranges),
 	PCA_DATA("BUCK2", PCA9450_BUCK2CTRL, HW_STATE_CONTROL,
 		 PCA9450_BUCK2OUT_DVS0, PCA9450_DVS_BUCK_RUN_MASK,
 		 pca9450_buck123_vranges),
 	PCA_DATA("BUCK3", PCA9450_BUCK3CTRL, HW_STATE_CONTROL,
 		 PCA9450_BUCK3OUT_DVS0, PCA9450_DVS_BUCK_RUN_MASK,
 		 pca9450_buck123_vranges),
+	PCA_DATA("BUCK3_TRIM", PCA9450_BUCK3CTRL, HW_STATE_CONTROL,
+		 PCA9450_BUCK3OUT_DVS0, PCA9450_DVS_BUCK_RUN_MASK,
+		 pca9450_trim_buck13_vranges),
 	/* Bucks 4-6 which do not support dynamic voltage scaling */
 	PCA_DATA("BUCK4", PCA9450_BUCK4CTRL, HW_STATE_CONTROL,
 		 PCA9450_BUCK4OUT, PCA9450_DVS_BUCK_RUN_MASK,
@@ -272,7 +282,9 @@ static int pca9450_set_value(struct udevice *dev, int uvolt)
 static int pca9450_regulator_probe(struct udevice *dev)
 {
 	struct pca9450_plat *plat = dev_get_plat(dev);
-	int i, type;
+	int i, type, ret;
+	unsigned int val;
+	bool pmic_trim = false;
 
 	type = dev_get_driver_data(dev_get_parent(dev));
 
@@ -282,10 +294,25 @@ static int pca9450_regulator_probe(struct udevice *dev)
 		return -EINVAL;
 	}
 
+	ret = pmic_reg_read(dev->parent, PCA9450_PWR_CTRL);
+	if (ret < 0)
+		return ret;
+	else
+		val = ret;
+
+	if (type == NXP_CHIP_TYPE_PCA9451A && (val & PCA9450_REG_PWRCTRL_TOFF_DEB))
+		pmic_trim = true;
+
 	for (i = 0; i < ARRAY_SIZE(pca9450_reg_data); i++) {
 		if (strcmp(dev->name, pca9450_reg_data[i].name))
 			continue;
 
+		if (pmic_trim && (!strcmp(pca9450_reg_data[i].name, "BUCK1") ||
+				  !strcmp(pca9450_reg_data[i].name, "BUCK3"))) {
+			*plat = pca9450_reg_data[i + 1];
+			return 0;
+		}
+
 		/* PCA9450B/PCA9450C uses BUCK1 and BUCK3 in dual-phase */
 		if (type == NXP_CHIP_TYPE_PCA9450BC &&
 		    !strcmp(pca9450_reg_data[i].name, "BUCK3")) {
include/power/pca9450.h +2 -0
index b8219d535a..8b62f4e5e1 100644
@@ -63,6 +63,8 @@ enum {
 	NXP_CHIP_TYPE_AMOUNT
 };
 
+#define PCA9450_REG_PWRCTRL_TOFF_DEB    BIT(5)
+
 #define PCA9450_DVS_BUCK_RUN_MASK	0x7f
 #define PCA9450_LDO12_MASK		0x07
 #define PCA9450_LDO34_MASK		0x1f
Signature · 1 line
2.37.1
#2 lore raw

Re: [PATCH v1 1/4] power: pmic: Modify the BUCK1 voltage range

Quoted 2 lines · Joy Zou

The new pmic trimed BUCK1. So need to modify the range.
The default value of Toff_Deb is used to distinguish the old and new pmic.

[...]

include/power/pca9450.h enum { · line 70

Quoted 10 lines

+++ b/include/power/pca9450.h

include/power/pca9450.h +2 -0
@@ -63,6 +63,8 @@ enum {
  	NXP_CHIP_TYPE_AMOUNT
  };
 
+#define PCA9450_REG_PWRCTRL_TOFF_DEB    BIT(5)
+
  #define PCA9450_DVS_BUCK_RUN_MASK	0x7f
  #define PCA9450_LDO12_MASK		0x07
  #define PCA9450_LDO34_MASK		0x1f

Shouldn't there be a new DT compatible, 'nxp,pca9451a' somewhere ? Like e.g. in drivers/power/pmic/pca9450.c ?

author
#3 lore raw

RE: [EXT] Re: [PATCH v1 1/4] power: pmic: Modify the BUCK1 voltage range

Quoted 27 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:07
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 1/4] power: pmic: Modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 2 lines · Joy Zou

The new pmic trimed BUCK1. So need to modify the range.
The default value of Toff_Deb is used to distinguish the old and new pmic.

[...]

Quoted 5 lines

+++ b/include/power/pca9450.h

include/power/pca9450.h +0 -0
@@ -63,6 +63,8 @@ enum {
      NXP_CHIP_TYPE_AMOUNT
  };
 
Quoted 8 lines

include/power/pca9450.h enum { · line 70

Quoted 5 lines
include/power/pca9450.h +2 -0
+#define PCA9450_REG_PWRCTRL_TOFF_DEB    BIT(5)
+
  #define PCA9450_DVS_BUCK_RUN_MASK   0x7f
  #define PCA9450_LDO12_MASK          0x07
  #define PCA9450_LDO34_MASK          0x1f

Shouldn't there be a new DT compatible, 'nxp,pca9451a' somewhere ? Like e.g. in drivers/power/pmic/pca9450.c ?

Hi Marek,
The file drivers/power/pmic/pca9450.c and DT compatible 'nxp,pca9451a' already exists. Recently, the BUCK1 of the PMIC pca9451a is trimmed. So need to update. Thanks!
BR
Joy Zou

author
#4 lore raw

PATCH 2/4 imx: imx93_evk: change VDD_SOC for new pmic trimed

In reply to Joy Zou

Change VDD_SOC into 0.9v for over drive mode for new pmic.

---
 board/freescale/imx93_evk/spl.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
board/freescale/imx93_evk/spl.c +14 -2
index 1aa2977b40..f0dbd0f0a5 100644
@@ -55,6 +55,7 @@ int power_init_board(void)
 {
 	struct udevice *dev;
 	int ret;
+	unsigned int val = 0;
 
 	ret = pmic_get("pmic@25", &dev);
 	if (ret == -ENODEV) {
@@ -64,13 +65,24 @@ int power_init_board(void)
 	if (ret != 0)
 		return ret;
 
+	ret = pmic_reg_read(dev, PCA9450_PWR_CTRL);
+	if (ret < 0)
+		return ret;
+	else
+		val = ret;
+
 	/* BUCKxOUT_DVS0/1 control BUCK123 output */
 	pmic_reg_write(dev, PCA9450_BUCK123_DVS, 0x29);
 
 	/* 0.9v
 	 */
-	pmic_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x18);
-	pmic_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x18);
+	if (val & PCA9450_REG_PWRCTRL_TOFF_DEB) {
+		pmic_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x14);
+		pmic_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x14);
+	} else {
+		pmic_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x18);
+		pmic_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x18);
+	}
 
 	/* I2C_LT_EN*/
 	pmic_reg_write(dev, 0xa, 0x3);
Signature · 1 line
2.37.1
#5 lore raw

Re: [PATCH v1 2/4] imx: imx93_evk: change VDD_SOC for new pmic trimed

On 6/5/23 11:48, Joy Zou wrote:

Tags are
ARM: imx:

Quoted 1 line

Change VDD_SOC into 0.9v for over drive mode for new pmic.

0.9V , V in caps
PMIC in caps

Quoted 20 lines
---
  board/freescale/imx93_evk/spl.c | 16 ++++++++++++++--
  1 file changed, 14 insertions(+), 2 deletions(-)
board/freescale/imx93_evk/spl.c +1 -0
index 1aa2977b40..f0dbd0f0a5 100644
@@ -55,6 +55,7 @@ int power_init_board(void)
  {
  	struct udevice *dev;
  	int ret;
+	unsigned int val = 0;
 
  	ret = pmic_get("pmic@25", &dev);
  	if (ret == -ENODEV) {
@@ -64,13 +65,24 @@ int power_init_board(void)
  	if (ret != 0)
  		return ret;

[...]

author
#6 lore raw

RE: [EXT] Re: [PATCH v1 2/4] imx: imx93_evk: change VDD_SOC for new pmic trimed

Quoted 18 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:06
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 2/4] imx: imx93_evk: change VDD_SOC for new pmic trimed

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

On 6/5/23 11:48, Joy Zou wrote:

Quoted 7 lines

Tags are
ARM: imx:

Quoted 1 line

Change VDD_SOC into 0.9v for over drive mode for new pmic.

0.9V , V in caps
PMIC in caps

Okay, Thanks!
Will change in patch v2.
BR
Joy Zou

Quoted 23 lines
Quoted 21 lines
---
  board/freescale/imx93_evk/spl.c | 16 ++++++++++++++--
  1 file changed, 14 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/board/freescale/imx93_evk/spl.c index 1aa2977b40..f0dbd0f0a5 100644

board/freescale/imx93_evk/spl.c +1 -0
@@ -55,6 +55,7 @@ int power_init_board(void)
  {
      struct udevice *dev;
      int ret;
+     unsigned int val = 0;
 
      ret = pmic_get("pmic@25", &dev);
      if (ret == -ENODEV) {
@@ -64,13 +65,24 @@ int power_init_board(void)
      if (ret != 0)
              return ret;

[...]

author
#7 lore raw

PATCH 3/4 DTS: imx93: modify the BUCK1 voltage range

In reply to Joy Zou

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
 arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
 1 file changed, 2 insertions(+), 18 deletions(-)
arch/arm/dts/imx93-11x11-evk.dts +2 -18
index b3a5a3d71e..ceab56a5d8 100644
@@ -141,8 +141,8 @@
 		regulators {
 			buck1: BUCK1 {
 				regulator-name = "BUCK1";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <2187500>;
+				regulator-min-microvolt = <650000>;
+				regulator-max-microvolt = <2237500>;
 				regulator-boot-on;
 				regulator-always-on;
 				regulator-ramp-delay = <3125>;
@@ -189,22 +189,6 @@
 				regulator-always-on;
 			};
 
-			ldo2: LDO2 {
-				regulator-name = "LDO2";
-				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <1150000>;
-				regulator-boot-on;
-				regulator-always-on;
-			};
-
-			ldo3: LDO3 {
-				regulator-name = "LDO3";
-				regulator-min-microvolt = <800000>;
-				regulator-max-microvolt = <3300000>;
-				regulator-boot-on;
-				regulator-always-on;
-			};
-
 			ldo4: LDO4 {
 				regulator-name = "LDO4";
 				regulator-min-microvolt = <800000>;
Signature · 1 line
2.37.1
#8 lore raw

Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

On 6/5/23 11:48, Joy Zou wrote:

ARM: dts: imx93: ...
(not DTS:)

Quoted 13 lines

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
  arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
  1 file changed, 2 insertions(+), 18 deletions(-)
arch/arm/dts/imx93-11x11-evk.dts +0 -0
index b3a5a3d71e..ceab56a5d8 100644

arch/arm/dts/imx93-11x11-evk.dts line 145

Quoted 7 lines
arch/arm/dts/imx93-11x11-evk.dts +2 -2
@@ -141,8 +141,8 @@
  		regulators {
  			buck1: BUCK1 {
  				regulator-name = "BUCK1";
-				regulator-min-microvolt = <600000>;
-				regulator-max-microvolt = <2187500>;
+				regulator-min-microvolt = <650000>;
+				regulator-max-microvolt = <2237500>;

Where does this patch come from ? Linux ? If Linux, then include commit hash of that commit from Linux kernel in the commit message. If not from Linux, why is there no matching fix in Linux ?

author
#9 lore raw

RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 15 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:05
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 4 lines

On 6/5/23 11:48, Joy Zou wrote:

ARM: dts: imx93: ...
(not DTS:)

Okay, thanks!
Will change it in patch v2.

Quoted 18 lines
Quoted 18 lines

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
  arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
  1 file changed, 2 insertions(+), 18 deletions(-)
arch/arm/dts/imx93-11x11-evk.dts +0 -0
index b3a5a3d71e..ceab56a5d8 100644
@@ -141,8 +141,8 @@
              regulators {
                      buck1: BUCK1 {
                              regulator-name = "BUCK1";
Quoted 8 lines

arch/arm/dts/imx93-11x11-evk.dts line 145

Quoted 4 lines
arch/arm/dts/imx93-11x11-evk.dts +2 -2
-                             regulator-min-microvolt = <600000>;
-                             regulator-max-microvolt = <2187500>;
+                             regulator-min-microvolt = <650000>;
+                             regulator-max-microvolt = <2237500>;

Where does this patch come from ? Linux ? If Linux, then include commit hash of that commit from Linux kernel in the commit message. If not from Linux, why is there no matching fix in Linux ?

This patch com from linux. I will add commit hash form Linux kernel. Thanks!
BR
Joy zou

author
#10 lore raw

RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 60 lines

-----Original Message-----
From: Joy Zou
Sent: 2023年6月5日 18:24
To: Marek Vasut <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 16 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:05
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 4 lines

On 6/5/23 11:48, Joy Zou wrote:

ARM: dts: imx93: ...
(not DTS:)

Okay, thanks!
Will change it in patch v2.

Quoted 18 lines
Quoted 18 lines

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
  arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
  1 file changed, 2 insertions(+), 18 deletions(-)
arch/arm/dts/imx93-11x11-evk.dts +0 -0
index b3a5a3d71e..ceab56a5d8 100644
@@ -141,8 +141,8 @@
              regulators {
                      buck1: BUCK1 {
                              regulator-name = "BUCK1";
Quoted 8 lines

arch/arm/dts/imx93-11x11-evk.dts line 145

Quoted 4 lines
arch/arm/dts/imx93-11x11-evk.dts +2 -2
-                             regulator-min-microvolt = <600000>;
-                             regulator-max-microvolt = <2187500>;
+                             regulator-min-microvolt = <650000>;
+                             regulator-max-microvolt = <2237500>;

Where does this patch come from ? Linux ? If Linux, then include commit hash of that commit from Linux kernel in the commit message. If not from Linux, why is there no matching fix in Linux ?

Quoted 2 lines

This patch com from linux. I will add commit hash form Linux kernel. Thanks!

I am sorry! Please ignore the previous reply. This patch only come from my local linux kernel. The linux kernel patch also is reviewing.
So I need add commit hash after the linux kernel patch accepted?
Thanks !
BR
Joy Zou

Quoted 2 lines

BR
Joy zou

#11 lore raw

Re: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 60 lines · Joy Zou
Quoted 60 lines

-----Original Message-----
From: Joy Zou
Sent: 2023年6月5日 18:24
To: Marek Vasut <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 16 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:05
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 4 lines

On 6/5/23 11:48, Joy Zou wrote:

ARM: dts: imx93: ...
(not DTS:)

Okay, thanks!
Will change it in patch v2.

Quoted 26 lines
Quoted 15 lines

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
   arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
   1 file changed, 2 insertions(+), 18 deletions(-)
arch/arm/dts/imx93-11x11-evk.dts +0 -0
index b3a5a3d71e..ceab56a5d8 100644

arch/arm/dts/imx93-11x11-evk.dts line 145

Quoted 7 lines
arch/arm/dts/imx93-11x11-evk.dts +2 -2
@@ -141,8 +141,8 @@
               regulators {
                       buck1: BUCK1 {
                               regulator-name = "BUCK1";
-                             regulator-min-microvolt = <600000>;
-                             regulator-max-microvolt = <2187500>;
+                             regulator-min-microvolt = <650000>;
+                             regulator-max-microvolt = <2237500>;

Where does this patch come from ? Linux ? If Linux, then include commit hash of that commit from Linux kernel in the commit message. If not from Linux, why is there no matching fix in Linux ?

Quoted 5 lines
Quoted 2 lines

This patch com from linux. I will add commit hash form Linux kernel. Thanks!

I am sorry! Please ignore the previous reply. This patch only come from my local linux kernel. The linux kernel patch also is reviewing.
So I need add commit hash after the linux kernel patch accepted?

Link to lore.kernel.org would be fine too.

author
#12 lore raw

RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 79 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月6日 17:28
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: Re: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 44 lines · Joy Zou
Quoted 44 lines

-----Original Message-----
From: Joy Zou
Sent: 2023年6月5日 18:24
To: Marek Vasut <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: RE: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Quoted 16 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:05
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 3/4] DTS: imx93: modify the BUCK1 voltage range

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 4 lines

On 6/5/23 11:48, Joy Zou wrote:

ARM: dts: imx93: ...
(not DTS:)

Okay, thanks!
Will change it in patch v2.

Quoted 9 lines
Quoted 9 lines

The new pmic trimed BUCK1. So need to modify the range. There is no LDO2 and LDO3, So need to delete the property.

---
   arch/arm/dts/imx93-11x11-evk.dts | 20 ++------------------
   1 file changed, 2 insertions(+), 18 deletions(-)
Quoted 13 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
arch/arm/dts/imx93-11x11-evk.dts +0 -0
index b3a5a3d71e..ceab56a5d8 100644
Quoted 8 lines
Quoted 8 lines

arch/arm/dts/imx93-11x11-evk.dts line 145

Quoted 8 lines
arch/arm/dts/imx93-11x11-evk.dts +2 -2
@@ -141,8 +141,8 @@
               regulators {
                       buck1: BUCK1 {
                               regulator-name = "BUCK1";
-                             regulator-min-microvolt = <600000>;
-                             regulator-max-microvolt = <2187500>;
+                             regulator-min-microvolt = <650000>;
+                             regulator-max-microvolt =

<2237500>;

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Where does this patch come from ? Linux ? If Linux, then include commit hash of that commit from Linux kernel in the commit message. If not from Linux, why is there no matching fix in Linux ?

Quoted 8 lines
Quoted 3 lines
Quoted 2 lines

This patch com from linux. I will add commit hash form Linux kernel. Thanks!

I am sorry! Please ignore the previous reply. This patch only come from my

local linux kernel.

Quoted 2 lines

The linux kernel patch also is reviewing.
So I need add commit hash after the linux kernel patch accepted?

Link to lore.kernel.org would be fine too.

Okay,Thanks!
BR
Joy Zou

author
#13 lore raw

PATCH 4/4 configs: enable pmic regulator pca9450

In reply to Joy Zou

support pmci regulator pca9450.

---
 configs/imx93_11x11_evk_defconfig | 2 ++
 1 file changed, 2 insertions(+)
configs/imx93_11x11_evk_defconfig +2 -0
index 4f8777161e..985b4d8638 100644
@@ -103,6 +103,8 @@ CONFIG_SPL_PINCTRL=y
 CONFIG_PINCTRL_IMX93=y
 CONFIG_DM_PMIC=y
 CONFIG_SPL_DM_PMIC_PCA9450=y
+CONFIG_DM_PMIC_PCA9450=y
+CONFIG_DM_REGULATOR_PCA9450=y
 CONFIG_DM_REGULATOR=y
 CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
Signature · 1 line
2.37.1
#14 lore raw

Re: [PATCH v1 4/4] configs: enable pmic regulator pca9450

Quoted 1 line · Joy Zou

support pmci regulator pca9450.

Subject should be something like

ARM: imx: Enable PCA9450 on i.MX93 11x11 EVK

Otherwise the subject is horribly generic and confusing.

author
#15 lore raw

RE: [EXT] Re: [PATCH v1 4/4] configs: enable pmic regulator pca9450

Quoted 15 lines

-----Original Message-----
From: Marek Vasut <[email protected]>
Sent: 2023年6月5日 18:04
To: Joy Zou <[email protected]>; [email protected]; Peng Fan <[email protected]>; Ye Li <[email protected]>; Jacky Bai <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: [email protected]; dl-uboot-imx <[email protected]>
Subject: [EXT] Re: [PATCH v1 4/4] configs: enable pmic regulator pca9450

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 8 lines
Quoted 1 line · Joy Zou

support pmci regulator pca9450.

Subject should be something like

ARM: imx: Enable PCA9450 on i.MX93 11x11 EVK

Otherwise the subject is horribly generic and confusing.

Okay, Thanks!
Will change it in patch v2.
BR
Joy zou