Skip to contentSkip to conversation

gpio: delay: add OF_GPIO dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Jun 5, 2023 GPIO

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 gpio: delay: add OF_GPIO dependency

From: Arnd Bergmann <[email protected]>

The new driver fails to build when OF_GPIO is disabled:

drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'

Fixes cf5dec80c4e23 ("gpio: Add gpio delay driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/Kconfig +1 -0
index a1dac1345f60f..006abaedcae82 100644
@@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
 
 config GPIO_DELAY
 	tristate "GPIO delay"
+	depends on OF_GPIO
 	help
 	  Say yes here to enable the GPIO delay, which provides a way to
 	  configure platform specific delays for GPIO ramp-up or ramp-down
Signature · 1 line
2.39.2
#1 lore raw
Quoted 27 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The new driver fails to build when OF_GPIO is disabled:

drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'

Fixes cf5dec80c4e23 ("gpio: Add gpio delay driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/Kconfig +1 -1
index a1dac1345f60f..006abaedcae82 100644
@@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
 
 config GPIO_DELAY
        tristate "GPIO delay"
+       depends on OF_GPIO
        help
          Say yes here to enable the GPIO delay, which provides a way to
          configure platform specific delays for GPIO ramp-up or ramp-down
--
Quoted 2 lines

2.39.2

Thanks, Alexander beat you to it.

Bart