Skip to contentSkip to conversation

crypto: qat - fix adf_dbgfs_exit() typo

PATCH In review Arnd Bergmann 2 participants 2 messages Jun 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: qat - fix adf_dbgfs_exit() typo

From: Arnd Bergmann <[email protected]>

The stub function uses a different name from the normal one:

drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]

Rename the function to match the normal one.

Fixes 9260db6640a61 ("crypto: qat - move dbgfs init to separate file")
---
 drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/intel/qat/qat_common/adf_dbgfs.h +1 -1
index 1d64ad1a00374..e0cb2c2a2ed0b 100644
@@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)
 {
 }
 
-static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev)
+static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
 {
 }
 #endif
Signature · 1 line
2.39.2
#1 lore raw

Thanks Arnd.
I already sent the same fix a few days ago: https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

Signature · 1 line
Giovanni

-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: Monday, June 5, 2023 3:45 PM
To: Cabiddu, Giovanni <[email protected]>; Herbert Xu <[email protected]>; David S. Miller <[email protected]>; Muszynski, Damian <[email protected]>
Cc: Arnd Bergmann <[email protected]>; qat-linux <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] crypto: qat - fix adf_dbgfs_exit() typo

From: Arnd Bergmann <[email protected]>

The stub function uses a different name from the normal one:

drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration] drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]

Rename the function to match the normal one.

Fixes 9260db6640a61 ("crypto: qat - move dbgfs init to separate file")
---
 drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/intel/qat/qat_common/adf_dbgfs.h +1 -2
index 1d64ad1a00374..e0cb2c2a2ed0b 100644
@@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)  {  }
 
-static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev)
+static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
 {
 }
 #endif
--

2.39.2