Skip to contentSkip to conversation

tests/xe_create: Add multiple engines create/destroy subtest

PATCH In review Zbigniew Kempczyński 4 participants 10 messages Jun 6, 2023 – Jun 8, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/xe_create: Add multiple engines create/destroy subtest

Exercise basic engine concurrency create/destroy functionality.

---
 tests/xe/xe_create.c | 92 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)
tests/xe/xe_create.c +92 -0
index ae21154646..e139cb8e7f 100644
@@ -88,6 +88,92 @@ static void create_invalid_size(int fd)
 	xe_vm_destroy(fd, vm);
 }
 
+enum engine_destroy {
+	NOLEAK,
+	LEAK
+};
+
+static uint32_t __xe_engine_create(int fd, uint32_t vm,
+				   struct drm_xe_engine_class_instance *instance,
+				   uint64_t ext,
+				   uint32_t *enginep)
+{
+	struct drm_xe_engine_create create = {
+		.extensions = ext,
+		.vm_id = vm,
+		.width = 1,
+		.num_placements = 1,
+		.instances = to_user_pointer(instance),
+	};
+	int err = 0;
+
+	if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
+		*enginep = create.engine_id;
+	} else {
+		igt_warn("Can't create engine, errno: %d\n", errno);
+		err = -errno;
+		igt_assume(err);
+	}
+	errno = 0;
+
+	return err;
+}
+
+#define MAXENGINES 2048
+
+/**
+ * SUBTEST: create-engines-%s
+ * Description: Check process ability of multiple engines creation
+ * Run type: FULL
+ *
+ * arg[1]:
+ *
+ * @noleak:				destroy engines in the code
+ * @leak:				destroy engines in close() path
+ */
+static void create_engines(int fd, enum engine_destroy ed)
+{
+	uint32_t num_engines, engines_per_process, vm;
+	int nproc = sysconf(_SC_NPROCESSORS_ONLN);
+
+	fd = drm_reopen_driver(fd);
+	num_engines = xe_number_hw_engines(fd);
+	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+
+	engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
+	igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
+
+	igt_fork(n, nproc) {
+		struct drm_xe_engine_class_instance *hwe;
+		uint32_t engine, engines[engines_per_process];
+		int idx, err, i;
+
+		for (i = 0; i < engines_per_process; i++) {
+			idx = rand() % num_engines;
+			hwe = xe_hw_engine(fd, idx);
+			err = __xe_engine_create(fd, vm, hwe, 0, &engine);
+			igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
+				  n, err, engine, i);
+			if (err)
+				break;
+
+			if (ed == NOLEAK)
+				engines[i] = engine;
+		}
+
+		if (ed == NOLEAK) {
+			while (--i >= 0) {
+				igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
+				xe_engine_destroy(fd, engines[i]);
+			}
+		}
+	}
+	igt_waitchildren();
+
+	xe_vm_destroy(fd, vm);
+	close(fd);
+}
+
 /**
  * SUBTEST: create-massive-size
  * Description: Verifies xe bo create returns expected error code on massive
@@ -121,6 +207,12 @@ igt_main
 		create_invalid_size(xe);
 	}
 
+	igt_subtest("create-engines-noleak")
+		create_engines(xe, NOLEAK);
+
+	igt_subtest("create-engines-leak")
+		create_engines(xe, LEAK);
+
 	igt_subtest("create-massive-size") {
 		create_massive_size(xe);
 	}
Signature · 1 line
2.34.1
#1 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for tests/xe_create: Add multiple engines create/destroy subtest

== Series Details ==

== Series Details ==

Series: tests/xe_create: Add multiple engines create/destroy subtest
URL : https://patchwork.freedesktop.org/series/118931/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/901225 for the overview.

build-containers:build-debian has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/43196761):
time="2023-06-06T13:23:25Z" level=fatal msg="Error determining repository tags: Invalid status code returned when fetching tags list 400 (Bad Request)"
Building!
STEP 1: FROM debian:buster
Getting image source signatures
Copying blob sha256:c722db24a050621ee87ea07acd5d066d3d6a94737c32012f27d73a1ad5cc645c
Copying config sha256:8b5601a5a7f855241ac7f372ec0042e793b0b3eb3f3a601014845f22bd371c90
Writing manifest to image destination
Storing signatures
STEP 2: RUN apt-get update
error running container: error creating container for [/bin/sh -c apt-get update]: time="2023-06-06T13:23:29Z" level=warning msg="signal: killed"
time="2023-06-06T13:23:29Z" level=error msg="container_linux.go:346: starting container process caused \"process_linux.go:297: applying cgroup configuration for process caused \\\"mountpoint for cgroup not found\\\"\"\n" container_linux.go:346: starting container process caused "process_linux.go:297: applying cgroup configuration for process caused \"mountpoint for cgroup not found\""
: exit status 1
Error: error building at STEP "RUN apt-get update": error while running runtime: exit status 1
section_end:1686057810:step_script
section_start:1686057810:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1686057811:cleanup_file_variables
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/901225

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/xe_create: Add multiple engines create/destroy subtest

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: tests/xe_create: Add multiple engines create/destroy subtest
URL : https://patchwork.freedesktop.org/series/118931/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13236 -> IGTPW_9117
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_9117 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_9117, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (41 -> 40)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_9117:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@basic-s3-without-i915:
- fi-apl-guc: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-apl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_9117 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0@smem:
- fi-skl-6600u: [PASS][3] -> [ABORT][4] ([i915#5122])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][5] -> [INCOMPLETE][6] ([i915#7609] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@guc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][7] ([i915#7852])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][8] ([i915#6367])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][10] ([i915#1845] / [i915#5354]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][13] ([i915#7059]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][15] ([i915#7911] / [i915#7920] / [i915#7982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:
- {bat-adlp-11}: [FAIL][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117

CI-20190529: 20190529
CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

#3 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for tests/xe_create: Add multiple engines create/destroy subtest

Quoted 30 lines · Patchwork
   Patch Details

   Series:  tests/xe_create: Add multiple engines create/destroy subtest   
   URL:     https://patchwork.freedesktop.org/series/118931/               
   State:   failure                                                        
   Details: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html 

              CI Bug Log - changes from CI_DRM_13236 -> IGTPW_9117

Summary

FAILURE

Serious unknown changes coming with IGTPW_9117 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_9117, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL:
   https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (41 -> 40)

   Missing (1): fi-snb-2520m

Possible new issues

Quoted 8 lines

Here are the unknown changes that may have been introduced in IGTPW_9117:

IGT changes

Possible regressions

* igt@i915_suspend@basic-s3-without-i915:
* fi-apl-guc: PASS -> ABORT

Unrelated to this failure. May I ask for resume?

--
Zbigniew

Quoted 64 lines

Known issues

Here are the changes found in IGTPW_9117 that come from known issues:

IGT changes

Issues hit

* igt@gem_exec_suspend@basic-s0@smem:

* fi-skl-6600u: PASS -> ABORT (i915#5122)
* igt@i915_selftest@live@gt_lrc:

* bat-dg2-11: PASS -> INCOMPLETE (i915#7609 / i915#7913)
* igt@i915_selftest@live@guc:

* bat-rpls-1: NOTRUN -> DMESG-WARN (i915#7852)
* igt@i915_selftest@live@slpc:

* bat-rpls-1: NOTRUN -> DMESG-WARN (i915#6367)
* igt@i915_suspend@basic-s3-without-i915:

* bat-rpls-1: NOTRUN -> ABORT (i915#6687 / i915#7978)
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:

* bat-dg2-11: NOTRUN -> SKIP (i915#1845 / i915#5354) +1 similar issue
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:

* bat-dg2-8: PASS -> FAIL (i915#7932)

Possible fixes

* igt@i915_selftest@live@gt_mocs:

* {bat-mtlp-8}: DMESG-FAIL (i915#7059) -> PASS
* igt@i915_selftest@live@requests:

* bat-rpls-1: ABORT (i915#7911 / i915#7920 / i915#7982) -> PASS
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:

* {bat-adlp-11}: FAIL -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117

   CI-20190529: 20190529
   CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @
   git://anongit.freedesktop.org/gfx-ci/linux
   IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
   IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @
   https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes

+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak

#4 lore raw

Re: [igt-dev] ✗ Fi.CI.BAT: failure for tests/xe_create: Add multiple engines create/destroy subtest

Hi,

Issue re-reported, https://patchwork.freedesktop.org/series/118931/#rev1

Thanks,
Y Sai Nandan

-----Original Message-----
From: Kempczynski, Zbigniew <[email protected]>
Sent: Tuesday, June 6, 2023 10:08 PM
To: [email protected]
Cc: Yedireswarapu, SaiX Nandan <[email protected]>
Subject: Re: ✗ Fi.CI.BAT: failure for tests/xe_create: Add multiple engines create/destroy subtest

Quoted 30 lines · Patchwork
   Patch Details

   Series:  tests/xe_create: Add multiple engines create/destroy subtest   
   URL:     https://patchwork.freedesktop.org/series/118931/               
   State:   failure                                                        
   Details: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html 

              CI Bug Log - changes from CI_DRM_13236 -> IGTPW_9117

Summary

FAILURE

Serious unknown changes coming with IGTPW_9117 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_9117, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL:
   https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (41 -> 40)

   Missing (1): fi-snb-2520m

Possible new issues

Quoted 8 lines

Here are the unknown changes that may have been introduced in IGTPW_9117:

IGT changes

Possible regressions

* igt@i915_suspend@basic-s3-without-i915:
* fi-apl-guc: PASS -> ABORT

Unrelated to this failure. May I ask for resume?

--
Zbigniew

Quoted 64 lines

Known issues

Here are the changes found in IGTPW_9117 that come from known issues:

IGT changes

Issues hit

* igt@gem_exec_suspend@basic-s0@smem:

* fi-skl-6600u: PASS -> ABORT (i915#5122)
* igt@i915_selftest@live@gt_lrc:

* bat-dg2-11: PASS -> INCOMPLETE (i915#7609 / i915#7913)
* igt@i915_selftest@live@guc:

* bat-rpls-1: NOTRUN -> DMESG-WARN (i915#7852)
* igt@i915_selftest@live@slpc:

* bat-rpls-1: NOTRUN -> DMESG-WARN (i915#6367)
* igt@i915_suspend@basic-s3-without-i915:

* bat-rpls-1: NOTRUN -> ABORT (i915#6687 / i915#7978)
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:

* bat-dg2-11: NOTRUN -> SKIP (i915#1845 / i915#5354) +1 similar issue
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:

* bat-dg2-8: PASS -> FAIL (i915#7932)

Possible fixes

* igt@i915_selftest@live@gt_mocs:

* {bat-mtlp-8}: DMESG-FAIL (i915#7059) -> PASS
* igt@i915_selftest@live@requests:

* bat-rpls-1: ABORT (i915#7911 / i915#7920 / i915#7982) -> PASS
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:

* {bat-adlp-11}: FAIL -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117

   CI-20190529: 20190529
   CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @
   git://anongit.freedesktop.org/gfx-ci/linux
   IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
   IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @
   https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes

+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak

#5 lore raw
In reply to Zbigniew Kempczyński

Hi Zbigniew,

Quoted 68 lines · Zbigniew Kempczyński

Exercise basic engine concurrency create/destroy functionality.

---
 tests/xe/xe_create.c | 92 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)
tests/xe/xe_create.c +52 -0
index ae21154646..e139cb8e7f 100644
@@ -88,6 +88,92 @@ static void create_invalid_size(int fd)
 	xe_vm_destroy(fd, vm);
 }
 
+enum engine_destroy {
+	NOLEAK,
+	LEAK
+};
+
+static uint32_t __xe_engine_create(int fd, uint32_t vm,
+				   struct drm_xe_engine_class_instance *instance,
+				   uint64_t ext,
+				   uint32_t *enginep)
+{
+	struct drm_xe_engine_create create = {
+		.extensions = ext,
+		.vm_id = vm,
+		.width = 1,
+		.num_placements = 1,
+		.instances = to_user_pointer(instance),
+	};
+	int err = 0;
+
+	if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
+		*enginep = create.engine_id;
+	} else {
+		igt_warn("Can't create engine, errno: %d\n", errno);
+		err = -errno;
+		igt_assume(err);
+	}
+	errno = 0;
+
+	return err;
+}
+
+#define MAXENGINES 2048
+
+/**
+ * SUBTEST: create-engines-%s
+ * Description: Check process ability of multiple engines creation
+ * Run type: FULL
+ *
+ * arg[1]:
+ *
+ * @noleak:				destroy engines in the code
+ * @leak:				destroy engines in close() path
+ */
+static void create_engines(int fd, enum engine_destroy ed)
+{
+	uint32_t num_engines, engines_per_process, vm;
+	int nproc = sysconf(_SC_NPROCESSORS_ONLN);
+
+	fd = drm_reopen_driver(fd);
+	num_engines = xe_number_hw_engines(fd);
+	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+

tests/xe/xe_create.c static void create_invalid_size(int fd) · line 152

Quoted 10 lines
tests/xe/xe_create.c +10 -0
+	engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
+	igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
+
+	igt_fork(n, nproc) {
+		struct drm_xe_engine_class_instance *hwe;
+		uint32_t engine, engines[engines_per_process];
+		int idx, err, i;
+
+		for (i = 0; i < engines_per_process; i++) {
+			idx = rand() % num_engines;

----------------------- ^
In each subprocess you will get the same numbers, is it your intention ? You can use igt_srandom() before fork like:

	igt_srandom();
	r = rand();
	igt_fork(n, nproc) {
		...
		srandom(r + n);
		for (...) {
			idx = rand() % num_engines;
			...
		}

Regards,
Kamil

Quoted 43 lines
tests/xe/xe_create.c +30 -0
+			hwe = xe_hw_engine(fd, idx);
+			err = __xe_engine_create(fd, vm, hwe, 0, &engine);
+			igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
+				  n, err, engine, i);
+			if (err)
+				break;
+
+			if (ed == NOLEAK)
+				engines[i] = engine;
+		}
+
+		if (ed == NOLEAK) {
+			while (--i >= 0) {
+				igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
+				xe_engine_destroy(fd, engines[i]);
+			}
+		}
+	}
+	igt_waitchildren();
+
+	xe_vm_destroy(fd, vm);
+	close(fd);
+}
+
 /**
  * SUBTEST: create-massive-size
  * Description: Verifies xe bo create returns expected error code on massive
@@ -121,6 +207,12 @@ igt_main
 		create_invalid_size(xe);
 	}
 
+	igt_subtest("create-engines-noleak")
+		create_engines(xe, NOLEAK);
+
+	igt_subtest("create-engines-leak")
+		create_engines(xe, LEAK);
+
 	igt_subtest("create-massive-size") {
 		create_massive_size(xe);
 	}
Signature · 1 line
2.34.1
#6 lore raw
Quoted 76 lines · Kamil Konieczny

Hi Zbigniew,

Quoted 73 lines · Zbigniew Kempczyński

Exercise basic engine concurrency create/destroy functionality.

---
 tests/xe/xe_create.c | 92 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)
tests/xe/xe_create.c +57 -0
index ae21154646..e139cb8e7f 100644
@@ -88,6 +88,92 @@ static void create_invalid_size(int fd)
 	xe_vm_destroy(fd, vm);
 }
 
+enum engine_destroy {
+	NOLEAK,
+	LEAK
+};
+
+static uint32_t __xe_engine_create(int fd, uint32_t vm,
+				   struct drm_xe_engine_class_instance *instance,
+				   uint64_t ext,
+				   uint32_t *enginep)
+{
+	struct drm_xe_engine_create create = {
+		.extensions = ext,
+		.vm_id = vm,
+		.width = 1,
+		.num_placements = 1,
+		.instances = to_user_pointer(instance),
+	};
+	int err = 0;
+
+	if (igt_ioctl(fd, DRM_IOCTL_XE_ENGINE_CREATE, &create) == 0) {
+		*enginep = create.engine_id;
+	} else {
+		igt_warn("Can't create engine, errno: %d\n", errno);
+		err = -errno;
+		igt_assume(err);
+	}
+	errno = 0;
+
+	return err;
+}
+
+#define MAXENGINES 2048
+
+/**
+ * SUBTEST: create-engines-%s
+ * Description: Check process ability of multiple engines creation
+ * Run type: FULL
+ *
+ * arg[1]:
+ *
+ * @noleak:				destroy engines in the code
+ * @leak:				destroy engines in close() path
+ */
+static void create_engines(int fd, enum engine_destroy ed)
+{
+	uint32_t num_engines, engines_per_process, vm;
+	int nproc = sysconf(_SC_NPROCESSORS_ONLN);
+
+	fd = drm_reopen_driver(fd);
+	num_engines = xe_number_hw_engines(fd);
+	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
+
+	engines_per_process = max_t(uint32_t, 1, MAXENGINES / nproc);
+	igt_debug("nproc: %u, engines per process: %u\n", nproc, engines_per_process);
+
+	igt_fork(n, nproc) {
+		struct drm_xe_engine_class_instance *hwe;
Quoted 8 lines

tests/xe/xe_create.c static void create_invalid_size(int fd) · line 152

Quoted 5 lines
tests/xe/xe_create.c +5 -0
+		uint32_t engine, engines[engines_per_process];
+		int idx, err, i;
+
+		for (i = 0; i < engines_per_process; i++) {
+			idx = rand() % num_engines;

----------------------- ^
In each subprocess you will get the same numbers, is it your intention ? You can use igt_srandom() before fork like:

No, I just forgot I got same seed in the children. Anyway some randomness is achieved by process creation time and schedule. I'll respin with setting different seeds according to your suggestion.

Thank you for the review:
--
Zbigniew

Quoted 57 lines
	igt_srandom();
	r = rand();
	igt_fork(n, nproc) {
		...
		srandom(r + n);
		for (...) {
			idx = rand() % num_engines;
			...
		}

Regards,
Kamil

Quoted 43 lines
tests/xe/xe_create.c +30 -0
+			hwe = xe_hw_engine(fd, idx);
+			err = __xe_engine_create(fd, vm, hwe, 0, &engine);
+			igt_debug("[%2d] Create engine: err=%d, engine=%u [idx = %d]\n",
+				  n, err, engine, i);
+			if (err)
+				break;
+
+			if (ed == NOLEAK)
+				engines[i] = engine;
+		}
+
+		if (ed == NOLEAK) {
+			while (--i >= 0) {
+				igt_debug("[%2d] Destroy engine: %u\n", n, engines[i]);
+				xe_engine_destroy(fd, engines[i]);
+			}
+		}
+	}
+	igt_waitchildren();
+
+	xe_vm_destroy(fd, vm);
+	close(fd);
+}
+
 /**
  * SUBTEST: create-massive-size
  * Description: Verifies xe bo create returns expected error code on massive
@@ -121,6 +207,12 @@ igt_main
 		create_invalid_size(xe);
 	}
 
+	igt_subtest("create-engines-noleak")
+		create_engines(xe, NOLEAK);
+
+	igt_subtest("create-engines-leak")
+		create_engines(xe, LEAK);
+
 	igt_subtest("create-massive-size") {
 		create_massive_size(xe);
 	}
Signature · 1 line
2.34.1
#7 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/xe_create: Add multiple engines create/destroy subtest

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: tests/xe_create: Add multiple engines create/destroy subtest
URL : https://patchwork.freedesktop.org/series/118931/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13236 -> IGTPW_9117
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_9117 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_9117, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (41 -> 40)
------------------------------

Missing (1): fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_9117:

### IGT changes ###

#### Possible regressions ####

* igt@i915_suspend@basic-s3-without-i915:
- fi-apl-guc: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-apl-guc/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-apl-guc/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_9117 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0@smem:
- fi-skl-6600u: [PASS][3] -> [ABORT][4] ([i915#5122])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][5] -> [INCOMPLETE][6] ([i915#7609] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@guc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][7] ([i915#7852])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][8] ([i915#6367])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][10] ([i915#1845] / [i915#5354]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][13] ([i915#7059]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][15] ([i915#7911] / [i915#7920] / [i915#7982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:
- {bat-adlp-11}: [FAIL][17] ([i915#7336]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7336]: https://gitlab.freedesktop.org/drm/intel/issues/7336
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117

CI-20190529: 20190529
CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

#8 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/xe_create: Add multiple engines create/destroy subtest

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: tests/xe_create: Add multiple engines create/destroy subtest
URL : https://patchwork.freedesktop.org/series/118931/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13236 -> IGTPW_9117
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (41 -> 40)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in IGTPW_9117 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0@smem:
- fi-skl-6600u: [PASS][1] -> [ABORT][2] ([i915#5122])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][3] -> [INCOMPLETE][4] ([i915#7609] / [i915#7913])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@guc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][5] ([i915#7852])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][6] ([i915#6367])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-apl-guc: [PASS][7] -> [ABORT][8] ([i915#8585])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/fi-apl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/fi-apl-guc/igt@[email protected]
- bat-rpls-1: NOTRUN -> [ABORT][9] ([i915#6687] / [i915#7978])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][10] ([i915#1845] / [i915#5354]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][11] -> [FAIL][12] ([i915#7932])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][13] ([i915#7059]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][15] ([i915#7911] / [i915#7920] / [i915#7982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-rpls-1/igt@i915_selftest@[email protected]

* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-5}:
- {bat-adlp-11}: [FAIL][17] ([i915#7336]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/bat-adlp-11/igt@kms_pipe_crc_basic@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7336]: https://gitlab.freedesktop.org/drm/intel/issues/7336
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8585]: https://gitlab.freedesktop.org/drm/intel/issues/8585

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117

CI-20190529: 20190529
CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@xe_create@create-engines-leak
+igt@xe_create@create-engines-noleak

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

#9 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/xe_create: Add multiple engines create/destroy subtest

In reply to Zbigniew Kempczyński
== Series Details ==

== Series Details ==

Series: tests/xe_create: Add multiple engines create/destroy subtest
URL : https://patchwork.freedesktop.org/series/118931/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13236_full -> IGTPW_9117_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in IGTPW_9117_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@engines-hang:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb6/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk5/igt@gem_exec_fair@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][4] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk5/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl6/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][7] -> [ABORT][8] ([i915#5566])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk6/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#3886]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#3886])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl4/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_rc_ccs:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271]) +55 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb4/igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_rc_ccs.html

* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271]) +38 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl4/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_cursor_crc@cursor-offscreen-max-size:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-32x10:
- shard-glk: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4579]) +6 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk6/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-modifiers-20x20@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4579]) +14 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271]) +42 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk6/igt@kms_plane_scaling@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl3/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-glk: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#658]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk4/igt@[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][21] ([i915#7742]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-rkl-3/igt@drm_fdinfo@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-rkl-4/igt@drm_fdinfo@[email protected]

* igt@gem_barrier_race@remote-request@rcs0:
- {shard-dg1}: [DMESG-WARN][23] ([i915#8224]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-dg1-12/igt@gem_barrier_race@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-dg1-13/igt@gem_barrier_race@[email protected]

* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][25] ([i915#6786]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-dg1-14/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-dg1-17/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [ABORT][27] ([i915#180]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-apl6/igt@gem_ctx_isolation@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl1/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][29] ([i915#5784]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-dg1-13/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-dg1-17/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][31] ([i915#2846]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-rkl-4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-rkl-7/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][33] ([i915#2842]) -> [PASS][34] +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk9/igt@gem_exec_fair@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl}: [FAIL][35] ([i915#2842]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-rkl-1/igt@gem_exec_fair@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-rkl-6/igt@gem_exec_fair@[email protected]

* igt@i915_module_load@reload:
- shard-snb: [ABORT][37] ([i915#4528]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-snb2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][39] ([fdo#109271]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-apl2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl1/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][41] ([i915#1937] / [i915#4579]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-dg1-18/igt@i915_pm_lpsp@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-dg1-19/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- {shard-rkl}: [SKIP][43] ([i915#1397]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-rkl-7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-rkl-6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][45] ([i915#2346]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk9/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk9/igt@[email protected]
- shard-apl: [FAIL][47] ([i915#2346]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-apl7/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-apl3/igt@[email protected]

* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][49] ([i915#8011] / [i915#8347]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-dg1-19/igt@kms_cursor_legacy@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-dg1-12/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@single-move@pipe-a:
- shard-snb: [INCOMPLETE][51] ([i915#7941]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-snb1/igt@kms_cursor_legacy@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb1/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][53] ([i915#79]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-glk6/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-glk2/igt@kms_flip@[email protected]

#### Warnings ####

* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][55] ([i915#7790]) -> [DMESG-FAIL][56] ([i915#8319])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13236/shard-snb5/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/shard-snb5/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8224]: https://gitlab.freedesktop.org/drm/intel/issues/8224
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7320 -> IGTPW_9117
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_13236: 6ef9ba991d96572648aa75eb7818d8c111f2eb4f @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html
IGT_7320: 1c96b08a4cde6f2d49824a8cc3303bd860617b52 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9117/index.html