Skip to contentSkip to conversation

arago-image.inc: fix the default systemd target

PATCH Superseded [email protected] 2 participants 3 messages Jun 6, 2023

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arago-image.inc: fix the default systemd target

From: Randolph Sapp <[email protected]>

SYSTEMD_DEFAULT_TARGET is dynamically set based on the contents of IMAGE_FEATURES. Would you like to know what doesn't get updated when we use a bunch of package groups to dictate what is present in the image?

This makes systemd actually start graphical applications if the opengl distro feature is set. It assumes the distro is using weston though. I'm sure that will eventually be invalid when the package group contents drift.

---
 meta-arago-distro/recipes-core/images/arago-image.inc | 5 +++++
 1 file changed, 5 insertions(+)
meta-arago-distro/recipes-core/images/arago-image.inc +5 -0
index d00c1f70..7104d87c 100644
@@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc"
 
 IMAGE_FEATURES += "package-management splash"
 
+# this is required to make sure the proper systemd default target gets set
+IMAGE_FEATURES += " \
+	${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \
+"
+
 # 4KB per 1 inode should be enough
 EXTRA_IMAGECMD:ext2.gz += "-i 4096"
 
Signature · 1 line
2.40.1
#1 lore raw
Quoted 8 lines · Randolph Sapp via lists.yoctoproject.org

From: Randolph Sapp <[email protected]>

SYSTEMD_DEFAULT_TARGET is dynamically set based on the contents of IMAGE_FEATURES. Would you like to know what doesn't get updated when we use a bunch of package groups to dictate what is present in the image?

This makes systemd actually start graphical applications if the opengl distro feature is set. It assumes the distro is using weston though. I'm

Why check for "opengl" and not "wayland" in DISTRO_FEATURES?

Quoted 26 lines

sure that will eventually be invalid when the package group contents drift.

---
 meta-arago-distro/recipes-core/images/arago-image.inc | 5 +++++
 1 file changed, 5 insertions(+)
meta-arago-distro/recipes-core/images/arago-image.inc +5 -0
index d00c1f70..7104d87c 100644
@@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc"
 
 IMAGE_FEATURES += "package-management splash"
 
+# this is required to make sure the proper systemd default target gets set
+IMAGE_FEATURES += " \
+	${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \
+"
+
 # 4KB per 1 inode should be enough
 EXTRA_IMAGECMD:ext2.gz += "-i 4096"
 
Signature · 1 line
2.40.1
#2 lore raw
Quoted 12 lines · Denys Dmytriyenko
Quoted 8 lines · Randolph Sapp via lists.yoctoproject.org

From: Randolph Sapp <[email protected]>

SYSTEMD_DEFAULT_TARGET is dynamically set based on the contents of IMAGE_FEATURES. Would you like to know what doesn't get updated when we use a bunch of package groups to dictate what is present in the image?

This makes systemd actually start graphical applications if the opengl distro feature is set. It assumes the distro is using weston though. I'm

Why check for "opengl" and not "wayland" in DISTRO_FEATURES?

Fair enough. Forgot that was a distro feature.
V2 inbound

Quoted 27 lines
Quoted 27 lines

sure that will eventually be invalid when the package group contents drift.

---
  meta-arago-distro/recipes-core/images/arago-image.inc | 5 +++++
  1 file changed, 5 insertions(+)
meta-arago-distro/recipes-core/images/arago-image.inc +5 -0
index d00c1f70..7104d87c 100644
@@ -6,6 +6,11 @@ COMPATIBLE_MACHINE = "ti-soc"
 
  IMAGE_FEATURES += "package-management splash"
 
+# this is required to make sure the proper systemd default target gets set
+IMAGE_FEATURES += " \
+	${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'weston', '',d)} \
+"
+
  # 4KB per 1 inode should be enough
  EXTRA_IMAGECMD:ext2.gz += "-i 4096"
 
Signature · 1 line
2.40.1