tools: ynl-gen: code gen improvements before ethtool
Subsystems (3)
Jakub Kicinski
maintainercover tools: ynl-gen: code gen improvements before ethtool
I was going to post ethtool but I couldn't stand the ugliness of the if conditions which were previously generated. So I cleaned that up and improved a number of other things ethtool will benefit from.
Jakub Kicinski (12):
tools: ynl-gen: cleanup user space header includes
tools: ynl: regen: cleanup user space header includes
tools: ynl-gen: complete the C keyword list
tools: ynl-gen: combine else with closing bracket
tools: ynl-gen: get attr type outside of if()
tools: ynl: regen: regenerate the if ladders
tools: ynl-gen: stop generating common notification handlers
tools: ynl: regen: stop generating common notification handlers
tools: ynl-gen: sanitize notification tracking
tools: ynl-gen: support code gen for events
tools: ynl-gen: don't pass op_name to RenderInfo
tools: ynl-gen: support / skip pads on the way to kernel
tools/net/ynl/generated/devlink-user.c | 78 +++---- tools/net/ynl/generated/fou-user.c | 35 ++-- tools/net/ynl/generated/handshake-user.c | 78 ++----- tools/net/ynl/generated/handshake-user.h | 3 - tools/net/ynl/generated/netdev-user.c | 58 +----- tools/net/ynl/generated/netdev-user.h | 3 - tools/net/ynl/lib/nlspec.py | 7 +- tools/net/ynl/ynl-gen-c.py | 253 ++++++++++------------- 8 files changed, 186 insertions(+), 329 deletions(-)
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 1/12 tools: ynl-gen: cleanup user space header includes
Bots started screaming that we're including stdlib.h twice. While at it move string.h into a common spot and drop stdio.h which we don't need.
--- tools/net/ynl/ynl-gen-c.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
tools/net/ynl/ynl-gen-c.py +1 -4
@@ -2323,8 +2323,8 @@ _C_KW = { headers = ['uapi/' + parsed.uapi_header] else: cw.p('#include <stdlib.h>') + cw.p('#include <string.h>') if args.header: - cw.p('#include <string.h>') cw.p('#include <linux/types.h>') else: cw.p(f'#include "{parsed.name}-user.h"')
@@ -2339,9 +2339,6 @@ _C_KW = { if args.mode == "user": if not args.header: - cw.p("#include <stdlib.h>") - cw.p("#include <stdio.h>") - cw.p("#include <string.h>") cw.p("#include <libmnl/libmnl.h>") cw.p("#include <linux/genetlink.h>") cw.nl()
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 2/12 tools: ynl: regen: cleanup user space header includes
In reply to Jakub KicinskiRemove unnecessary includes.
--- tools/net/ynl/generated/devlink-user.c | 4 +--- tools/net/ynl/generated/fou-user.c | 4 +--- tools/net/ynl/generated/handshake-user.c | 4 +--- tools/net/ynl/generated/netdev-user.c | 4 +--- 4 files changed, 4 insertions(+), 12 deletions(-)
tools/net/ynl/generated/devlink-user.c +1 -3
@@ -4,13 +4,11 @@/* YNL-GEN user source */ #include <stdlib.h> +#include <string.h> #include "devlink-user.h" #include "ynl.h" #include <linux/devlink.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> #include <libmnl/libmnl.h> #include <linux/genetlink.h>
tools/net/ynl/generated/fou-user.c +1 -3
@@ -4,13 +4,11 @@/* YNL-GEN user source */ #include <stdlib.h> +#include <string.h> #include "fou-user.h" #include "ynl.h" #include <linux/fou.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> #include <libmnl/libmnl.h> #include <linux/genetlink.h>
tools/net/ynl/generated/handshake-user.c +1 -3
@@ -4,13 +4,11 @@/* YNL-GEN user source */ #include <stdlib.h> +#include <string.h> #include "handshake-user.h" #include "ynl.h" #include <linux/handshake.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> #include <libmnl/libmnl.h> #include <linux/genetlink.h>
tools/net/ynl/generated/netdev-user.c +1 -3
@@ -4,13 +4,11 @@/* YNL-GEN user source */ #include <stdlib.h> +#include <string.h> #include "netdev-user.h" #include "ynl.h" #include <linux/netdev.h> -#include <stdlib.h> -#include <stdio.h> -#include <string.h> #include <libmnl/libmnl.h> #include <linux/genetlink.h>
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 3/12 tools: ynl-gen: complete the C keyword list
In reply to Jakub KicinskiC keywords need to be avoided when naming things. Complete the list (ethtool has at least one thing called "auto").
--- tools/net/ynl/ynl-gen-c.py | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
tools/net/ynl/ynl-gen-c.py +34 -1
@@ -1172,7 +1172,40 @@ op_mode_to_wrapper = { } _C_KW = { - 'do' + 'auto', + 'bool', + 'break', + 'case', + 'char', + 'const', + 'continue', + 'default', + 'do', + 'double', + 'else', + 'enum', + 'extern', + 'float', + 'for', + 'goto', + 'if', + 'inline', + 'int', + 'long', + 'register', + 'return', + 'short', + 'signed', + 'sizeof', + 'static', + 'struct', + 'switch', + 'typedef', + 'union', + 'unsigned', + 'void', + 'volatile', + 'while' }
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 4/12 tools: ynl-gen: combine else with closing bracket
In reply to Jakub KicinskiCode gen currently prints:
} else if (...
This is really ugly. Fix it by delaying printing of closing brackets in anticipation of else coming along.
--- tools/net/ynl/ynl-gen-c.py | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-)
tools/net/ynl/ynl-gen-c.py +19 -4
@@ -1017,6 +1017,7 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S self.nlib = nlib self._nl = False + self._block_end = False self._silent_block = False self._ind = 0 self._out = out_file
@@ -1025,11 +1026,18 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S def _is_cond(cls, line): return line.startswith('if') or line.startswith('while') or line.startswith('for') - def p(self, line, add_ind=0, eat_nl=False): + def p(self, line, add_ind=0): + if self._block_end: + self._block_end = False + if line.startswith('else'): + line = '} ' + line + else: + self._out.write('\t' * self._ind + '}\n') + if self._nl: - if not eat_nl: - self._out.write('\n') + self._out.write('\n') self._nl = False + ind = self._ind if line[-1] == ':': ind -= 1
@@ -1053,7 +1061,14 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S if line and line[0] not in {';', ','}: line = ' ' + line self._ind -= 1 - self.p('}' + line, eat_nl=True) + self._nl = False + if not line: + # Delay printing closing bracket in case "else" comes next + if self._block_end: + self._out.write('\t' * (self._ind + 1) + '}\n') + self._block_end = True + else: + self.p('}' + line) def write_doc_line(self, doc, indent=True): words = doc.split()
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 5/12 tools: ynl-gen: get attr type outside of if()
In reply to Jakub KicinskiReading attr type with mnl_attr_get_type() for each condition leads to most conditions being longer than 80 chars. Avoid this by reading the type to a variable on the stack.
--- tools/net/ynl/ynl-gen-c.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/net/ynl/ynl-gen-c.py +3 -1
@@ -153,7 +153,7 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S init_lines = [init_lines] kw = 'if' if first else 'else if' - ri.cw.block_start(line=f"{kw} (mnl_attr_get_type(attr) == {self.enum_name})") + ri.cw.block_start(line=f"{kw} (type == {self.enum_name})") if local_vars: for local in local_vars: ri.cw.p(local)
@@ -1418,6 +1418,8 @@ _C_KW = { ri.cw.nl() ri.cw.block_start(line=iter_line) + ri.cw.p('unsigned int type = mnl_attr_get_type(attr);') + ri.cw.nl() first = True for _, arg in struct.member_list():
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 6/12 tools: ynl: regen: regenerate the if ladders
In reply to Jakub KicinskiRenegate the code to combine } and else and use tmp variable to store type.
--- tools/net/ynl/generated/devlink-user.c | 74 ++++++++++++------------ tools/net/ynl/generated/fou-user.c | 31 ++++------ tools/net/ynl/generated/handshake-user.c | 29 +++++----- tools/net/ynl/generated/netdev-user.c | 7 ++- 4 files changed, 67 insertions(+), 74 deletions(-)
tools/net/ynl/generated/devlink-user.c +38 -36
@@ -126,7 +126,9 @@ int devlink_dl_info_version_parse(struct ynl_parse_arg *yarg,const struct nlattr *attr;mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_VERSION_NAME ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_INFO_VERSION_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -137,8 +139,7 @@ int devlink_dl_info_version_parse(struct ynl_parse_arg *yarg, dst->info_version_name =malloc (len +1 );memcpy (dst->info_version_name,mnl_attr_get_str (attr), len); dst->info_version_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_VERSION_VALUE ) { + }else if (type ==DEVLINK_ATTR_INFO_VERSION_VALUE ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -167,13 +168,14 @@ int devlink_dl_reload_stats_entry_parse(struct ynl_parse_arg *yarg,const struct nlattr *attr;mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_STATS_LIMIT ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_RELOAD_STATS_LIMIT ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_stats_limit =1 ; dst->reload_stats_limit =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_STATS_VALUE ) { + }else if (type ==DEVLINK_ATTR_RELOAD_STATS_VALUE ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_stats_value =1 ;
@@ -208,7 +210,9 @@ int devlink_dl_reload_act_stats_parse(struct ynl_parse_arg *yarg,return ynl_error_parse (yarg,"attribute already present (dl-reload-act-stats.reload-stats-entry)" );mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_STATS_ENTRY ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_RELOAD_STATS_ENTRY ) { n_reload_stats_entry++; } }
@@ -255,13 +259,14 @@ int devlink_dl_reload_act_info_parse(struct ynl_parse_arg *yarg,return ynl_error_parse (yarg,"attribute already present (dl-reload-act-info.reload-action-stats)" );mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_ACTION ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_RELOAD_ACTION ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_action =1 ; dst->reload_action =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_ACTION_STATS ) { + }else if (type ==DEVLINK_ATTR_RELOAD_ACTION_STATS ) { n_reload_action_stats++; } }
@@ -308,7 +313,9 @@ int devlink_dl_reload_stats_parse(struct ynl_parse_arg *yarg,return ynl_error_parse (yarg,"attribute already present (dl-reload-stats.reload-action-info)" );mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_ACTION_INFO ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_RELOAD_ACTION_INFO ) { n_reload_action_info++; } }
@@ -347,7 +354,9 @@ int devlink_dl_dev_stats_parse(struct ynl_parse_arg *yarg, parg.ys = yarg->ys;mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_STATS ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_RELOAD_STATS ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_stats =1 ;
@@ -356,8 +365,7 @@ int devlink_dl_dev_stats_parse(struct ynl_parse_arg *yarg, parg.data = &dst->reload_stats;if (devlink_dl_reload_stats_parse (&parg, attr))return MNL_CB_ERROR ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_REMOTE_RELOAD_STATS ) { + }else if (type ==DEVLINK_ATTR_REMOTE_RELOAD_STATS ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.remote_reload_stats =1 ;
@@ -400,7 +408,9 @@ int devlink_get_rsp_parse(const struct nlmsghdr *nlh, void *data) parg.ys = yarg->ys;mnl_attr_for_each (attr, nlh,sizeof (struct genlmsghdr )) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_BUS_NAME ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_BUS_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -411,8 +421,7 @@ int devlink_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->bus_name =malloc (len +1 );memcpy (dst->bus_name,mnl_attr_get_str (attr), len); dst->bus_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_DEV_NAME ) { + }else if (type ==DEVLINK_ATTR_DEV_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -423,20 +432,17 @@ int devlink_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->dev_name =malloc (len +1 );memcpy (dst->dev_name,mnl_attr_get_str (attr), len); dst->dev_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_FAILED ) { + }else if (type ==DEVLINK_ATTR_RELOAD_FAILED ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_failed =1 ; dst->reload_failed =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_RELOAD_ACTION ) { + }else if (type ==DEVLINK_ATTR_RELOAD_ACTION ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.reload_action =1 ; dst->reload_action =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_DEV_STATS ) { + }else if (type ==DEVLINK_ATTR_DEV_STATS ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.dev_stats =1 ;
@@ -576,7 +582,9 @@ int devlink_info_get_rsp_parse(const struct nlmsghdr *nlh, void *data)return ynl_error_parse (yarg,"attribute already present (devlink.info-version-stored)" );mnl_attr_for_each (attr, nlh,sizeof (struct genlmsghdr )) { -if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_BUS_NAME ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==DEVLINK_ATTR_BUS_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -587,8 +595,7 @@ int devlink_info_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->bus_name =malloc (len +1 );memcpy (dst->bus_name,mnl_attr_get_str (attr), len); dst->bus_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_DEV_NAME ) { + }else if (type ==DEVLINK_ATTR_DEV_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -599,8 +606,7 @@ int devlink_info_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->dev_name =malloc (len +1 );memcpy (dst->dev_name,mnl_attr_get_str (attr), len); dst->dev_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_DRIVER_NAME ) { + }else if (type ==DEVLINK_ATTR_INFO_DRIVER_NAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -611,8 +617,7 @@ int devlink_info_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->info_driver_name =malloc (len +1 );memcpy (dst->info_driver_name,mnl_attr_get_str (attr), len); dst->info_driver_name[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_SERIAL_NUMBER ) { + }else if (type ==DEVLINK_ATTR_INFO_SERIAL_NUMBER ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -623,14 +628,11 @@ int devlink_info_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->info_serial_number =malloc (len +1 );memcpy (dst->info_serial_number,mnl_attr_get_str (attr), len); dst->info_serial_number[len] =0 ; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_VERSION_FIXED ) { + }else if (type ==DEVLINK_ATTR_INFO_VERSION_FIXED ) { n_info_version_fixed++; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_VERSION_RUNNING ) { + }else if (type ==DEVLINK_ATTR_INFO_VERSION_RUNNING ) { n_info_version_running++; - } -else if (mnl_attr_get_type (attr) ==DEVLINK_ATTR_INFO_VERSION_STORED ) { + }else if (type ==DEVLINK_ATTR_INFO_VERSION_STORED ) { n_info_version_stored++; } }
tools/net/ynl/generated/fou-user.c +12 -19
@@ -172,42 +172,38 @@ int fou_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst = yarg->data;mnl_attr_for_each (attr, nlh,sizeof (struct genlmsghdr )) { -if (mnl_attr_get_type (attr) ==FOU_ATTR_PORT ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==FOU_ATTR_PORT ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.port =1 ; dst->port =mnl_attr_get_u16 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_IPPROTO ) { + }else if (type ==FOU_ATTR_IPPROTO ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.ipproto =1 ; dst->ipproto =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_TYPE ) { + }else if (type ==FOU_ATTR_TYPE ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.type =1 ; dst->type =mnl_attr_get_u8 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_REMCSUM_NOPARTIAL ) { + }else if (type ==FOU_ATTR_REMCSUM_NOPARTIAL ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.remcsum_nopartial =1 ; - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_LOCAL_V4 ) { + }else if (type ==FOU_ATTR_LOCAL_V4 ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.local_v4 =1 ; dst->local_v4 =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_PEER_V4 ) { + }else if (type ==FOU_ATTR_PEER_V4 ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.peer_v4 =1 ; dst->peer_v4 =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_LOCAL_V6 ) { + }else if (type ==FOU_ATTR_LOCAL_V6 ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -217,8 +213,7 @@ int fou_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->_present.local_v6_len = len; dst->local_v6 =malloc (len);memcpy (dst->local_v6,mnl_attr_get_payload (attr), len); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_PEER_V6 ) { + }else if (type ==FOU_ATTR_PEER_V6 ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
@@ -228,14 +223,12 @@ int fou_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst->_present.peer_v6_len = len; dst->peer_v6 =malloc (len);memcpy (dst->peer_v6,mnl_attr_get_payload (attr), len); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_PEER_PORT ) { + }else if (type ==FOU_ATTR_PEER_PORT ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.peer_port =1 ; dst->peer_port =mnl_attr_get_u16 (attr); - } -else if (mnl_attr_get_type (attr) ==FOU_ATTR_IFINDEX ) { + }else if (type ==FOU_ATTR_IFINDEX ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.ifindex =1 ;
tools/net/ynl/generated/handshake-user.c +13 -16
@@ -116,13 +116,14 @@ int handshake_x509_parse(struct ynl_parse_arg *yarg,const struct nlattr *attr;mnl_attr_for_each_nested (attr, nested) { -if (mnl_attr_get_type (attr) ==HANDSHAKE_A_X509_CERT ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==HANDSHAKE_A_X509_CERT ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.cert =1 ; dst->cert =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_X509_PRIVKEY ) { + }else if (type ==HANDSHAKE_A_X509_PRIVKEY ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.privkey =1 ;
@@ -171,37 +172,33 @@ int handshake_accept_rsp_parse(const struct nlmsghdr *nlh, void *data)return ynl_error_parse (yarg,"attribute already present (accept.peer-identity)" );mnl_attr_for_each (attr, nlh,sizeof (struct genlmsghdr )) { -if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_SOCKFD ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==HANDSHAKE_A_ACCEPT_SOCKFD ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.sockfd =1 ; dst->sockfd =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_MESSAGE_TYPE ) { + }else if (type ==HANDSHAKE_A_ACCEPT_MESSAGE_TYPE ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.message_type =1 ; dst->message_type =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_TIMEOUT ) { + }else if (type ==HANDSHAKE_A_ACCEPT_TIMEOUT ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.timeout =1 ; dst->timeout =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_AUTH_MODE ) { + }else if (type ==HANDSHAKE_A_ACCEPT_AUTH_MODE ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.auth_mode =1 ; dst->auth_mode =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_PEER_IDENTITY ) { + }else if (type ==HANDSHAKE_A_ACCEPT_PEER_IDENTITY ) { n_peer_identity++; - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_CERTIFICATE ) { + }else if (type ==HANDSHAKE_A_ACCEPT_CERTIFICATE ) { n_certificate++; - } -else if (mnl_attr_get_type (attr) ==HANDSHAKE_A_ACCEPT_PEERNAME ) { + }else if (type ==HANDSHAKE_A_ACCEPT_PEERNAME ) {unsigned int len;if (ynl_attr_validate (yarg, attr))
tools/net/ynl/generated/netdev-user.c +4 -3
@@ -79,13 +79,14 @@ int netdev_dev_get_rsp_parse(const struct nlmsghdr *nlh, void *data) dst = yarg->data;mnl_attr_for_each (attr, nlh,sizeof (struct genlmsghdr )) { -if (mnl_attr_get_type (attr) ==NETDEV_A_DEV_IFINDEX ) { +unsigned int type =mnl_attr_get_type (attr); + +if (type ==NETDEV_A_DEV_IFINDEX ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.ifindex =1 ; dst->ifindex =mnl_attr_get_u32 (attr); - } -else if (mnl_attr_get_type (attr) ==NETDEV_A_DEV_XDP_FEATURES ) { + }else if (type ==NETDEV_A_DEV_XDP_FEATURES ) {if (ynl_attr_validate (yarg, attr))return MNL_CB_ERROR ; dst->_present.xdp_features =1 ;
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 7/12 tools: ynl-gen: stop generating common notification handlers
In reply to Jakub KicinskiCommon notification handler was supposed to be a way for the user to parse the notifications from a socket synchronously. I don't think we'll end up using it, ynl_ntf_check() works for all known use cases.
--- tools/net/ynl/ynl-gen-c.py | 73 -------------------------------------- 1 file changed, 73 deletions(-)
tools/net/ynl/ynl-gen-c.py +0 -73
@@ -1810,70 +1810,6 @@ _C_KW = { ri.cw.nl() -def print_ntf_parse_prototype(family, cw, suffix=';'): - cw.write_func_prot('struct ynl_ntf_base_type *', f"{family['name']}_ntf_parse", - ['struct ynl_sock *ys'], suffix=suffix) - - -def print_ntf_type_parse(family, cw, ku_mode): - print_ntf_parse_prototype(family, cw, suffix='') - cw.block_start() - cw.write_func_lvar(['struct genlmsghdr *genlh;', - 'struct nlmsghdr *nlh;', - 'struct ynl_parse_arg yarg = { .ys = ys, };', - 'struct ynl_ntf_base_type *rsp;', - 'int len, err;', - 'mnl_cb_t parse;']) - cw.p('len = mnl_socket_recvfrom(ys->sock, ys->rx_buf, MNL_SOCKET_BUFFER_SIZE);') - cw.p('if (len < (ssize_t)(sizeof(*nlh) + sizeof(*genlh)))') - cw.p('return NULL;') - cw.nl() - cw.p('nlh = (struct nlmsghdr *)ys->rx_buf;') - cw.p('genlh = mnl_nlmsg_get_payload(nlh);') - cw.nl() - cw.block_start(line='switch (genlh->cmd)') - for ntf_op in sorted(family.all_notify.keys()): - op = family.ops[ntf_op] - ri = RenderInfo(cw, family, ku_mode, op, ntf_op, "notify") - for ntf in op['notify']['cmds']: - cw.p(f"case {ntf.enum_name}:") - cw.p(f"rsp = calloc(1, sizeof({type_name(ri, 'notify')}));") - cw.p(f"parse = {op_prefix(ri, 'reply', deref=True)}_parse;") - cw.p(f"yarg.rsp_policy = &{ri.struct['reply'].render_name}_nest;") - cw.p(f"rsp->free = (void *){op_prefix(ri, 'notify')}_free;") - cw.p('break;') - for op_name, op in family.ops.items(): - if 'event' not in op: - continue - ri = RenderInfo(cw, family, ku_mode, op, op_name, "event") - cw.p(f"case {op.enum_name}:") - cw.p(f"rsp = calloc(1, sizeof({type_name(ri, 'event')}));") - cw.p(f"parse = {op_prefix(ri, 'reply', deref=True)}_parse;") - cw.p(f"yarg.rsp_policy = &{ri.struct['reply'].render_name}_nest;") - cw.p(f"rsp->free = (void *){op_prefix(ri, 'notify')}_free;") - cw.p('break;') - cw.p('default:') - cw.p('ynl_error_unknown_notification(ys, genlh->cmd);') - cw.p('return NULL;') - cw.block_end() - cw.nl() - cw.p('yarg.data = rsp->data;') - cw.nl() - cw.p(f"err = {cw.nlib.parse_cb_run('parse', '&yarg', True)};") - cw.p('if (err < 0)') - cw.p('goto err_free;') - cw.nl() - cw.p('rsp->family = nlh->nlmsg_type;') - cw.p('rsp->cmd = genlh->cmd;') - cw.p('return rsp;') - cw.nl() - cw.p('err_free:') - cw.p('free(rsp);') - cw.p('return NULL;') - cw.block_end() - cw.nl() - - def print_req_policy_fwd(cw, struct, ri=None, terminate=True): if terminate and ri and kernel_can_gen_family_struct(struct.family): return
@@ -2513,10 +2449,6 @@ _C_KW = { print_rsp_type(ri) cw.nl() print_wrapped_type(ri) - - if parsed.has_notifications(): - cw.p('/* --------------- Common notification parsing --------------- */') - print_ntf_parse_prototype(parsed, cw) cw.nl() else: cw.p('/* Enums */')
@@ -2580,11 +2512,6 @@ _C_KW = { ri = RenderInfo(cw, parsed, args.mode, op, op_name, "event") print_ntf_type_free(ri) - - if parsed.has_notifications(): - cw.p('/* --------------- Common notification parsing --------------- */') - print_ntf_type_parse(parsed, cw, args.mode) - cw.nl() render_user_family(parsed, cw, False)
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 8/12 tools: ynl: regen: stop generating common notification handlers
In reply to Jakub KicinskiRemove unused notification handlers.
--- tools/net/ynl/generated/handshake-user.c | 45 ----------------------- tools/net/ynl/generated/handshake-user.h | 3 -- tools/net/ynl/generated/netdev-user.c | 47 ------------------------ tools/net/ynl/generated/netdev-user.h | 3 -- 4 files changed, 98 deletions(-)
tools/net/ynl/generated/handshake-user.c +0 -45
@@ -315,51 +315,6 @@ int handshake_done(struct ynl_sock *ys, struct handshake_done_req *req)return 0 ; } -/* --------------- Common notification parsing --------------- */ -struct ynl_ntf_base_type *handshake_ntf_parse (struct ynl_sock *ys) -{ -struct ynl_parse_arg yarg = { .ys = ys, }; -struct ynl_ntf_base_type *rsp; -struct genlmsghdr *genlh; -struct nlmsghdr *nlh; -mnl_cb_t parse; -int len, err; - - len =mnl_socket_recvfrom (ys->sock, ys->rx_buf,MNL_SOCKET_BUFFER_SIZE ); -if (len < (ssize_t )(sizeof (*nlh) +sizeof (*genlh))) -return NULL ; - - nlh = (struct nlmsghdr *)ys->rx_buf; - genlh =mnl_nlmsg_get_payload (nlh); - -switch (genlh->cmd) { -case HANDSHAKE_CMD_READY : - rsp =calloc (1 ,sizeof (struct handshake_accept_ntf )); - parse = handshake_accept_rsp_parse; - yarg.rsp_policy = &handshake_accept_nest; - rsp->free = (void *)handshake_accept_ntf_free; -break ; -default : -ynl_error_unknown_notification (ys, genlh->cmd); -return NULL ; - } - - yarg.data = rsp->data; - - err =mnl_cb_run2 (ys->rx_buf, len,0 ,0 , parse, &yarg, - ynl_cb_array,NLMSG_MIN_TYPE ); -if (err <0 ) - goto err_free; - - rsp->family = nlh->nlmsg_type; - rsp->cmd = genlh->cmd; -return rsp; - -err_free: -free (rsp); -return NULL ; -} -static const struct ynl_ntf_info handshake_ntf_info[] = { [HANDSHAKE_CMD_READY ] = { .alloc_sz =sizeof (struct handshake_accept_ntf ),
tools/net/ynl/generated/handshake-user.h +0 -3
@@ -142,7 +142,4 @@ __handshake_done_req_set_remote_auth(struct handshake_done_req *req,*/ int handshake_done (struct ynl_sock *ys,struct handshake_done_req *req); -/* --------------- Common notification parsing --------------- */ -struct ynl_ntf_base_type *handshake_ntf_parse (struct ynl_sock *ys); -#endif /* _LINUX_HANDSHAKE_GEN_H */
tools/net/ynl/generated/netdev-user.c +0 -47
53 lines not on this page · raw message
tools/net/ynl/generated/netdev-user.h +0 -3
@@ -82,7 +82,4 @@ struct netdev_dev_get_ntf {void netdev_dev_get_ntf_free (struct netdev_dev_get_ntf *rsp); -/* --------------- Common notification parsing --------------- */ -struct ynl_ntf_base_type *netdev_ntf_parse (struct ynl_sock *ys); -#endif /* _LINUX_NETDEV_GEN_H */
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 9/12 tools: ynl-gen: sanitize notification tracking
In reply to Jakub KicinskiDon't modify the raw dicts (as loaded from YAML) to pretend that the notify attributes also exist on the ops. This makes the code easier to follow.
--- tools/net/ynl/lib/nlspec.py | 5 ++- tools/net/ynl/ynl-gen-c.py | 65 +++++++++++++------------------------ 2 files changed, 27 insertions(+), 43 deletions(-)
tools/net/ynl/lib/nlspec.py +4 -1
@@ -329,8 +329,8 @@ jsonschema = None attr_sets dict of attribute sets msgs dict of all messages (index by name) - msgs_by_value dict of all messages (indexed by name) ops dict of all valid requests / responses + ntfs dict of all async events consts dict of all constants/enums fixed_header string, optional name of family default fixed header struct """
@@ -370,6 +370,7 @@ jsonschema = None self.req_by_value = collections.OrderedDict() self.rsp_by_value = collections.OrderedDict() self.ops = collections.OrderedDict() + self.ntfs = collections.OrderedDict() self.consts = collections.OrderedDict() last_exception = None
@@ -491,3 +492,5 @@ jsonschema = None self.rsp_by_value[op.rsp_value] = op if not op.is_async and 'attribute-set' in op: self.ops[op.name] = op + elif op.is_async: + self.ntfs[op.name] = op
tools/net/ynl/ynl-gen-c.py +23 -42
151 lines not on this page · raw message
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 10/12 tools: ynl-gen: support code gen for events
In reply to Jakub KicinskiNetlink specs support both events and notifications (former can define their own message contents). Plug in missing code to generate types, parsers and include events into notification tables.
--- tools/net/ynl/lib/nlspec.py | 2 +- tools/net/ynl/ynl-gen-c.py | 17 ++++++++++++----- 2 files changed, 13 insertions(+), 6 deletions(-)
tools/net/ynl/lib/nlspec.py +1 -1
@@ -423,7 +423,7 @@ jsonschema = None self.fixed_header = self.yaml['operations'].get('fixed-header') req_val = rsp_val = 1 for elem in self.yaml['operations']['list']: - if 'notify' in elem: + if 'notify' in elem or 'event' in elem: if 'value' in elem: rsp_val = elem['value'] req_val_next = req_val
tools/net/ynl/ynl-gen-c.py +12 -5
@@ -828,7 +828,7 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S } def _load_root_sets(self): - for op_name, op in self.ops.items(): + for op_name, op in self.msgs.items(): if 'attribute-set' not in op: continue
@@ -839,6 +839,8 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S req_attrs.update(set(op[op_mode]['request']['attributes'])) if op_mode in op and 'reply' in op[op_mode]: rsp_attrs.update(set(op[op_mode]['reply']['attributes'])) + if 'event' in op: + rsp_attrs.update(set(op['event']['attributes'])) if op['attribute-set'] not in self.root_sets: self.root_sets[op['attribute-set']] = {'request': req_attrs, 'reply': rsp_attrs}
@@ -2193,10 +2195,13 @@ _C_KW = { if family.ntfs: cw.block_start(line=f"static const struct ynl_ntf_info {family['name']}_ntf_info[] = ") for ntf_op_name, ntf_op in family.ntfs.items(): - if 'notify' not in ntf_op: - continue - op = family.ops[ntf_op['notify']] - ri = RenderInfo(cw, family, "user", op, op.name, "notify") + if 'notify' in ntf_op: + op = family.ops[ntf_op['notify']] + ri = RenderInfo(cw, family, "user", op, op.name, "notify") + elif 'event' in ntf_op: + ri = RenderInfo(cw, family, "user", ntf_op, ntf_op_name, "event") + else: + raise Exception('Invalid notification ' + ntf_op_name) _render_user_ntf_entry(ri, ntf_op) for op_name, op in family.ops.items(): if 'event' not in op:
@@ -2424,6 +2429,7 @@ _C_KW = { raise Exception(f'Only notifications with consistent types supported ({op.name})') print_wrapped_type(ri) + for op_name, op in parsed.ntfs.items(): if 'event' in op: ri = RenderInfo(cw, parsed, args.mode, op, op_name, 'event') cw.p(f"/* {op.enum_name} - event */")
@@ -2485,6 +2491,7 @@ _C_KW = { raise Exception(f'Only notifications with consistent types supported ({op.name})') print_ntf_type_free(ri) + for op_name, op in parsed.ntfs.items(): if 'event' in op: cw.p(f"/* {op.enum_name} - event */")
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 11/12 tools: ynl-gen: don't pass op_name to RenderInfo
In reply to Jakub KicinskiThe op_name argument is barely used and identical to op.name in all cases.
--- tools/net/ynl/ynl-gen-c.py | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-)
tools/net/ynl/ynl-gen-c.py +18 -19
@@ -957,13 +957,12 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S class RenderInfo: - def __init__(self, cw, family, ku_space, op, op_name, op_mode, attr_set=None): + def __init__(self, cw, family, ku_space, op, op_mode, attr_set=None): self.family = family self.nl = cw.nlib self.ku_space = ku_space self.op_mode = op_mode self.op = op - self.op_name = op_name # 'do' and 'dump' response parsing is identical self.type_consistent = True
@@ -978,7 +977,7 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S self.attr_set = op['attribute-set'] if op: - self.type_name = c_lower(op_name) + self.type_name = c_lower(op.name) else: self.type_name = c_lower(attr_set)
@@ -2197,16 +2196,16 @@ _C_KW = { for ntf_op_name, ntf_op in family.ntfs.items(): if 'notify' in ntf_op: op = family.ops[ntf_op['notify']] - ri = RenderInfo(cw, family, "user", op, op.name, "notify") + ri = RenderInfo(cw, family, "user", op, "notify") elif 'event' in ntf_op: - ri = RenderInfo(cw, family, "user", ntf_op, ntf_op_name, "event") + ri = RenderInfo(cw, family, "user", ntf_op, "event") else: raise Exception('Invalid notification ' + ntf_op_name) _render_user_ntf_entry(ri, ntf_op) for op_name, op in family.ops.items(): if 'event' not in op: continue - ri = RenderInfo(cw, family, "user", op, op_name, "event") + ri = RenderInfo(cw, family, "user", op, "event") _render_user_ntf_entry(ri, op) cw.block_end(line=";") cw.nl()
@@ -2343,7 +2342,7 @@ _C_KW = { if parsed.kernel_policy in {'per-op', 'split'}: for op_name, op in parsed.ops.items(): if 'do' in op and 'event' not in op: - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "do") + ri = RenderInfo(cw, parsed, args.mode, op, "do") print_req_policy_fwd(cw, ri.struct['request'], ri=ri) cw.nl()
@@ -2372,7 +2371,7 @@ _C_KW = { for op_mode in ['do', 'dump']: if op_mode in op and 'request' in op[op_mode]: cw.p(f"/* {op.enum_name} - {op_mode} */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, op_mode) + ri = RenderInfo(cw, parsed, args.mode, op, op_mode) print_req_policy(cw, ri.struct['request'], ri=ri) cw.nl()
@@ -2392,7 +2391,7 @@ _C_KW = { cw.p('/* Common nested types */') for attr_set, struct in parsed.pure_nested_structs.items(): - ri = RenderInfo(cw, parsed, args.mode, "", "", "", attr_set) + ri = RenderInfo(cw, parsed, args.mode, "", "", attr_set) print_type_full(ri, struct) for op_name, op in parsed.ops.items():
@@ -2400,7 +2399,7 @@ _C_KW = { if 'do' in op and 'event' not in op: cw.p(f"/* {op.enum_name} - do */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "do") + ri = RenderInfo(cw, parsed, args.mode, op, "do") print_req_type(ri) print_req_type_helpers(ri) cw.nl()
@@ -2412,7 +2411,7 @@ _C_KW = { if 'dump' in op: cw.p(f"/* {op.enum_name} - dump */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, 'dump') + ri = RenderInfo(cw, parsed, args.mode, op, 'dump') if 'request' in op['dump']: print_req_type(ri) print_req_type_helpers(ri)
@@ -2424,14 +2423,14 @@ _C_KW = { if op.has_ntf: cw.p(f"/* {op.enum_name} - notify */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, 'notify') + ri = RenderInfo(cw, parsed, args.mode, op, 'notify') if not ri.type_consistent: raise Exception(f'Only notifications with consistent types supported ({op.name})') print_wrapped_type(ri) for op_name, op in parsed.ntfs.items(): if 'event' in op: - ri = RenderInfo(cw, parsed, args.mode, op, op_name, 'event') + ri = RenderInfo(cw, parsed, args.mode, op, 'event') cw.p(f"/* {op.enum_name} - event */") print_rsp_type(ri) cw.nl()
@@ -2456,7 +2455,7 @@ _C_KW = { cw.p('/* Common nested types */') for attr_set, struct in parsed.pure_nested_structs.items(): - ri = RenderInfo(cw, parsed, args.mode, "", "", "", attr_set) + ri = RenderInfo(cw, parsed, args.mode, "", "", attr_set) free_rsp_nested(ri, struct) if struct.request:
@@ -2468,7 +2467,7 @@ _C_KW = { cw.p(f"/* ============== {op.enum_name} ============== */") if 'do' in op and 'event' not in op: cw.p(f"/* {op.enum_name} - do */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "do") + ri = RenderInfo(cw, parsed, args.mode, op, "do") print_req_free(ri) print_rsp_free(ri) parse_rsp_msg(ri)
@@ -2477,7 +2476,7 @@ _C_KW = { if 'dump' in op: cw.p(f"/* {op.enum_name} - dump */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "dump") + ri = RenderInfo(cw, parsed, args.mode, op, "dump") if not ri.type_consistent: parse_rsp_msg(ri, deref=True) print_dump_type_free(ri)
@@ -2486,7 +2485,7 @@ _C_KW = { if op.has_ntf: cw.p(f"/* {op.enum_name} - notify */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, 'notify') + ri = RenderInfo(cw, parsed, args.mode, op, 'notify') if not ri.type_consistent: raise Exception(f'Only notifications with consistent types supported ({op.name})') print_ntf_type_free(ri)
@@ -2495,10 +2494,10 @@ _C_KW = { if 'event' in op: cw.p(f"/* {op.enum_name} - event */") - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "do") + ri = RenderInfo(cw, parsed, args.mode, op, "do") parse_rsp_msg(ri) - ri = RenderInfo(cw, parsed, args.mode, op, op_name, "event") + ri = RenderInfo(cw, parsed, args.mode, op, "event") print_ntf_type_free(ri) cw.nl() render_user_family(parsed, cw, False)
Signature · 1 line
2.40.1
Jakub Kicinski
maintainerPATCH 12/12 tools: ynl-gen: support / skip pads on the way to kernel
In reply to Jakub KicinskiKernel does not have padding requirements for 64b attrs. We can ignore pad attrs.
--- tools/net/ynl/ynl-gen-c.py | 6 ++++++ 1 file changed, 6 insertions(+)
tools/net/ynl/ynl-gen-c.py +6 -0
@@ -227,12 +227,18 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S def _attr_typol(self): return '.type = YNL_PT_IGNORE, ' + def attr_put(self, ri, var): + pass + def attr_get(self, ri, var, first): pass def attr_policy(self, cw): pass + def setter(self, ri, space, direction, deref=False, ref=None): + pass + class TypeScalar(Type): def __init__(self, family, attr_set, attr, value):
Signature · 1 line
2.40.1
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 19 lines · On Thu, 8 Jun 2023 14:11:48 -0700 you wrote:
I was going to post ethtool but I couldn't stand the ugliness of the if conditions which were previously generated. So I cleaned that up and improved a number of other things ethtool will benefit from.
Jakub Kicinski (12):
tools: ynl-gen: cleanup user space header includes
tools: ynl: regen: cleanup user space header includes
tools: ynl-gen: complete the C keyword list
tools: ynl-gen: combine else with closing bracket
tools: ynl-gen: get attr type outside ofif()
tools: ynl: regen: regenerate the if ladders
tools: ynl-gen: stop generating common notification handlers
tools: ynl: regen: stop generating common notification handlers
tools: ynl-gen: sanitize notification tracking
tools: ynl-gen: support code gen for events
tools: ynl-gen: don't passop_nameto RenderInfo
tools: ynl-gen: support / skip pads on the way to kernel
Quoted 1 line
[...]
Here is the summary with links:
- [net-next,01/12] tools: ynl-gen: cleanup user space header includes
https://git.kernel.org/netdev/net-next/c/30b5c720e1a9 - [net-next,02/12] tools: ynl: regen: cleanup user space header includes https://git.kernel.org/netdev/net-next/c/9b52fd4b6305 - [net-next,03/12] tools: ynl-gen: complete the C keyword list https://git.kernel.org/netdev/net-next/c/820343ccbb2e - [net-next,04/12] tools: ynl-gen: combine else with closing bracket https://git.kernel.org/netdev/net-next/c/2c0f1466867c - [net-next,05/12] tools: ynl-gen: get attr type outside of if() https://git.kernel.org/netdev/net-next/c/e4ea3cc68472 - [net-next,06/12] tools: ynl: regen: regenerate the if ladders https://git.kernel.org/netdev/net-next/c/7234415b8f86 - [net-next,07/12] tools: ynl-gen: stop generating common notification handlers https://git.kernel.org/netdev/net-next/c/f2ba1e5e2208 - [net-next,08/12] tools: ynl: regen: stop generating common notification handlers https://git.kernel.org/netdev/net-next/c/d0915d64c3a6 - [net-next,09/12] tools: ynl-gen: sanitize notification tracking https://git.kernel.org/netdev/net-next/c/ced1568862bd - [net-next,10/12] tools: ynl-gen: support code gen for events https://git.kernel.org/netdev/net-next/c/6da3424fd629 - [net-next,11/12] tools: ynl-gen: don't pass op_name to RenderInfo https://git.kernel.org/netdev/net-next/c/6f96ec73cb5a - [net-next,12/12] tools: ynl-gen: support / skip pads on the way to kernel https://git.kernel.org/netdev/net-next/c/76abff37f0d7
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html