drm/amd/pm: workaround for compute workload type on some skus
Subsystems (3)
Kenneth Feng
maintainerPATCH 1/1 drm/amd/pm: workaround for compute workload type on some skus
On smu 13.0.0, the compute workload type cannot be set on all the skus due to some other problems. This workaround is to make sure compute workload type can also run on some specific skus.
--- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +26 -0
@@ -2179,6 +2179,32 @@ static int smu_v13_0_0_set_power_profile_mode(struct smu_context *smu, } } +if (smu->power_profile_mode ==PP_SMC_POWER_PROFILE_COMPUTE && + (((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xC8 )) || + ((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xCC )))) { + ret =smu_cmn_update_table (smu, +SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_COMPUTE_BIT , + (void *)(&activity_monitor_external), + false); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to get activity monitor!" , __func__); +return ret; + } + + ret =smu_cmn_update_table (smu, +SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_CUSTOM_BIT , + (void *)(&activity_monitor_external), + true); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to set activity monitor!" , __func__); +return ret; + } + + smu->power_profile_mode =PP_SMC_POWER_PROFILE_CUSTOM ; + } +/* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */ workload_type = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_WORKLOAD,
Signature · 1 line
2.34.1
[AMD Official Use Only - General]
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Kenneth Feng
Sent: Friday, June 9, 2023 10:56 AM
To: [email protected]
Cc: Quan, Evan <[email protected]>; Feng, Kenneth <[email protected]>
Subject: [PATCH] drm/amd/pm: workaround for compute workload type on some skus
On smu 13.0.0, the compute workload type cannot be set on all the skus due to some other problems. This workaround is to make sure compute workload type can also run on some specific skus.
--- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +26 -0
@@ -2179,6 +2179,32 @@ static int smu_v13_0_0_set_power_profile_mode(struct smu_context *smu, } } +if (smu->power_profile_mode ==PP_SMC_POWER_PROFILE_COMPUTE && + (((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xC8 )) || + ((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xCC )))) { + ret =smu_cmn_update_table (smu, +SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_COMPUTE_BIT , + (void *)(&activity_monitor_external), + false); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to get activity monitor!" , __func__); +return ret; + } + + ret =smu_cmn_update_table (smu, +SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_CUSTOM_BIT , + (void *)(&activity_monitor_external), + true); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to set activity monitor!" , __func__); +return ret; + } + + smu->power_profile_mode =PP_SMC_POWER_PROFILE_CUSTOM ; + } +/* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */ workload_type = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_WORKLOAD,
--
2.34.1
Quoted 31 lines · Kenneth Feng
On smu 13.0.0, the compute workload type cannot be set on all the skus due to some other problems. This workaround is to make sure compute workload type can also run on some specific skus.
Signed-off-by Kenneth Feng <[email protected]>--- .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+)drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +14
-0@@ -2179,6 +2179,32 @@ static int smu_v13_0_0_set_power_profile_mode(struct smu_context *smu, } } +if (smu->power_profile_mode ==PP_SMC_POWER_PROFILE_COMPUTE && + (((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xC8 )) || + ((smu->adev->pdev->device ==0x744C ) && (smu->adev->pdev->revision ==0xCC )))) { + ret =smu_cmn_update_table (smu, +SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_COMPUTE_BIT , + (void *)(&activity_monitor_external), + false); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to get activity monitor!" , __func__); +return ret; + } + + ret = smu_cmn_update_table(smu,
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c static int smu_v13_0_0_set_power_profile_mode(struct smu_context *smu, · line 2205
Quoted 10 lines
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +10
-0+SMU_TABLE_ACTIVITY_MONITOR_COEFF , +WORKLOAD_PPLIB_CUSTOM_BIT , + (void *)(&activity_monitor_external), + true); +if (ret) { +dev_err (smu->adev->dev,"[%s] Failed to set activity monitor!" , __func__); +return ret; + } + + smu->power_profile_mode =PP_SMC_POWER_PROFILE_CUSTOM ;
Though custom profile is used to set compute profile as a workaround, shouldn't this be set to COMPUTE to indicate that the current profile set is COMPUTE?
Thanks,
Lijo
Quoted 5 lines
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c +2
-0+ } +/* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */ workload_type = smu_cmn_to_asic_specific_index(smu, CMN2ASIC_MAPPING_WORKLOAD,