iommu/vt-d: Remove commented-out code
Subsystems (2)
Lu Baolu
maintainerPATCH 1/1 iommu/vt-d: Remove commented-out code
These lines of code were commented out when they were first added in commit ba39592764ed ("Intel IOMMU: Intel IOMMU driver"). We do not want to restore them because the VT-d spec has deprecated the read/write draining hit.
VT-d spec (section 11.4.2):
"
Hardware implementation with Major Version 2 or higher (VER_REG), always performs required drain without software explicitly requesting a drain in IOTLB invalidation. This field is deprecated and hardware will always report it as 1 to maintain backward compatibility with software.
"
Remove the code to make the code cleaner.
--- drivers/iommu/intel/iommu.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/iommu/intel/iommu.c +1 -9
@@ -1312,15 +1312,7 @@ static void __iommu_flush_iotlb(struct intel_iommu *iommu, u16 did, iommu->name, type);return ; } -/* Note: set drain read/write */ -#if 0 -/* -* This is probably to be super secure.. Looks like we can -* ignore it without any impact. -*/ -if (cap_read_drain (iommu->cap)) - val |=DMA_TLB_READ_DRAIN ; -#endif +if (cap_write_drain (iommu->cap)) val |=DMA_TLB_WRITE_DRAIN ;
Signature · 1 line
2.34.1
Quoted 12 lines · Lu Baolu
These lines of code were commented out when they were first added in commit
ba39592764ed("Intel IOMMU: Intel IOMMU driver"). We do not want to restore them because the VT-d spec has deprecated the read/write draining hit.VT-d spec (section 11.4.2):
"
Hardware implementation with Major Version 2 or higher (VER_REG), always performs required drain without software explicitly requesting a drain in IOTLB invalidation. This field is deprecated and hardware will always report it as 1 to maintain backward compatibility with software.
"
Quoted 3 lines
Remove the code to make the code cleaner.
Signed-off-by Lu Baolu <[email protected]>
Quoted 28 lines
--- drivers/iommu/intel/iommu.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)drivers/iommu/intel/iommu.c +1
-9@@ -1312,15 +1312,7 @@ static void __iommu_flush_iotlb(struct intel_iommu *iommu, u16 did, iommu->name, type);return ; } -/* Note: set drain read/write */ -#if 0 -/* -* This is probably to be super secure.. Looks like we can -* ignore it without any impact. -*/ -if (cap_read_drain (iommu->cap)) - val |=DMA_TLB_READ_DRAIN ; -#endif +if (cap_write_drain (iommu->cap)) val |=DMA_TLB_WRITE_DRAIN ;Signature · 1 line
2.34.1