Skip to contentSkip to conversation

Fix some configuration options for systemd

PATCH Superseded [email protected] 2 participants 5 messages Jun 9, 2023 – Jun 12, 2023

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Fix some configuration options for systemd

From: Randolph Sapp <[email protected]>

Fixing up some systemd stuff. Using the auto getty generator built into systemd instead of the external oe-core getty service.

Also drop the duplicate/invalid useradd entries in the systemd append.

This should be all that's required to squelch the endless serial getty start/stop logs for systemd. There's probably some work required for sysvinit as well. Should just be setting SERIAL_CONSOLES_CHECK = $SERIAL_CONSOLES or something along those lines.

Still not sure how I feel about having inactive serial console definitions in a bsp layer but if we don't define it at all then oe-core will just blindly assume we wanted a console on ttyS0. That's especially problematic for the init systems unable to generate getty scripts automatically. SERIAL_CONSOLES_CHECK at least fixes the sysvinit behavior.

Randolph Sapp (3):
systemd: drop the useradd params arago.conf: add serial-getty-generator to systemd
systemd: move packageconfig appends to distro config

 meta-arago-distro/conf/distro/arago.conf                  | 2 +-
 meta-arago-distro/recipes-core/systemd/systemd_%.bbappend | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)
Signature · 1 line
2.41.0
#2 lore raw

PATCH v2 2/3 arago.conf: add serial-getty-generator to systemd

From: Randolph Sapp <[email protected]>

Use systemd's built-in getty generator instead of the OE-Core variant.

---
 meta-arago-distro/conf/distro/arago.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/conf/distro/arago.conf +1 -1
index 03272511..7354a98e 100644
@@ -69,7 +69,7 @@ DISTRO_FEATURES:append = "${@ '' if oe.types.boolean(d.getVar('ARAGO_SYSVINIT'))
 DISTRO_FEATURES:remove = "${@ '' if oe.types.boolean(d.getVar('ARAGO_SYSVINIT')) else ' sysvinit'}"
 
 # Distro-specific package configuration
-PACKAGECONFIG:append:pn-systemd = " coredump"
+PACKAGECONFIG:append:pn-systemd = " coredump serial-getty-generator"
 
 # Configure Qt5 flags (GLES is still required for qtdeclarative and qtwebkit)
 PACKAGECONFIG_GL:pn-qtbase = "gles2 linuxfb"
Signature · 1 line
2.41.0
#3 lore raw

PATCH v2 3/3 systemd: move packageconfig appends to distro config

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Move the systemd PACKAGECONFIG append strings to the distro config.

---
 meta-arago-distro/conf/distro/arago.conf                  | 2 +-
 meta-arago-distro/recipes-core/systemd/systemd_%.bbappend | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
meta-arago-distro/conf/distro/arago.conf +1 -1
index 7354a98e..528635e3 100644
@@ -69,7 +69,7 @@ DISTRO_FEATURES:append = "${@ '' if oe.types.boolean(d.getVar('ARAGO_SYSVINIT'))
 DISTRO_FEATURES:remove = "${@ '' if oe.types.boolean(d.getVar('ARAGO_SYSVINIT')) else ' sysvinit'}"
 
 # Distro-specific package configuration
-PACKAGECONFIG:append:pn-systemd = " coredump serial-getty-generator"
+PACKAGECONFIG:append:pn-systemd = " coredump networkd resolved serial-getty-generator"
 
 # Configure Qt5 flags (GLES is still required for qtdeclarative and qtwebkit)
 PACKAGECONFIG_GL:pn-qtbase = "gles2 linuxfb"
meta-arago-distro/recipes-core/systemd/systemd_%.bbappend +0 -2
index a38ca124..3de94336 100644
@@ -2,8 +2,6 @@ PR:append = ".arago6"
 
 FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
-PACKAGECONFIG:append = " networkd resolved"
-
 SRC_URI:append = " \
     file://local.rules \
     file://usb1-rules.sh \
Signature · 1 line
2.41.0
#1 lore raw

PATCH v2 1/3 systemd: drop the useradd params

In reply to [email protected]

From: Randolph Sapp <[email protected]>

This currently points to an invalid shell (bin -> sbin) and OE-Core has been carrying the equivalent patch since: d18957925c (systemd: Create missing sysusers offline, 2016-05-17)

---
 meta-arago-distro/recipes-core/systemd/systemd_%.bbappend | 2 --
 1 file changed, 2 deletions(-)
meta-arago-distro/recipes-core/systemd/systemd_%.bbappend +0 -2
index 9e49ac69..a38ca124 100644
@@ -3,8 +3,6 @@ PR:append = ".arago6"
 FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
 
 PACKAGECONFIG:append = " networkd resolved"
-USERADD_PARAM:${PN} += "--system -d / -M --shell /bin/nologin systemd-network;"
-USERADD_PARAM:${PN} += "--system -d / -M --shell /bin/nologin systemd-resolve;"
 
 SRC_URI:append = " \
     file://local.rules \
Signature · 1 line
2.41.0
#4 lore raw
In reply to [email protected]

This patch series does not apply cleanly because it assumes your previous patches were applied. But we are not accepting those patches until the identified issue is resolved.

If this patch series is independent of that series, then please resubmit this series on top of current kirkstone.

Quoted 28 lines · On 6/9/2023 2:24 PM, [email protected] wrote:

From: Randolph Sapp <[email protected]>

Fixing up some systemd stuff. Using the auto getty generator built into systemd instead of the external oe-core getty service.

Also drop the duplicate/invalid useradd entries in the systemd append.

This should be all that's required to squelch the endless serial getty start/stop logs for systemd. There's probably some work required for sysvinit as well. Should just be setting SERIAL_CONSOLES_CHECK = $SERIAL_CONSOLES or something along those lines.

Still not sure how I feel about having inactive serial console definitions in a bsp layer but if we don't define it at all then oe-core will just blindly assume we wanted a console on ttyS0. That's especially problematic for the init systems unable to generate getty scripts automatically. SERIAL_CONSOLES_CHECK at least fixes the sysvinit behavior.

Randolph Sapp (3):
systemd: drop the useradd params arago.conf: add serial-getty-generator to systemd
systemd: move packageconfig appends to distro config

  meta-arago-distro/conf/distro/arago.conf                  | 2 +-
  meta-arago-distro/recipes-core/systemd/systemd_%.bbappend | 4 ----
  2 files changed, 1 insertion(+), 5 deletions(-)
Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS