Skip to contentSkip to conversation

EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

PATCH In review Tom Rix 3 participants 3 messages Jun 10, 2023 – Jun 19, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 EDAC/amd64: set variable gpu_node_map storage-class-specifier to static

smatch reports drivers/edac/amd64_edac.c:990:3: warning: symbol
'gpu_node_map' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

---
 drivers/edac/amd64_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/amd64_edac.c +1 -1
index 5d7c080d96a2..597dae7692b1 100644
@@ -984,7 +984,7 @@ static int sys_addr_to_csrow(struct mem_ctl_info *mci, u64 sys_addr)
  * system and what the lowest AMD Node ID value is for the GPU nodes. Use this
  * info to fixup the Linux logical "Node ID" value set in the AMD NB code and EDAC.
  */
-struct local_node_map {
+static struct local_node_map {
 	u16 node_count;
 	u16 base_node_id;
 } gpu_node_map;
Signature · 1 line
2.27.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tom Rix

smatch reports
drivers/edac/amd64_edac.c:990:3: warning: symbol
'gpu_node_map' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Hi Tom,

Please use "imperative mood" when describing the change.

"This variable is only used in its defining file, so add the 'static' keyword to it."

or

"Make gpu_node_map static, since it's only used in its defining file."

Also, would a Fixes tag be appropriate?

Otherwise, looks good to me.

Thanks,
Yazen

maintainer
#2 lore raw
Quoted 1 line · Yazen Ghannam

Also, would a Fixes tag be appropriate?

No need. I've squashed this with the topmost commit in tip:ras/core which introduced gpu_node_map in the first place.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette