Skip to contentSkip to conversation

clk: meson: a1: Staticize rtc clk

PATCH Applied Stephen Boyd 3 participants 4 messages Jun 12, 2023

Subsystems (3)
lore
Share & tools
lore

Stephen Boyd

author maintainer
#0 lore raw

PATCH 1/1 clk: meson: a1: Staticize rtc clk

Sparse rightly complains that this symbol is supposed to be static.

Cc Jian Hu <[email protected]>
Cc Dmitry Rokosov <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Jerome Brunet <[email protected]>
Fixes 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
---
 drivers/clk/meson/a1-peripherals.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/a1-peripherals.c +1 -1
index b320134fefeb..75dfae210fe5 100644
@@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
 	},
 };
 
-struct clk_regmap rtc = {
+static struct clk_regmap rtc = {
 	.data = &(struct clk_regmap_gate_data){
 		.offset = RTC_BY_OSCIN_CTRL0,
 		.bit_idx = 30,
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Stephen Boyd

Sparse rightly complains that this symbol is supposed to be static.

Cc Jian Hu <[email protected]>
Cc Dmitry Rokosov <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Jerome Brunet <[email protected]>
Fixes 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")

Sorry this got through.

Quoted 17 lines
---
 drivers/clk/meson/a1-peripherals.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/meson/a1-peripherals.c +1 -1
index b320134fefeb..75dfae210fe5 100644
@@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
 	},
 };
 
-struct clk_regmap rtc = {
+static struct clk_regmap rtc = {
 	.data = &(struct clk_regmap_gate_data){
 		.offset = RTC_BY_OSCIN_CTRL0,
 		.bit_idx = 30,
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Stephen Boyd
Quoted 9 lines · Stephen Boyd

Sparse rightly complains that this symbol is supposed to be static.

Cc Jian Hu <[email protected]>
Cc Dmitry Rokosov <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Jerome Brunet <[email protected]>
Fixes 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")

Thanks for providing a fix so quickly!

Jerome, I think it's easiest for Stephen to apply this patch directly to the clock tree.
In my opinion there's no reason against this since our own patch queue is empty.

Best regards,
Martin

author maintainer Applied
#3 lore raw
In reply to Stephen Boyd

Quoting Stephen Boyd (2023-06-12 11:23:32)

Quoted 9 lines

Sparse rightly complains that this symbol is supposed to be static.

Cc Jian Hu <[email protected]>
Cc Dmitry Rokosov <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Jerome Brunet <[email protected]>
Fixes 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")

---

Applied to clk-next