Skip to contentSkip to conversation

drm/amdkfd: Remove DUMMY_VRAM_SIZE

PATCH In review Mukul Joshi 2 participants 2 messages Jun 12, 2023 – Jun 13, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Remove DUMMY_VRAM_SIZE

Remove DUMMY_VRAM_SIZE as it is not needed and can result in reporting incorrect memory size.

---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +0 -5
index 3dcd8f8bc98e..49f40d9f16e8 100644
@@ -30,9 +30,6 @@
 #include "amdgpu.h"
 #include "amdgpu_amdkfd.h"
 
-/* Fixme: Fake 32GB for 1PNPS1 mode bringup */
-#define DUMMY_VRAM_SIZE 31138512896
-
 /* GPU Processor ID base for dGPUs for which VCRAT needs to be created.
  * GPU processor ID are expressed with Bit[31]=1.
  * The base is set to 0x8000_0000 + 0x1000 to avoid collision with GPU IDs
@@ -1056,8 +1053,6 @@ static int kfd_parse_subtype_mem(struct crat_subtype_memory *mem,
 
 			props->heap_type = heap_type;
 			props->flags = flags;
-			if (size_in_bytes == 0)
-				size_in_bytes = DUMMY_VRAM_SIZE; /* Fixme: TBD */
 			props->size_in_bytes = size_in_bytes;
 			props->width = width;
 
Signature · 1 line
2.35.1
maintainer Acked-by on v1 1/1
#1 lore raw

[Public]

________________________________
From: amd-gfx <[email protected]> on behalf of Mukul Joshi <[email protected]>
Sent: Monday, June 12, 2023 7:06 PM
To: [email protected] <[email protected]>
Cc: Joshi, Mukul <[email protected]>; Kuehling, Felix <[email protected]>
Subject: [PATCH] drm/amdkfd: Remove DUMMY_VRAM_SIZE

Remove DUMMY_VRAM_SIZE as it is not needed and can result in reporting incorrect memory size.

---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_crat.c +0 -5
index 3dcd8f8bc98e..49f40d9f16e8 100644
@@ -30,9 +30,6 @@
 #include "amdgpu.h"
 #include "amdgpu_amdkfd.h"
 
-/* Fixme: Fake 32GB for 1PNPS1 mode bringup */
-#define DUMMY_VRAM_SIZE 31138512896
-
 /* GPU Processor ID base for dGPUs for which VCRAT needs to be created.
  * GPU processor ID are expressed with Bit[31]=1.
  * The base is set to 0x8000_0000 + 0x1000 to avoid collision with GPU IDs
@@ -1056,8 +1053,6 @@ static int kfd_parse_subtype_mem(struct crat_subtype_memory *mem,
 
                         props->heap_type = heap_type;
                         props->flags = flags;
-                       if (size_in_bytes == 0)
-                               size_in_bytes = DUMMY_VRAM_SIZE; /* Fixme: TBD */
                         props->size_in_bytes = size_in_bytes;
                         props->width = width;
 

--
2.35.1