Skip to contentSkip to conversation

firmware: stratix10-svc: Fix a potential resource leak in svc_create_memory_pool()

PATCH New Dinh Nguyen 1 participant 1 message Jun 13, 2023

Subsystems (2)
Stable branch Intel STRATIX10 firmware drivers
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 firmware: stratix10-svc: Fix a potential resource leak in svc_create_memory_pool()

From: Christophe JAILLET <[email protected]>

svc_create_memory_pool() is only called from stratix10_svc_drv_probe(). Most of resources in the probe are managed, but not this memremap() call.

There is also no memunmap() call in the file.

So switch to devm_memremap() to avoid a resource leak.

Cc [email protected]
Fixes 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Link https://lore.kernel.org/all/783e9dfbba34e28505c9efa8bba41f97fd0fa1dc.1686109400.git.christophe.jaillet@wanadoo.fr/ open here
Signed-off-by Christophe JAILLET <[email protected]>
Signed-off-by Dinh Nguyen <[email protected]>
---
 drivers/firmware/stratix10-svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/stratix10-svc.c +1 -1
index 80f4e2d14e04..2d674126160f 100644
@@ -755,7 +755,7 @@ svc_create_memory_pool(struct platform_device *pdev,
 	end = rounddown(sh_memory->addr + sh_memory->size, PAGE_SIZE);
 	paddr = begin;
 	size = end - begin;
-	va = memremap(paddr, size, MEMREMAP_WC);
+	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
 	if (!va) {
 		dev_err(dev, "fail to remap shared memory\n");
 		return ERR_PTR(-EINVAL);
Signature · 1 line
2.25.1