lpfc: Fix incorrect big endian type assignment in bsg loopback path
Subsystems (2)
PATCH 1/1 lpfc: Fix incorrect big endian type assignment in bsg loopback path
The kernel test robot reported sparse warnings regarding incorrect type assignment for __be16 variables in bsg loopback path.
Change the flagged lines to use the be16_to_cpu and cpu_to_be16 macros appropriately.
Signed-off-by Justin Tee <[email protected]>
Reported-by kernel test robot <[email protected]>
--- drivers/scsi/lpfc/lpfc_bsg.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/lpfc/lpfc_bsg.c +4 -4
@@ -889,7 +889,7 @@ lpfc_bsg_ct_unsol_event(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, struct lpfc_iocbq *piocbq) {uint32_t evt_req_id =0 ; -uint32_t cmd; +u16 cmd;struct lpfc_dmabuf *dmabuf =NULL ;struct lpfc_bsg_event *evt;struct event_data *evt_dat =NULL ;
@@ -915,7 +915,7 @@ lpfc_bsg_ct_unsol_event(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, ct_req = (struct lpfc_sli_ct_request *)bdeBuf1->virt; evt_req_id = ct_req->FsType; - cmd = ct_req->CommandResponse.bits.CmdRsp; + cmd =be16_to_cpu (ct_req->CommandResponse.bits.CmdRsp);spin_lock_irqsave (&phba->ct_ev_lock, flags);list_for_each_entry (evt, &phba->ct_ev_waiters, node) {
@@ -3186,8 +3186,8 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job) ctreq->RevisionId.bits.InId =0 ; ctreq->FsType =SLI_CT_ELX_LOOPBACK ; ctreq->FsSubType =0 ; - ctreq->CommandResponse.bits.CmdRsp =ELX_LOOPBACK_DATA ; - ctreq->CommandResponse.bits.Size = size; + ctreq->CommandResponse.bits.CmdRsp =cpu_to_be16 (ELX_LOOPBACK_DATA ); + ctreq->CommandResponse.bits.Size =cpu_to_be16 (size); segment_offset =ELX_LOOPBACK_HEADER_SZ ; }else segment_offset =0 ;
Signature · 1 line
2.38.0
Martin K. Petersen
AppliedQuoted 8 lines · Justin Tee
The kernel test robot reported sparse warnings regarding incorrect type assignment for
__be16variables in bsg loopback path.Change the flagged lines to use the
be16_to_cpuandcpu_to_be16macros appropriately.[...]
Applied to 6.4/scsi-fixes, thanks!
[1/1] lpfc: Fix incorrect big endian type assignment in bsg loopback path
https://git.kernel.org/mkp/scsi/c/9cefd6e7e0a7
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering