Skip to contentSkip to conversation

drm/i915/display/lspcon: Increase LSPCON mode settle timeout

PATCH Superseded Pablo Ceballos 3 participants 5 messages Jun 14, 2023 – Jul 10, 2023

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915/display/lspcon: Increase LSPCON mode settle timeout

This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", followed by link training errors. Intel engineers recommended increasing this timeout and that does resolve the issue.

On some CometLake-based device designs the Parade PS175 takes more than 400ms to settle in PCON mode. 100 reboot trials on one device resulted in a median settle time of 440ms and a maximum of 444ms. Even after increasing the timeout to 500ms, 2% of devices still had this error. So this increases the timeout to 800ms.

---

Changelog since v1:
- Added more details in the commit message

 drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_lspcon.c +1 -1
index bb3b5355a0d9..d7299fdc43ad 100644
@@ -167,7 +167,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
 	drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
 		    lspcon_mode_name(mode));
 
-	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
+	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
 	if (current_mode != mode)
 		drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
 
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
#1 lore raw
Quoted 9 lines · Pablo Ceballos

This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", followed by link training errors. Intel engineers recommended increasing this timeout and that does resolve the issue.

On some CometLake-based device designs the Parade PS175 takes more than 400ms to settle in PCON mode. 100 reboot trials on one device resulted in a median settle time of 440ms and a maximum of 444ms. Even after increasing the timeout to 500ms, 2% of devices still had this error. So this increases the timeout to 800ms.

In one of the gitlab issue, it was tried with 1000ms as well, situation did improve, but issue didn't get fully resolved. [1].

I was wondering if trying to set LS/PCON mode multiple time will have any effect.

Unfortunately I do not have access to machine with Parade LSPCON chip, had suggested in yet another git lab issue [2].

I have a patch for this, sent to try-bot, though not sent to intel-gfx yet [3].

The timeout value was already increased from 100 ms to 400 ms earlier too.

If there is indeed no other way, perhaps need to have this solution.

[1] https://gitlab.freedesktop.org/drm/intel/-/issues/4516#note_1406500

[2] https://gitlab.freedesktop.org/drm/intel/-/issues/4458#note_1922654

[3] Patch : https://patchwork.freedesktop.org/patch/538819/?series=118208&rev=1

Regards,

Ankit

Quoted 23 lines

---

Changelog since v1:
- Added more details in the commit message

  drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_lspcon.c +1 -1
index bb3b5355a0d9..d7299fdc43ad 100644
@@ -167,7 +167,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
  	drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
  		    lspcon_mode_name(mode));
 
-	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
+	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
  	if (current_mode != mode)
  		drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
 
#2 lore raw
Quoted 8 lines · Ankit K

I was wondering if trying to set LS/PCON mode multiple time will have any effect.

Unfortunately I do not have access to machine with Parade LSPCON chip, had suggested in yet another git lab issue [2].

I have a patch for this, sent to try-bot, though not sent to intel-gfx yet [3].

I tested this patch and it did not resolve the problem. The error log was repeated multiple times and there were still link training issues afterwards.

Quoted 3 lines

The timeout value was already increased from 100 ms to 400 ms earlier too.

If there is indeed no other way, perhaps need to have this solution.

Yes, can this please be merged?

Regards,
Pablo

#3 lore raw
Quoted 5 lines · Pablo Ceballos
Quoted 3 lines · Ankit K

I was wondering if trying to set LS/PCON mode multiple time will have any effect.

Quoted 8 lines
Quoted 5 lines

Unfortunately I do not have access to machine with Parade LSPCON chip, had suggested in yet another git lab issue [2].

I have a patch for this, sent to try-bot, though not sent to intel-gfx yet [3].

I tested this patch and it did not resolve the problem. The error log was repeated multiple times and there were still link training issues afterwards.

Really appreciate to try this thing out, thanks. Too bad it didn't workout :(

I have seen increasing timeout does improves situation, but didn't have enough data points to come to a timeout value.

I agree with the change based on the experiments and data you have shared.

Lets just change the timeout to 800 ms when the lspcon->vendor is LSPCON_VENDOR_PARADE, so that it doesn't have any effect on platforms that don't have this.

IMHO a function to get timeout value based on lspcon vendor will be better (returns 800 ms for Parade, 400 otherwise.)

In the function itself, we can have the explanation of arriving at 800 ms for the Parade chip (as given in the commit message) as a comment.

Thanks again for trying different solutions.

Regards,

Ankit

Quoted 7 lines
Quoted 3 lines

The timeout value was already increased from 100 ms to 400 ms earlier too.

If there is indeed no other way, perhaps need to have this solution.

Yes, can this please be merged?

Regards,
Pablo

#4 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev3)

In reply to Pablo Ceballos
== Series Details ==

== Series Details ==

Series: drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev3)
URL : https://patchwork.freedesktop.org/series/108735/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13270 -> Patchwork_108735v3
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_108735v3 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_108735v3, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/index.html

Participating hosts (43 -> 40)
------------------------------

Missing (3): fi-kbl-soraka bat-rpls-2 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_108735v3:

### IGT changes ###

#### Possible regressions ####

* igt@i915_pm_rpm@basic-rte:
- bat-mtlp-8: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-mtlp-8/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_108735v3 that come from known issues:

### CI changes ###

#### Issues hit ####

* boot:
- fi-bsw-nick: [PASS][3] -> [FAIL][4] ([i915#8293])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/fi-bsw-nick/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/fi-bsw-nick/boot.html

### IGT changes ###

#### Issues hit ####

* igt@core_auth@basic-auth:
- bat-adlp-11: NOTRUN -> [ABORT][5] ([i915#8011])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-adlp-11/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- bat-rpls-1: [PASS][6] -> [INCOMPLETE][7] ([i915#4983])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-rpls-1/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][8] -> [DMESG-WARN][9] ([i915#7699])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-dg2-11/igt@i915_selftest@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-mtlp-6: [PASS][10] -> [DMESG-FAIL][11] ([i915#6763])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-6/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-mtlp-6/igt@i915_selftest@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg2-11: NOTRUN -> [SKIP][12] ([i915#7828])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-dg2-11/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
- bat-dg2-8: [PASS][13] -> [FAIL][14] ([i915#7932])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][15] ([i915#7059]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [ABORT][17] ([i915#7913] / [i915#7979]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-dg2-11/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][19] ([i915#6367]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-mtlp-6/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-mtlp-6/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][21] ([i915#4423]) -> [DMESG-WARN][22] ([i915#4423])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13270/bat-adlp-11/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/bat-adlp-11/igt@[email protected]

[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6763]: https://gitlab.freedesktop.org/drm/intel/issues/6763
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293

Build changes
-------------

* Linux: CI_DRM_13270 -> Patchwork_108735v3

CI-20190529: 20190529
CI_DRM_13270: a8b181a60198ccf04a1ad1c34f46be4c2a5e64b7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7329: d58b208c72b91a5d9cb7877363242a181a012182 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108735v3: a8b181a60198ccf04a1ad1c34f46be4c2a5e64b7 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

d65ca8aed551 drm/i915/display/lspcon: Increase LSPCON mode settle timeout

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108735v3/index.html