hugeshmctl02: Skipped EFAULT tests for libc variant
PATCH 1/1 hugeshmctl02: Skipped EFAULT tests for libc variant
When testing hugeshmctl02 under the 32bit architecture, a segmentation fault will occur. This patch will skip EFAULT tests for libc variant.
Hugeshmctl02 will intentionally pass "(struct shmid_ds *)-1" to shmctl(), but glibc will perform an additional conversion function when the architecture is 32bit, which will try to copy all items in (struct shmid_ds *) to another structure[*1]. In the process of copying, it is necessary to dereference "(struct shmid_ds *)-1", resulting in segmentation fault.
The LTP also has similar problems before, this patch is reference from the shmctl03 patch[*2].
[*1]: https://github.com/bminor/glibc/blob/master/sysdeps/unix/sysv/linux/shmctl.c#L37
[*2]: https://github.com/linux-test-project/ltp/commit/a5a80aa8485a7cb017f96aba8d7b5ea79f1ba4d4
--- .../mem/hugetlb/hugeshmctl/hugeshmctl02.c | 35 ++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +34 -1
@@ -27,6 +27,7 @@#include <pwd.h> #include <limits.h> #include "hugetlb.h" +#include "lapi/syscalls.h" static size_t shm_size;static int shm_id_1 =-1 ;
@@ -50,9 +51,37 @@ struct tcase { {&shm_id_2, -1, &buf, EINVAL}, }; +static int libc_shmctl (int shmid,int cmd,void *buf) +{ +return shmctl (shmid, cmd, buf); +} + +static int sys_shmctl (int shmid,int cmd,void *buf) +{ +return tst_syscall (__NR_shmctl, shmid, cmd, buf); +} + +static struct test_variants +{ +int (*shmctl)(int shmid,int cmd,void *buf); +char *desc; +} variants[] = { + { .shmctl = libc_shmctl, .desc ="libc shmctl()" }, +#if (__NR_shmctl != __LTP__NR_INVALID_SYSCALL) + { .shmctl = sys_shmctl, .desc ="__NR_shmctl syscall" }, +#endif +}; +static void test_hugeshmctl (unsigned int i) { -TEST (shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf)); +struct test_variants *tv = &variants[tst_variant]; + +if (tcases[i].error ==EFAULT && tv->shmctl == libc_shmctl) { +tst_res (TCONF ,"EFAULT is skipped for libc variant" ); +return ; + } + +TEST (tv->shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf));if (TST_RET !=-1 ) {tst_res (TFAIL ,"shmctl succeeded unexpectedly" );return ;
@@ -70,8 +99,11 @@ static void test_hugeshmctl(unsigned int i)static void setup (void ) { +struct test_variants *tv = &variants[tst_variant];long hpage_size; +tst_res (TINFO ,"Testing variant: %s" , tv->desc); +if (tst_hugepages ==0 )tst_brk (TCONF ,"No enough hugepages for testing." );
@@ -101,6 +133,7 @@ static void cleanup(void)static struct tst_test test = { .test = test_hugeshmctl, + .test_variants =ARRAY_SIZE (variants), .tcnt =ARRAY_SIZE (tcases), .needs_root =1 , .needs_tmpdir =1 ,
Signature · 5 lines
2.34.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi All,
Ping. Any comments on this patch?
Thanks,
Dylan
-----Original Message-----
From: Dylan Dai-Rong Jhong(鍾岱融) <[email protected]>
Sent: Thursday, June 15, 2023 5:40 PM
To: [email protected]
Cc: Randolph Sheng-Kai Lin(林聖凱) <[email protected]>; [email protected]; Tim Shih-Ting OuYang(歐陽士庭) <[email protected]>; Mina Hui-Min Chou(周慧敏) <[email protected]>; Dylan Dai-Rong Jhong(鍾岱融) <[email protected]>
Subject: [LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant
When testing hugeshmctl02 under the 32bit architecture, a segmentation fault will occur. This patch will skip EFAULT tests for libc variant.
Hugeshmctl02 will intentionally pass "(struct shmid_ds *)-1" to shmctl(), but glibc will perform an additional conversion function when the architecture is 32bit, which will try to copy all items in (struct shmid_ds *) to another structure[*1]. In the process of copying, it is necessary to dereference "(struct shmid_ds *)-1", resulting in segmentation fault.
The LTP also has similar problems before, this patch is reference from the shmctl03 patch[*2].
[*1]: https://github.com/bminor/glibc/blob/master/sysdeps/unix/sysv/linux/shmctl.c#L37
[*2]: https://github.com/linux-test-project/ltp/commit/a5a80aa8485a7cb017f96aba8d7b5ea79f1ba4d4
--- .../mem/hugetlb/hugeshmctl/hugeshmctl02.c | 35 ++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +29 -1
@@ -27,6 +27,7 @@#include <pwd.h> #include <limits.h> #include "hugetlb.h" +#include "lapi/syscalls.h" static size_t shm_size;static int shm_id_1 =-1 ;
@@ -50,9 +51,37 @@ struct tcase { {&shm_id_2, -1, &buf, EINVAL}, }; +static int libc_shmctl (int shmid,int cmd,void *buf) { +return shmctl (shmid, cmd, buf); +} + +static int sys_shmctl (int shmid,int cmd,void *buf) { +return tst_syscall (__NR_shmctl, shmid, cmd, buf); } + +static struct test_variants +{ +int (*shmctl)(int shmid,int cmd,void *buf); +char *desc; +} variants[] = { + { .shmctl = libc_shmctl, .desc = "libc shmctl()"}, #if (__NR_shmctl != +__LTP__NR_INVALID_SYSCALL) + { .shmctl = sys_shmctl, .desc = "__NR_shmctl syscall"}, #endif }; +static void test_hugeshmctl (unsigned int i) { -TEST (shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf)); +struct test_variants *tv = &variants[tst_variant]; + +if (tcases[i].error ==EFAULT && tv->shmctl == libc_shmctl) { +tst_res (TCONF ,"EFAULT is skipped for libc variant" ); +return ; + } + +TEST (tv->shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf));if (TST_RET !=-1 ) {tst_res (TFAIL ,"shmctl succeeded unexpectedly" );return ;
@@ -70,8 +99,11 @@ static void test_hugeshmctl(unsigned int i)static void setup (void ) { +struct test_variants *tv = &variants[tst_variant];long hpage_size; +tst_res (TINFO ,"Testing variant: %s" , tv->desc); +if (tst_hugepages ==0 )tst_brk (TCONF ,"No enough hugepages for testing." );
@@ -101,6 +133,7 @@ static void cleanup(void)static struct tst_test test = { .test = test_hugeshmctl, + .test_variants =ARRAY_SIZE (variants), .tcnt =ARRAY_SIZE (tcases), .needs_root =1 , .needs_tmpdir =1 ,
--
2.34.1
CONFIDENTIALITY NOTICE:
This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.
Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 60 lines · Dylan Jhong
When testing hugeshmctl02 under the 32bit architecture, a segmentation fault
will occur. This patch will skip EFAULT tests for libc variant.Hugeshmctl02 will intentionally pass "(struct
shmid_ds*)-1" toshmctl(), but
glibc will perform an additional conversion function when the architecture is
32bit, which will try to copy all items in (structshmid_ds*) to another structure[*1]. In the process of copying, it is necessary to dereference "(structshmid_ds*)-1", resulting in segmentation fault.The LTP also has similar problems before, this patch is reference from the shmctl03 patch[*2].
[*1]:
https://github.com/bminor/glibc/blob/master/sysdeps/unix/sysv/linux/shmctl.c#L37
[*2]:
https://github.com/linux-test-project/ltp/commit/a5a80aa8485a7cb017f96aba8d7b5ea79f1ba4d4Signed-off-by Dylan Jhong <[email protected]>--- .../mem/hugetlb/hugeshmctl/hugeshmctl02.c | 35 ++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +19
-0@@ -27,6 +27,7 @@#include <pwd.h> #include <limits.h> #include "hugetlb.h" +#include "lapi/syscalls.h" static size_t shm_size;static int shm_id_1 =-1 ;@@ -50,9 +51,37 @@ struct tcase { {&shm_id_2, -1, &buf, EINVAL}, }; +static int libc_shmctl (int shmid,int cmd,void *buf) +{ +return shmctl (shmid, cmd, buf); +} + +static int sys_shmctl (int shmid,int cmd,void *buf) +{ +return tst_syscall (__NR_shmctl, shmid, cmd, buf); +} + +static struct test_variants +{ +int (*shmctl)(int shmid,int cmd,void *buf); +char *desc; +} variants[] = { + { .shmctl = libc_shmctl, .desc ="libc shmctl()" }, +#if (__NR_shmctl != __LTP__NR_INVALID_SYSCALL) + { .shmctl = sys_shmctl, .desc = "__NR_shmctl syscall"},
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c struct tcase { · line 80
Quoted 10 lines
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +6
-1+#endif +}; +static void test_hugeshmctl (unsigned int i) { -TEST (shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf)); +struct test_variants *tv = &variants[tst_variant]; + +if (tcases[i].error ==EFAULT && tv->shmctl == libc_shmctl) {
You pointed the segment fault only exists on 32bit when use libc wrapper, but this condition skips for both 64and32 bits, isn't it?
I guess the strict condition should be as below?
if (tcases[i].error == EFAULT && tv->shmctl == libc_shmctl &&
tst_kernel_bits() == 32) {
...
}Quoted 37 lines
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +5
-0+tst_res (TCONF ,"EFAULT is skipped for libc variant" ); +return ; + } + +TEST (tv->shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf));if (TST_RET !=-1 ) {tst_res(TFAIL, "shmctl succeeded unexpectedly"); return;testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +4
-1@@ -70,8 +99,11 @@ static void test_hugeshmctl(unsigned int i)static void setup (void ) { +struct test_variants *tv = &variants[tst_variant];long hpage_size; +tst_res (TINFO ,"Testing variant: %s" , tv->desc); +if (tst_hugepages ==0 )tst_brk (TCONF ,"No enough hugepages for testing." );@@ -101,6 +133,7 @@ static void cleanup(void)static struct tst_test test = { .test = test_hugeshmctl, + .test_variants =ARRAY_SIZE (variants), .tcnt =ARRAY_SIZE (tcases), .needs_root =1 , .needs_tmpdir =1 , --2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Li Wang,
Thanks for the review.
Please ignore my email I just replied to you, I forgot to click “reply all”. Please consider this email the primary email.
From: Li Wang <[email protected]>
Sent: Monday, June 26, 2023 2:57 PM
To: Dylan Dai-Rong Jhong(鍾岱融) <[email protected]>
Cc: [email protected]; Mina Hui-Min Chou(周慧敏) <[email protected]>; Tim Shih-Ting OuYang(歐陽士庭) <[email protected]>; [email protected]; Cyril Hrubis <[email protected]>
Subject: Re: [LTP] [PATCH] hugeshmctl02: Skipped EFAULT tests for libc variant
On Thu, Jun 15, 2023 at 5:40 PM Dylan Jhong <[email protected]<mailto:[email protected]>> wrote:
When testing hugeshmctl02 under the 32bit architecture, a segmentation fault
will occur. This patch will skip EFAULT tests for libc variant.
Hugeshmctl02 will intentionally pass "(struct shmid_ds *)-1" to shmctl(), but glibc will perform an additional conversion function when the architecture is 32bit, which will try to copy all items in (struct shmid_ds *) to another structure[*1]. In the process of copying, it is necessary to dereference "(struct shmid_ds *)-1", resulting in segmentation fault.
The LTP also has similar problems before, this patch is reference from the shmctl03 patch[*2].
[*1]: https://github.com/bminor/glibc/blob/master/sysdeps/unix/sysv/linux/shmctl.c#L37
[*2]: https://github.com/linux-test-project/ltp/commit/a5a80aa8485a7cb017f96aba8d7b5ea79f1ba4d4
--- .../mem/hugetlb/hugeshmctl/hugeshmctl02.c | 35 ++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl02.c +25 -1
@@ -27,6 +27,7 @@#include <pwd.h> #include <limits.h> #include "hugetlb.h" +#include "lapi/syscalls.h" static size_t shm_size;static int shm_id_1 =-1 ;
@@ -50,9 +51,37 @@ struct tcase { {&shm_id_2, -1, &buf, EINVAL}, }; +static int libc_shmctl (int shmid,int cmd,void *buf) +{ +return shmctl (shmid, cmd, buf); +} + +static int sys_shmctl (int shmid,int cmd,void *buf) +{ +return tst_syscall (__NR_shmctl, shmid, cmd, buf); +} + +static struct test_variants +{ +int (*shmctl)(int shmid,int cmd,void *buf); +char *desc; +} variants[] = { + { .shmctl = libc_shmctl, .desc ="libc shmctl()" }, +#if (__NR_shmctl != __LTP__NR_INVALID_SYSCALL) + { .shmctl = sys_shmctl, .desc ="__NR_shmctl syscall" }, +#endif +}; +static void test_hugeshmctl (unsigned int i) { -TEST (shmctl (*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf)); +struct test_variants *tv = &variants[tst_variant]; + +if (tcases[i].error ==EFAULT && tv->shmctl == libc_shmctl) {
You pointed the segment fault only exists on 32bit when use libc wrapper, but this condition skips for both 64and32 bits, isn't it?
I guess the strict condition should be as below?
if (tcases[i].error == EFAULT && tv->shmctl == libc_shmctl && tst_kernel_bits() == 32) {
...
}Indeed, this only happens on 32-bit architectures, so the condition you added is no problem.
But in other LTP test cases, this condition is not considered on both 32/64 bit.
For example:
- msgctl04: https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/ipc/msgctl/msgctl04.c#L74
- semctl04: https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/ipc/semctl/semctl03.c#L78
- sched_rr_get_interval03.c: https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/syscalls/sched_rr_get_interval/sched_rr_get_interval03.c#L71
Not sure if the original developers didn't think of this or LTP just wanted to ignore this condition.
Do you think the condition needs to be modified to only ignore 32 bits, or designed to be the same as the other LTP test cases so that 32/64 bits are ignored?
Thanks,
Dylan
+ tst_res(TCONF, "EFAULT is skipped for libc variant");
+ return;
+ }
+
+ TEST(tv->shmctl(*(tcases[i].shmid), tcases[i].cmd, tcases[i].sbuf));
if (TST_RET != -1) {
tst_res(TFAIL, "shmctl succeeded unexpectedly");
return;@@ -70,8 +99,11 @@ static void test_hugeshmctl(unsigned int i)
static void setup(void)
{
+ struct test_variants *tv = &variants[tst_variant];
long hpage_size;+ tst_res(TINFO, "Testing variant: %s", tv->desc);
+
if (tst_hugepages == 0)
tst_brk(TCONF, "No enough hugepages for testing.");@@ -101,6 +133,7 @@ static void cleanup(void)
static struct tst_test test = {
.test = test_hugeshmctl,
+ .test_variants = ARRAY_SIZE(variants),
.tcnt = ARRAY_SIZE(tcases),
.needs_root = 1,
.needs_tmpdir = 1,--
2.34.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
--
Regards,
Li Wang
CONFIDENTIALITY NOTICE:
This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.
Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 10 lines
You pointed the segment fault only exists on 32bit when use libc wrapper, but this condition skips for both 64and32 bits, isn't it?
I guess the strict condition should be as below?
if (tcases[i].error == EFAULT && tv->shmctl == libc_shmctl && tst_kernel_bits() == 32) { ... }
Actually I think that it may be safer to skip libc version regardless, as long as we have the raw syscall test in place we are not getting any more coverage from passing invalid address to the libc call, since either the libc call is thin wrapper, i.e. equivalent to the syscall() call which we already test, or it does something to the arguments, in which case it's possible to trigger segfault, if not now in some future libc versions.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 12 lines · Cyril Hrubis
Hi!
Quoted 10 lines
You pointed the segment fault only exists on 32bit when use libc wrapper, but this condition skips for both 64and32 bits, isn't it?
I guess the strict condition should be as below?
if (tcases[i].error == EFAULT && tv->shmctl == libc_shmctl && tst_kernel_bits() == 32) { ... }
Quoted 8 lines
Actually I think that it may be safer to skip libc version regardless, as long as we have the raw syscall test in place we are not getting any more coverage from passing invalid address to the libc call, since either the libc call is thin wrapper, i.e. equivalent to the
syscall()call which we already test, or it does something to the arguments, in which case it's possible to trigger segfault, if not now in some future libc versions.
Okay, sounds reasonable. I agree with this.
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
Quoted 14 lines · Cyril Hrubis
Quoted 12 lines
Hi!
Quoted 10 lines
You pointed the segment fault only exists on 32bit when use libc wrapper, but this condition skips for both 64and32 bits, isn't it?
I guess the strict condition should be as below?
if (tcases[i].error == EFAULT && tv->shmctl == libc_shmctl && tst_kernel_bits() == 32) { ... }
Quoted 7 lines
Quoted 7 lines
Actually I think that it may be safer to skip libc version regardless, as long as we have the raw syscall test in place we are not getting any more coverage from passing invalid address to the libc call, since either the libc call is thin wrapper, i.e. equivalent to the
syscall()call which we already test, or it does something to the arguments, in which case it's possible to trigger segfault, if not now in some future libc versions.
Good to know. Because at least of some of the tests modified by Vinay Kumar (which Dylan is referring) aren't able to run on 32bit libc if we skip with && tst_kernel_bits() == 32, e.g.
./msgctl04
tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s msgctl04.c:103: TINFO: Testing variant: libc msgctl() msgctl04.c:79: TPASS: msgctl(32816, 2, 0x565e4700) : EACCES (13) tst_kernel.c:87: TINFO: uname.machine=x86_64 kernel is 64bit tst_test.c:1618: TBROK: Test killed by SIGSEGV!
Quoted 1 line
Okay, sounds reasonable. I agree with this.
BTW I also get ENOMEM on my laptop (currently 1G free space):
hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)
Should we handle it somehow?
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 6 lines
Quoted 1 line
Okay, sounds reasonable. I agree with this.
BTW I also get ENOMEM on my laptop (currently 1G free space):
hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)Should we handle it somehow?
The line 119 looks suspicions, in latest git the hugeshmctl02.c does not even have 119 lines.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Petr Vorel
Reviewed-byHi All,
LGTM.
Quoted 10 lines
Hi!
Quoted 6 lines
Quoted 1 line
Okay, sounds reasonable. I agree with this.
BTW I also get ENOMEM on my laptop (currently 1G free space):
hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)Should we handle it somehow?
The line 119 looks suspicions, in latest git the
hugeshmctl02.cdoes not even have 119 lines.
Well, it occurred with this patch (file has with it 147 lines). Previously the version from master worked, but now it also reports ENOMEM even on master:
hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12)
(therefore not this patch specific). Should we use .min_mem_avail? (not sure which value).
nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant". "Skipped" => "Skip" (we use imperative mood).
IMHO more important is the fact, that test variant was added, that's what I'd mention in the subject. Of course, I'd keep in the commit message body that libc variant was skipped.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi All,
Thanks for reviewing this patch.
Quoted 10 lines
Hi All,
Reviewed-by Petr Vorel <[email protected]> LGTM.Quoted 5 lines
Hi!
Quoted 4 lines
Quoted 1 line
Okay, sounds reasonable. I agree with this.
BTW I also get ENOMEM on my laptop (currently 1G free space):
hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Should we handle it somehow?
The line 119 looks suspicions, in latest git the
hugeshmctl02.cdoes not even have 119 lines.Well, it occurred with this patch (file has with it 147 lines). Previously the version from master worked, but now it also reports ENOMEM even on master:
hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12) (therefore not this patch specific). Should we use .min_mem_avail? (not sure which value).
This patch only adds a set of test variants, and does not modify the content of the test items. I think this error should have nothing to do with this patch, maybe another patch can be sent to solve the "ENOMEM" problem.
Quoted 3 lines
nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant".
"Skipped" => "Skip" (we use imperative mood).
IMHO more important is the fact, that test variant was added, that's what I'd mention in the subject. Of course, I'd keep in the commit message body that libc variant was skipped.
Thanks for the correction. Do I have to submit a V2 patch to fix the title?
Quoted 2 lines
Kind regards,
Petr
CONFIDENTIALITY NOTICE:
This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.
Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi All,
Any update on this patch?
Best,
Dylan
Quoted 21 lines
Hi All,
Thanks for reviewing this patch.
Quoted 10 lines
Hi All,
Reviewed-by Petr Vorel <[email protected]> LGTM.Quoted 5 lines
Hi!
Quoted 4 lines
Quoted 1 line
Okay, sounds reasonable. I agree with this.
BTW I also get ENOMEM on my laptop (currently 1G free space):
hugeshmctl02.c:119: TBROK: shmget #1: ENOMEM (12)Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Should we handle it somehow?
The line 119 looks suspicions, in latest git the
hugeshmctl02.cdoes not even have 119 lines.Well, it occurred with this patch (file has with it 147 lines). Previously the version from master worked, but now it also reports ENOMEM even on master:
hugeshmctl02.c:87: TBROK: shmget #1: ENOMEM (12) (therefore not this patch specific). Should we use .min_mem_avail? (not sure which value).
Quoted 10 lines
This patch only adds a set of test variants, and does not modify the content of the test items. I think this error should have nothing to do with this patch, maybe another patch can be sent to solve the "ENOMEM" problem.
Quoted 3 lines
nit: The patch subject is "hugeshmctl02: Skipped EFAULT tests for libc variant".
"Skipped" => "Skip" (we use imperative mood).
IMHO more important is the fact, that test variant was added, that's what I'd mention in the subject. Of course, I'd keep in the commit message body that libc variant was skipped.Thanks for the correction. Do I have to submit a V2 patch to fix the title?
Quoted 2 lines
Kind regards,
Petr
CONFIDENTIALITY NOTICE:
This e-mail (and its attachments) may contain confidential and legally privileged information or information protected from disclosure. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein is strictly prohibited. In this case, please immediately notify the sender by return e-mail, delete the message (and any accompanying documents) and destroy all printed hard copies. Thank you for your cooperation.
Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Dylan,
patch merged, thanks!
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp