btrfs: update i_version in update_dev_time
PATCH 1/1 btrfs: update i_version in update_dev_time
When updating the ctime, we also want to update i_version.
--- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
This is just something I noticed by inspection. There is probably no way to test this today unless you can somehow get to this inode via nfsd. Still, I think it's the right thing to do for consistency's sake.
fs/btrfs/volumes.c +1 -1
@@ -1918,7 +1918,7 @@ static void update_dev_time(const char *device_path)return ; now =current_time (d_inode (path.dentry)); -inode_update_time (d_inode (path.dentry), &now,S_MTIME |S_CTIME ); +inode_update_time (d_inode (path.dentry), &now,S_MTIME |S_CTIME |S_VERSION );path_put (&path); }
Signature · 1 line
2.40.1
Quoted 10 lines · Jeff Layton
When updating the ctime, we also want to update
i_version.Signed-off-by Jeff Layton <[email protected]>--- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)This is just something I noticed by inspection. There is probably no way to test this today unless you can somehow get to this inode via nfsd. Still, I think it's the right thing to do for consistency's sake.
I don't see anything wrong with setting the iversion bit, however I also don't see where this would be useful. Agreed with the consistency, otherwise the time is updated when device super block is wiped or a device initialized, both are big events so missing that due to lack of iversion update seems unlikely. I'll add it to the queue, thanks.