Skip to contentSkip to conversation

iommu/vt-d: Fix to flush cache of PASID directory table

PATCH New Yanfei Xu 1 participant 1 message Jun 16, 2023

Subsystems (2)
lore
Share & tools
lore

Yanfei Xu

author
#0 lore raw

PATCH v2 1/1 iommu/vt-d: Fix to flush cache of PASID directory table

Even the PCI devices don't support pasid capability, PASID table is mandatory for a PCI device in scalable mode. However flushing cache of pasid directory table for these devices are not taken after pasid table is allocated as the "size" of table is zero. Fix it by calculating the size by page order.

Found this when reading the code, no actual problem encountered for now

Fixes 194b3348bdbb ("iommu/vt-d: Fix PASID directory pointer coherency")

---
v1->v2:
use variable "order" to calculate the table size (Suggested by baolu)

 drivers/iommu/intel/pasid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel/pasid.c +1 -1
index c5d479770e12..49fc5a038a14 100644
@@ -129,7 +129,7 @@ int intel_pasid_alloc_table(struct device *dev)
 	info->pasid_table = pasid_table;
 
 	if (!ecap_coherent(info->iommu->ecap))
-		clflush_cache_range(pasid_table->table, size);
+		clflush_cache_range(pasid_table->table, (1 << order) * PAGE_SIZE);
 
 	return 0;
 }
Signature · 1 line
2.34.1