Skip to contentSkip to conversation

arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

PATCH Superseded Josua Mayer 3 participants 13 messages Jun 16, 2023 – Jun 17, 2023

Subsystems (2)

v1 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#1 lore raw

PATCH 1/3 arm64: dts: lx2160a: describe the SerDes block #2

In reply to Josua Mayer

Add description for the LX2160A second SerDes block. It is functionally identical to the first one already added in:

3cbe93a "arch: arm64: dts: lx2160a: describe the SerDes block #1"

---
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +6 -0
index ea6a94b57aeb..2e68c05181dd 100644
@@ -626,6 +626,12 @@ serdes_1: phy@1ea0000 {
 			#phy-cells = <1>;
 		};
 
+		serdes_2: phy@1eb0000 {
+			compatible = "fsl,lynx-28g";
+			reg = <0x0 0x1eb0000 0x0 0x1e30>;
+			#phy-cells = <1>;
+		};
+
 		crypto: crypto@8000000 {
 			compatible = "fsl,sec-v5.0", "fsl,sec-v4.0";
 			fsl,sec-era = <10>;
Signature · 7 lines
2.35.3


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#0 lore raw

cover arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

Add support for the SolidRun LX2162A System on Module (SoM), and the Clearfog evaluation board.

This patch-set introduces:
- dt node for lx2160a serdes block #2
- dtsi for lx2162a system on module
- dts for lx2162 clearfog

Firstly Please note that checkpatch was complaining about the EEPROMS:
- DT compatible string "st,24c02" appears un-documented
- DT compatible string "st,24c2048" appears un-documented
- DT compatible string "atmel,24c2048" appears un-documented However to my eyes these *are* already documented in at24.yaml, and are also used in existing device-tree.

Secondly the MAINTAINERS file has not been modified. Is it required I add myself or *someone* for these new dts?

Josua Mayer (3):
arm64: dts: lx2160a: describe the SerDes block #2
dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board
arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

 .../devicetree/bindings/arm/fsl.yaml          |   2 +
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi |   6 +
 .../dts/freescale/fsl-lx2162a-clearfog.dts    | 369 ++++++++++++++++++
 .../dts/freescale/fsl-lx2162a-sr-som.dtsi     |  78 ++++
 5 files changed, 456 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Pengutronix Kernel Team <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc NXP Linux Team <[email protected]>
Cc Rob Herring <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Conor Dooley <[email protected]>
Cc Li Yang <[email protected]>
Signature · 7 lines
2.35.3


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#9 lore raw

PATCH 3/3 arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board

Add support for the SolidRun LX2162A System on Module (SoM), and the Clearfog evaluation board.

The SoM has few software-controllable features:
- AR8035 Ethernet PHY
- eMMC
- SPI Flash
- fan controller
- various eeproms

The Clearfog evaluation board provides:
- microSD connector
- USB-A
- 2x 10Gbps SFP+
- 2x 25Gbps SFP+ with a retimer
- 8x 2.5Gbps RJ45
- 2x mPCI (assembly option / disables 2xRJ45)

The 8x RJ45 ports are connected with an 8-port PHY: Marvell 88E2580 supporting up to 5Gbps, while SoC and magnetics are limited to 2.5Gbps.

However 2500 speed is untested due to documentation and drivier limitations. To avoid confusion the phy nodes have been explicitly limited to 1000 for now.

The PCI nodes are disabled, but explicitly added to mark that this board can have pci.
It is expected that the bootloader will patch the status property "okay" and disable 2x RJ45 ports, according to active serdes configuration.

---
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../dts/freescale/fsl-lx2162a-clearfog.dts    | 369 ++++++++++++++++++
 .../dts/freescale/fsl-lx2162a-sr-som.dtsi     |  78 ++++
 3 files changed, 448 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi
arch/arm64/boot/dts/freescale/Makefile +1 -0
index ef7d17aef58f..b4fb5044d1c7 100644
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
 
 fsl-ls1028a-qds-13bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-13bb.dtbo
 fsl-ls1028a-qds-65bb-dtbs := fsl-ls1028a-qds.dtb fsl-ls1028a-qds-65bb.dtbo
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +369 -0

369 lines not on this page · raw message

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +78 -0

78 lines not on this page · raw message

Signature · 7 lines
2.35.3


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 2/3 dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

In reply to Josua Mayer

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +2 -0
index 15d411084065..438a4ece8157 100644
@@ -1373,9 +1373,11 @@ properties:
       - description: SolidRun LX2160A based Boards
         items:
           - enum:
+              - solidrun,clearfog
               - solidrun,clearfog-cx
               - solidrun,honeycomb
           - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
           - const: fsl,lx2160a
 
       - description: S32G2 based Boards
Signature · 7 lines
2.35.3


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

Quoted 12 lines · Josua Mayer

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index 15d411084065..438a4ece8157 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 1381

Quoted 9 lines
Documentation/devicetree/bindings/arm/fsl.yaml +2 -0
@@ -1373,9 +1373,11 @@ properties:
       - description: SolidRun LX2160A based Boards
         items:
           - enum:
+              - solidrun,clearfog
               - solidrun,clearfog-cx
               - solidrun,honeycomb
           - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
           - const: fsl,lx2160a

You change existing entries, breaking boards and changing the meaning, without any explanation in commit msg. That's not how it is done. Please provide rationale in commit msg.

Best regards,
Krzysztof

#10 lore raw
In reply to Josua Mayer
Quoted 10 lines · Josua Mayer

Add support for the SolidRun LX2162A System on Module (SoM), and the Clearfog evaluation board.

The SoM has few software-controllable features:
- AR8035 Ethernet PHY
- eMMC
- SPI Flash
- fan controller
- various eeproms

Thank you for your patch. There is something to discuss/improve.

arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts line 94

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +9 -0
+
+&i2c2 {
+	/* retimer: ds250df410@18 */
+
+	i2c-switch@70 {
+		compatible = "nxp,pca9546";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x70>;

reg is usually just after compatible.

...

arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts line 242

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +9 -0
+
+&emdio1 {
+	/*
+	 * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
+	 * It competes for WRIOP MAC17, and no connector has been wired.
+	 */
+	/delete-node/ ethernet-phy@1;
+
+	ethernet_phy0: mv88e2580@8 {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 164 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +127 -0
+		reg = <8>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy1: mv88e2580@9 {
+		reg = <9>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy2: mv88e2580@a {
+		reg = <10>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy3: mv88e2580@b {
+		reg = <11>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy4: mv88e2580@c {
+		reg = <12>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy5: mv88e2580@d {
+		reg = <13>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy6: mv88e2580@e {
+		reg = <14>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy7: mv88e2580@f {
+		reg = <15>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+};
+
+&esdhc0 {
+	status = "okay";
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+};
+
+&pcie3 {
+	status = "disabled";
+};
+
+&pcie4 {
+	status = "disabled";
+};
+
+&pcs_mdio3 {
+	status = "okay";
+};
+
+&pcs_mdio4 {
+	status = "okay";
+};
+
+&pcs_mdio5 {
+	status = "okay";
+};
+
+&pcs_mdio6 {
+	status = "okay";
+};
+
+&pcs_mdio11 {
+	status = "okay";
+};
+
+&pcs_mdio12 {
+	status = "okay";
+};
+
+&pcs_mdio13 {
+	status = "okay";
+};
+
+&pcs_mdio14 {
+	status = "okay";
+};
+
+&pcs_mdio15 {
+	status = "okay";
+};
+
+&pcs_mdio16 {
+	status = "okay";
+};
+
+&pcs_mdio17 {
+	status = "okay";
+};
+
+&pcs_mdio18 {
+	status = "okay";
+};
+
+&serdes_1 {
+	status = "okay";
+};
+
+&serdes_2 {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&usb0 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +31 -0
new file mode 100644
index 000000000000..49e03b6600d6
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A-SOM
+//
+// Copyright 2021 Rabeeh Khoury <[email protected]>
+// Copyright 2023 Josua Mayer <[email protected]>
+
+&crypto {
+	status = "okay";
+};
+
+&dpmac17 {
+	phy-handle = <&ethernet_phy0>;
+	phy-connection-type = "rgmii-id";
+};
+
+&emdio1 {
+	status = "okay";
+
+	ethernet_phy0: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&esdhc1 {
+	status = "okay";
+	bus-width = <8>;
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+};
+

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 41

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +10 -0
+&fspi {
+	status = "okay";
+
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "m25p80", "jedec,spi-nor";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;

Fix the order of properties. compatible is always first, then the reg.

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 44

Quoted 3 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +3 -0
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		// spi-tx-bus-width = <8>;

Don't add dead code without appropriate comment why it is dead.

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +7 -0
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	fan-controller@18 {

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 61

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +10 -0
+		compatible = "ti,amc6821";
+		reg = <0x18>;
+		cooling-min-state = <0>;
+		cooling-max-state = <9>;
+		#cooling-cells = <2>;
+	};
+
+	ddr_spd: eeprom@51 {
+		reg = <0x57>;
+		compatible = "st,24c02", "atmel,24c02";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 67

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +6 -0
+		read-only;
+	};
+
+	config_eeprom: eeprom@57 {
+		reg = <0x57>;
+		compatible = "st,24c02", "atmel,24c02";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 76

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +9 -0
+	};
+};
+
+&i2c4 {
+	status = "okay";
+
+	variable_eeprom: eeprom@54 {
+		reg = <0x54>;
+		compatible = "st,24c2048", "atmel,24c2048";

ditto

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +2 -0
+	};
+};

Best regards,
Krzysztof

#11 lore raw

Hi Krzysztof,

Thank you for the comments!
Before sending a v2, I will:
- move all "reg" properties just after "compatible"
- give the phy nodes generic names
- remove dead code / review spi-nor-flash node

Am 16.06.23 um 14:39 schrieb Krzysztof Kozlowski:

Quoted 258 lines · Josua Mayer
Quoted 10 lines

Add support for the SolidRun LX2162A System on Module (SoM), and the Clearfog evaluation board.

The SoM has few software-controllable features:
- AR8035 Ethernet PHY
- eMMC
- SPI Flash
- fan controller
- various eeproms

Thank you for your patch. There is something to discuss/improve.

arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts line 94

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +9 -0
+
+&i2c2 {
+	/* retimer: ds250df410@18 */
+
+	i2c-switch@70 {
+		compatible = "nxp,pca9546";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x70>;

reg is usually just after compatible.

...

arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts line 242

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +9 -0
+
+&emdio1 {
+	/*
+	 * SoM has a phy at address 1 connected to SoC Ethernet Controller 1.
+	 * It competes for WRIOP MAC17, and no connector has been wired.
+	 */
+	/delete-node/ ethernet-phy@1;
+
+	ethernet_phy0: mv88e2580@8 {

Node names should be generic. See also explanation and list of examples in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 164 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-clearfog.dts new file +127 -0
+		reg = <8>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy1: mv88e2580@9 {
+		reg = <9>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy2: mv88e2580@a {
+		reg = <10>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy3: mv88e2580@b {
+		reg = <11>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy4: mv88e2580@c {
+		reg = <12>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy5: mv88e2580@d {
+		reg = <13>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy6: mv88e2580@e {
+		reg = <14>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+
+	ethernet_phy7: mv88e2580@f {
+		reg = <15>;
+		compatible = "ethernet-phy-ieee802.3-c45";
+		max-speed = <1000>;
+	};
+};
+
+&esdhc0 {
+	status = "okay";
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+};
+
+&pcie3 {
+	status = "disabled";
+};
+
+&pcie4 {
+	status = "disabled";
+};
+
+&pcs_mdio3 {
+	status = "okay";
+};
+
+&pcs_mdio4 {
+	status = "okay";
+};
+
+&pcs_mdio5 {
+	status = "okay";
+};
+
+&pcs_mdio6 {
+	status = "okay";
+};
+
+&pcs_mdio11 {
+	status = "okay";
+};
+
+&pcs_mdio12 {
+	status = "okay";
+};
+
+&pcs_mdio13 {
+	status = "okay";
+};
+
+&pcs_mdio14 {
+	status = "okay";
+};
+
+&pcs_mdio15 {
+	status = "okay";
+};
+
+&pcs_mdio16 {
+	status = "okay";
+};
+
+&pcs_mdio17 {
+	status = "okay";
+};
+
+&pcs_mdio18 {
+	status = "okay";
+};
+
+&serdes_1 {
+	status = "okay";
+};
+
+&serdes_2 {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&usb0 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +31 -0
new file mode 100644
index 000000000000..49e03b6600d6
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2162A-SOM
+//
+// Copyright 2021 Rabeeh Khoury <[email protected]>
+// Copyright 2023 Josua Mayer <[email protected]>
+
+&crypto {
+	status = "okay";
+};
+
+&dpmac17 {
+	phy-handle = <&ethernet_phy0>;
+	phy-connection-type = "rgmii-id";
+};
+
+&emdio1 {
+	status = "okay";
+
+	ethernet_phy0: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&esdhc1 {
+	status = "okay";
+	bus-width = <8>;
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+};
+

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 41

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +10 -0
+&fspi {
+	status = "okay";
+
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "m25p80", "jedec,spi-nor";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;

Fix the order of properties. compatible is always first, then the reg.

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 44

Quoted 3 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +3 -0
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		// spi-tx-bus-width = <8>;

Don't add dead code without appropriate comment why it is dead.

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +7 -0
+	};
+};
+
+&i2c0 {
+	status = "okay";
+
+	fan-controller@18 {

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 61

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +10 -0
+		compatible = "ti,amc6821";
+		reg = <0x18>;
+		cooling-min-state = <0>;
+		cooling-max-state = <9>;
+		#cooling-cells = <2>;
+	};
+
+	ddr_spd: eeprom@51 {
+		reg = <0x57>;
+		compatible = "st,24c02", "atmel,24c02";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 67

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +6 -0
+		read-only;
+	};
+
+	config_eeprom: eeprom@57 {
+		reg = <0x57>;
+		compatible = "st,24c02", "atmel,24c02";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 76

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +9 -0
+	};
+};
+
+&i2c4 {
+	status = "okay";
+
+	variable_eeprom: eeprom@54 {
+		reg = <0x54>;
+		compatible = "st,24c2048", "atmel,24c2048";

ditto

Quoted 5 lines

arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi line 78

Quoted 2 lines
arch/arm64/boot/dts/freescale/fsl-lx2162a-sr-som.dtsi new file +2 -0
+	};
+};

Best regards,
Krzysztof

sincerely
Josua Mayer

#4 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

In reply to Krzysztof Kozlowski

HI Krzysztof,

Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:

Quoted 17 lines · Josua Mayer
Quoted 16 lines

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 15d411084065..438a4ece8157 100644
@@ -1373,9 +1373,11 @@ properties:
        - description: SolidRun LX2160A based Boards
          items:
            - enum:
+              - solidrun,clearfog
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 1381

Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                - solidrun,clearfog-cx
                - solidrun,honeycomb
            - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
            - const: fsl,lx2160a

You change existing entries, breaking boards and changing the meaning, without any explanation in commit msg. That's not how it is done. Please provide rationale in commit msg.

I'm sorry. Given your comment I think I did not understand how these entries are supposed to work. So perhaps you can provide some guidance based on my explanation?:

- NXP LX2162 is a smaller physical package of the same LX2160 SoC, with reduced IOs and some silicon blocks disabled.
- SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX
- SolidRun LX2162 Clearfog is the reference platform for the SoM. Despite it's naming similarity to clearfog-cx, it has a different feature set more similar to SolidRun Armada 388 Clearfog Pro

So I believed I could just add to the existing entry "SolidRun LX2160A based Boards" also the new LX2162 Board & SoM. I see now that adding a fourth const messes upthe existing 3-part compatible for those already existing boards.

Please can you confirm if it would have been more correct to replace "const: solidrun,lx2160a-cex7" with an enum?:
enum:
  - solidrun,lx2160a-cex7
  - solidrun,lx2162a-som

Finally, is it okay to add a "solidrun,clearfog" given my explanation above, or should it be more specific "solidrun,lx2162a-clearfog"?

Quoted 2 lines

Best regards,
Krzysztof

Sincerely
Josua Mayer

#5 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

Quoted 29 lines · On Fri, 16 Jun 2023 16:32:01 +0300 Josua Mayer <[email protected]> wrote:

HI Krzysztof,

Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:

Quoted 17 lines · Josua Mayer
Quoted 16 lines

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 15d411084065..438a4ece8157 100644
@@ -1373,9 +1373,11 @@ properties:
        - description: SolidRun LX2160A based Boards
          items:
            - enum:
+              - solidrun,clearfog
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 1381

Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                - solidrun,clearfog-cx
                - solidrun,honeycomb
            - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
            - const: fsl,lx2160a  

You change existing entries, breaking boards and changing the meaning, without any explanation in commit msg. That's not how it is done. Please provide rationale in commit msg.

Quoted 4 lines

I'm sorry. Given your comment I think I did not understand how these entries are supposed to work.
So perhaps you can provide some guidance based on my explanation?:

it breaks:
arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts compatible = "solidrun,clearfog-cx",

                "solidrun,lx2160a-cex7", "fsl,lx2160a";

now you would require:
compatible = "solidrun,clearfog-cx",

                "solidrun,lx2160a-cex7", "solidrun,lx2162a-som", "fsl,lx2160a"

which is probably not what you want.

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

In reply to Josua Mayer
Quoted 40 lines · Josua Mayer

HI Krzysztof,

Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:

Quoted 17 lines · Josua Mayer
Quoted 16 lines

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
  1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 15d411084065..438a4ece8157 100644
@@ -1373,9 +1373,11 @@ properties:
        - description: SolidRun LX2160A based Boards
          items:
            - enum:
+              - solidrun,clearfog
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 1381

Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                - solidrun,clearfog-cx
                - solidrun,honeycomb
            - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
            - const: fsl,lx2160a

You change existing entries, breaking boards and changing the meaning, without any explanation in commit msg. That's not how it is done. Please provide rationale in commit msg.

I'm sorry. Given your comment I think I did not understand how these entries are supposed to work.
So perhaps you can provide some guidance based on my explanation?:

- NXP LX2162 is a smaller physical package of the same LX2160 SoC, with reduced IOs and some silicon blocks disabled.
- SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX
- SolidRun LX2162 Clearfog is the reference platform for the SoM. Despite it's naming similarity to clearfog-cx, it has a different feature set more similar to SolidRun Armada 388 Clearfog Pro

Quoted 2 lines

So I believed I could just add to the existing entry "SolidRun LX2160A based Boards" also the new LX2162 Board & SoM.

But you added much more, didn't you?

Quoted 12 lines

I see now that adding a fourth const messes upthe existing 3-part compatible for those already existing boards.

Please can you confirm if it would have been more correct to replace "const: solidrun,lx2160a-cex7" with an enum?:
enum:
  - solidrun,lx2160a-cex7
  - solidrun,lx2162a-som

Finally, is it okay to add a "solidrun,clearfog" given my explanation above, or should it be more specific "solidrun,lx2162a-clearfog"?

Test the binding and test DTS against it:
Please run make dtbs_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

It might point you to answer.

Why do you make solidrun,honeycomb compatible with cex7 and som?

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#12 lore raw
In reply to Josua Mayer
Quoted 8 lines · Josua Mayer

Hi Krzysztof,

Thank you for the comments!
Before sending a v2, I will:
- move all "reg" properties just after "compatible"
- give the phy nodes generic names
- remove dead code / review spi-nor-flash node

You forgot testing.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

In reply to Andreas Kemnade

Hi Andreas,

Am 16.06.23 um 19:57 schrieb Andreas Kemnade:

Quoted 35 lines
Quoted 28 lines · On Fri, 16 Jun 2023 16:32:01 +0300 Josua Mayer <[email protected]> wrote:

HI Krzysztof,

Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski:

Quoted 17 lines · Josua Mayer
Quoted 16 lines

Add DT compatible for SolidRun LX2162A SoM and Clearfog board.

---
   Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
   1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 15d411084065..438a4ece8157 100644
@@ -1373,9 +1373,11 @@ properties:
         - description: SolidRun LX2160A based Boards
           items:
             - enum:
+              - solidrun,clearfog
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 1381

Quoted 5 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                 - solidrun,clearfog-cx
                 - solidrun,honeycomb
             - const: solidrun,lx2160a-cex7
+          - const: solidrun,lx2162a-som
             - const: fsl,lx2160a

You change existing entries, breaking boards and changing the meaning, without any explanation in commit msg. That's not how it is done. Please provide rationale in commit msg.

Quoted 4 lines

I'm sorry. Given your comment I think I did not understand how these entries are supposed to work.
So perhaps you can provide some guidance based on my explanation?:

Quoted 8 lines

it breaks:
arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts compatible = "solidrun,clearfog-cx",

                 "solidrun,lx2160a-cex7", "fsl,lx2160a";

now you would require:
compatible = "solidrun,clearfog-cx",

                 "solidrun,lx2160a-cex7", "solidrun,lx2162a-som", "fsl,lx2160a"

I see, thanks!
The more I look at it, the more logical this behaviour seems.

Quoted 1 line

which is probably not what you want.

Yep. I wanted to keep the 3 components, and allow forking in the middle:

"solidrun,<board>", "solidrun,<module>", "fsl,lx2160a"

This however creates many combinations that are undesirable.
Existing boards using com express don't suddenly become compatible with the new SoM. Therefore I prepared a different approach vor v2 now.

Quoted 2 lines

Regards,
Andreas

- Josua Mayer

#8 lore raw

Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board

In reply to Krzysztof Kozlowski

Hi Krzysztof,

Am 16.06.23 um 19:59 schrieb Krzysztof Kozlowski:

Quoted 4 lines

Test the binding and test DTS against it:
Please run make dtbs_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

This was helpful! I ran it a few times and studied the results.
Many complaints related to lx2160a.dtsi, some common among different layerscape based dts. Finally some mistakes of my own.

v2 addresses all that were under my control, and a common one that I understood well enough.

Quoted 3 lines

It might point you to answer.

Why do you make solidrun,honeycomb compatible with cex7 and som?

Exactly - unintentional.

Quoted 2 lines

Best regards,
Krzysztof

- Josua Mayer