f2fs: remove redundant assignment to variable err
Subsystems (2)
PATCH 1/1 f2fs: remove redundant assignment to variable err
The assignment to variable err is redundant since the code jumps to label next and err is then re-assigned a new value on the call to sanity_check_node_chain. Remove the assignment.
Cleans up clang scan build warning:fs/f2fs/recovery.c:464:6: warning: Value stored to 'err' is never read [deadcode.DeadStores]
--- fs/f2fs/recovery.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fs/f2fs/recovery.c +1 -3
@@ -460,10 +460,8 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head, quota_inode);if (IS_ERR (entry)) { err =PTR_ERR (entry); -if (err == -ENOENT ) { - err =0 ; +if (err == -ENOENT ) goto next; - }f2fs_put_page (page,1 );break ; }
Signature · 1 line
2.39.2
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 8 lines · On Fri, 16 Jun 2023 15:20:09 +0100 you wrote:
The assignment to variable err is redundant since the code jumps to label next and err is then re-assigned a new value on the call to
sanity_check_node_chain. Remove the assignment.Cleans up clang scan build warning:
fs/f2fs/recovery.c:464:6: warning: Value stored to 'err' is never read [deadcode.DeadStores][...]
Here is the summary with links:
- [f2fs-dev,next] f2fs: remove redundant assignment to variable err
https://git.kernel.org/jaegeuk/f2fs/c/71a1277a46da
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html