regmap: Allow reads from write only registers with the flat cache
Subsystems (2)
Mark Brown
maintainerPATCH 1/1 regmap: Allow reads from write only registers with the flat cache
The flat cache is intended for devices that need the lowest overhead so doesn't track any sparseness.
---
--- drivers/base/regmap/regmap-kunit.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/base/regmap/regmap-kunit.c +12 -3
@@ -252,9 +252,18 @@ static void read_writeonly(struct kunit *test)for (i =0 ; i <BLOCK_TEST_SIZE ; i++) data->read[i] = false; -/* Try to read all the registers, the writeonly one should fail */ -for (i =0 ; i <BLOCK_TEST_SIZE ; i++) -KUNIT_EXPECT_EQ (test, i !=5 ,regmap_read (map, i, &val) ==0 ); +/* +* Try to read all the registers, the writeonly one should +* fail if we aren't using the flat cache. +*/ +for (i =0 ; i <BLOCK_TEST_SIZE ; i++) { +if (t->type !=REGCACHE_FLAT ) { +KUNIT_EXPECT_EQ (test, i !=5 , +regmap_read (map, i, &val) ==0 ); + }else { +KUNIT_EXPECT_EQ (test,0 ,regmap_read (map, i, &val)); + } + }/* Did we trigger a hardware access? */ KUNIT_EXPECT_FALSE (test, data->read[5 ]);
---
base-commit: 3e47b8877d6c0f60943b00f3112756ca3b572cd6
change-id: 20230617-regmap-kunit-read-writeonly-flat-d342e0948e82
Best regards,
Signature · 1 line
Mark Brown,,, <[email protected]>
Mark Brown
maintainerQuoted 4 lines · Mark Brown
The flat cache is intended for devices that need the lowest overhead so doesn't track any sparseness.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
Thanks!
[1/1] regmap: Allow reads from write only registers with the flat cache
commit: d0c99ffe212679b338d12fe283964e6e43ce1501
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark