Skip to contentSkip to conversation

drm/i915/display/dp: On AUX xfer timeout restart freshly

PATCH Superseded Arun R Murthy 4 participants 7 messages Jun 19, 2023

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 drm/i915/display/dp: On AUX xfer timeout restart freshly

At the beginning of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register.
On each of these 3 trials a check for busy has to be done so as to start freshly.

v2: updated the commit message
v4: check for SEND_BUSY after write (Imre)

---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 58 +++++++++------------
 1 file changed, 26 insertions(+), 32 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_aux.c +26 -32
index 21b50a5c8a85..abe8047fac39 100644
@@ -226,6 +226,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	int i, ret, recv_bytes;
 	int try, clock = 0;
 	u32 status;
+	u32 send_ctl;
 	bool vdd;
 
 	ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
@@ -273,45 +274,36 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	 * it using the same AUX CH simultaneously
 	 */
 
-	/* Try to wait for any previous AUX channel activity */
-	for (try = 0; try < 3; try++) {
-		status = intel_de_read_notrace(i915, ch_ctl);
-		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
-			break;
-		msleep(1);
-	}
-	/* just trace the final value */
-	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-
-	if (try == 3) {
-		const u32 status = intel_de_read(i915, ch_ctl);
-
-		if (status != intel_dp->aux_busy_last_status) {
-			drm_WARN(&i915->drm, 1,
-				 "%s: not started (status 0x%08x)\n",
-				 intel_dp->aux.name, status);
-			intel_dp->aux_busy_last_status = status;
-		}
-
-		ret = -EBUSY;
-		goto out;
-	}
-
 	/* Only 5 data registers! */
 	if (drm_WARN_ON(&i915->drm, send_bytes > 20 || recv_size > 20)) {
 		ret = -E2BIG;
 		goto out;
 	}
+	send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
+					      send_bytes,
+					      aux_clock_divider);
+	send_ctl |= aux_send_ctl_flags;
 
 	while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) {
-		u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
-							  send_bytes,
-							  aux_clock_divider);
-
-		send_ctl |= aux_send_ctl_flags;
-
-		/* Must try at least 3 times according to DP spec */
+		/* Re-visit : Must try at least 3 times according to DP spec */
 		for (try = 0; try < 5; try++) {
+			/* Try to wait for any previous AUX channel activity */
+			status = intel_dp_aux_wait_done(intel_dp);
+			/* just trace the final value */
+			trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
+
+			if (status & DP_AUX_CH_CTL_SEND_BUSY) {
+				drm_WARN(&i915->drm, 1,
+					 "%s: not started, previous Tx still in process (status 0x%08x)\n",
+					 intel_dp->aux.name, status);
+				intel_dp->aux_busy_last_status = status;
+				if (try > 3) {
+					ret = -EBUSY;
+					goto out;
+				} else
+					continue;
+			}
+
 			/* Load the send data into the aux channel data registers */
 			for (i = 0; i < send_bytes; i += 4)
 				intel_de_write(i915, ch_data[i >> 2],
@@ -321,6 +313,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 			/* Send the command and wait for it to complete */
 			intel_de_write(i915, ch_ctl, send_ctl);
 
+			/* TODO: if typeC then 4.2ms else 800us. For DG2 add 1.5ms for both cases */
 			status = intel_dp_aux_wait_done(intel_dp);
 
 			/* Clear done status and any errors */
@@ -335,7 +328,8 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 			 *   Timeout errors from the HW already meet this
 			 *   requirement so skip to next iteration
 			 */
-			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
+			if (status & (DP_AUX_CH_CTL_TIME_OUT_ERROR |
+						DP_AUX_CH_CTL_SEND_BUSY))
 				continue;
 
 			if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
Signature · 1 line
2.25.1
#1 lore raw
kernel test robot noticed the following build warnings:

Hi Arun,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-tip/drm-tip]

url:    https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-display-dp-On-AUX-xfer-timeout-restart-freshly/20230619-163622
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
patch link:    https://lore.kernel.org/r/20230619082715.922094-1-arun.r.murthy%40intel.com
patch subject: [Intel-gfx] [PATCHv4] drm/i915/display/dp: On AUX xfer timeout restart freshly
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230619/[email protected]/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce: (https://download.01.org/0day-ci/archive/20230619/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dp_aux.c:284:12: warning: variable 'aux_clock_divider' is uninitialized when used here [-Wuninitialized]
                                                 aux_clock_divider);
                                                 ^~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_dp_aux.c:222:23: note: initialize the variable 'aux_clock_divider' to silence this warning
           u32 aux_clock_divider;
                                ^
                                 = 0

1 warning generated.

vim +/aux_clock_divider +284 drivers/gpu/drm/i915/display/intel_dp_aux.c

209
210 static int
211 intel_dp_aux_xfer(struct intel_dp *intel_dp,

   212			  const u8 *send, int send_bytes,
   213			  u8 *recv, int recv_size,
   214			  u32 aux_send_ctl_flags)
   215	{
   216		struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
   217		struct drm_i915_private *i915 =
   218				to_i915(dig_port->base.base.dev);
   219		enum phy phy = intel_port_to_phy(i915, dig_port->base.port);
   220		bool is_tc_port = intel_phy_is_tc(i915, phy);
   221		i915_reg_t ch_ctl, ch_data[5];
   222		u32 aux_clock_divider;
   223		enum intel_display_power_domain aux_domain;
   224		intel_wakeref_t aux_wakeref;
   225		intel_wakeref_t pps_wakeref;
   226		int i, ret, recv_bytes;
   227		int try, clock = 0;
   228		u32 status;
   229		u32 send_ctl;
   230		bool vdd;
   231	
   232		ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
   233		for (i = 0; i < ARRAY_SIZE(ch_data); i++)
   234			ch_data[i] = intel_dp->aux_ch_data_reg(intel_dp, i);
   235	
   236		if (is_tc_port) {
   237			intel_tc_port_lock(dig_port);
   238			/*
   239			 * Abort transfers on a disconnected port as required by
   240			 * DP 1.4a link CTS 4.2.1.5, also avoiding the long AUX
   241			 * timeouts that would otherwise happen.
   242			 * TODO: abort the transfer on non-TC ports as well.
   243			 */
   244			if (!intel_tc_port_connected_locked(&dig_port->base)) {
   245				ret = -ENXIO;
   246				goto out_unlock;
   247			}
   248		}
   249	
   250		aux_domain = intel_aux_power_domain(dig_port);
   251	
   252		aux_wakeref = intel_display_power_get(i915, aux_domain);
   253		pps_wakeref = intel_pps_lock(intel_dp);
   254	
   255		/*
   256		 * We will be called with VDD already enabled for dpcd/edid/oui reads.
   257		 * In such cases we want to leave VDD enabled and it's up to upper layers
   258		 * to turn it off. But for eg. i2c-dev access we need to turn it on/off
   259		 * ourselves.
   260		 */
   261		vdd = intel_pps_vdd_on_unlocked(intel_dp);
   262	
   263		/*
   264		 * dp aux is extremely sensitive to irq latency, hence request the
   265		 * lowest possible wakeup latency and so prevent the cpu from going into
   266		 * deep sleep states.
   267		 */
   268		cpu_latency_qos_update_request(&intel_dp->pm_qos, 0);
   269	
   270		intel_pps_check_power_unlocked(intel_dp);
   271	
   272		/*
   273		 * FIXME PSR should be disabled here to prevent
   274		 * it using the same AUX CH simultaneously
   275		 */
   276	
   277		/* Only 5 data registers! */
   278		if (drm_WARN_ON(&i915->drm, send_bytes > 20 || recv_size > 20)) {
   279			ret = -E2BIG;
   280			goto out;
   281		}
   282		send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
   283						      send_bytes,
 > 284						      aux_clock_divider);
   285		send_ctl |= aux_send_ctl_flags;
   286	
   287		while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) {
   288			/* Re-visit : Must try at least 3 times according to DP spec */
   289			for (try = 0; try < 5; try++) {
   290				/* Try to wait for any previous AUX channel activity */
   291				status = intel_dp_aux_wait_done(intel_dp);
   292				/* just trace the final value */
   293				trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
   294	
   295				if (status & DP_AUX_CH_CTL_SEND_BUSY) {
   296					drm_WARN(&i915->drm, 1,
   297						 "%s: not started, previous Tx still in process (status 0x%08x)\n",
   298						 intel_dp->aux.name, status);
   299					intel_dp->aux_busy_last_status = status;
   300					if (try > 3) {
   301						ret = -EBUSY;
   302						goto out;
   303					} else
   304						continue;
   305				}
   306	
   307				/* Load the send data into the aux channel data registers */
   308				for (i = 0; i < send_bytes; i += 4)
   309					intel_de_write(i915, ch_data[i >> 2],
   310						       intel_dp_aux_pack(send + i,
   311									 send_bytes - i));
   312	
   313				/* Send the command and wait for it to complete */
   314				intel_de_write(i915, ch_ctl, send_ctl);
   315	
   316				/* TODO: if typeC then 4.2ms else 800us. For DG2 add 1.5ms for both cases */
   317				status = intel_dp_aux_wait_done(intel_dp);
   318	
   319				/* Clear done status and any errors */
   320				intel_de_write(i915, ch_ctl,
   321					       status | DP_AUX_CH_CTL_DONE |
   322					       DP_AUX_CH_CTL_TIME_OUT_ERROR |
   323					       DP_AUX_CH_CTL_RECEIVE_ERROR);
   324	
   325				/*
   326				 * DP CTS 1.2 Core Rev 1.1, 4.2.1.1 & 4.2.1.2
   327				 *   400us delay required for errors and timeouts
   328				 *   Timeout errors from the HW already meet this
   329				 *   requirement so skip to next iteration

330 */
331 if (status & (DP_AUX_CH_CTL_TIME_OUT_ERROR |
332 DP_AUX_CH_CTL_SEND_BUSY))
333 continue;
334
335 if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
336 usleep_range(400, 500);
337 continue;
338 }
339 if (status & DP_AUX_CH_CTL_DONE)
340 goto done;
341 }
342 }
343
344 if ((status & DP_AUX_CH_CTL_DONE) == 0) {
345 drm_err(&i915->drm, "%s: not done (status 0x%08x)\n",
346 intel_dp->aux.name, status);
347 ret = -EBUSY;
348 goto out;
349 }
350
351 done:
352 /*
353 * Check for timeout or receive error. Timeouts occur when the sink is
354 * not connected.
355 */
356 if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
357 drm_err(&i915->drm, "%s: receive error (status 0x%08x)\n",
358 intel_dp->aux.name, status);
359 ret = -EIO;
360 goto out;
361 }
362
363 /*
364 * Timeouts occur when the device isn't connected, so they're "normal"
365 * -- don't fill the kernel log with these
366 */
367 if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR) {
368 drm_dbg_kms(&i915->drm, "%s: timeout (status 0x%08x)\n",
369 intel_dp->aux.name, status);
370 ret = -ETIMEDOUT;
371 goto out;
372 }
373
374 /* Unload any bytes sent back from the other side */
375 recv_bytes = REG_FIELD_GET(DP_AUX_CH_CTL_MESSAGE_SIZE_MASK, status);
376
377 /*
378 * By BSpec: "Message sizes of 0 or >20 are not allowed."
379 * We have no idea of what happened so we return -EBUSY so
380 * drm layer takes care for the necessary retries.
381 */
382 if (recv_bytes == 0 || recv_bytes > 20) {
383 drm_dbg_kms(&i915->drm,
384 "%s: Forbidden recv_bytes = %d on aux transaction\n",
385 intel_dp->aux.name, recv_bytes);
386 ret = -EBUSY;
387 goto out;
388 }
389
390 if (recv_bytes > recv_size)
391 recv_bytes = recv_size;
392
393 for (i = 0; i < recv_bytes; i += 4)
394 intel_dp_aux_unpack(intel_de_read(i915, ch_data[i >> 2]),
395 recv + i, recv_bytes - i);
396
397 ret = recv_bytes;
398 out:
399 cpu_latency_qos_update_request(&intel_dp->pm_qos, PM_QOS_DEFAULT_VALUE);
400
401 if (vdd)
402 intel_pps_vdd_off_unlocked(intel_dp, false);
403
404 intel_pps_unlock(intel_dp, pps_wakeref);
405 intel_display_power_put_async(i915, aux_domain, aux_wakeref);
406 out_unlock:
407 if (is_tc_port)
408 intel_tc_port_unlock(dig_port);
409
410 return ret;
411 }
412

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#2 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)
URL : https://patchwork.freedesktop.org/series/119055/
State : warning

== Summary ==

Error: dim checkpatch failed
c655062f3d72 drm/i915/display/dp: On AUX xfer timeout restart freshly -:91: CHECK:BRACES: Unbalanced braces around else statement #91: FILE: drivers/gpu/drm/i915/display/intel_dp_aux.c:303:
+ } else

total: 0 errors, 0 warnings, 1 checks, 90 lines checked

#3 lore raw
In reply to Arun R Murthy
Quoted 61 lines · Arun R Murthy

At the beginning of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register.
On each of these 3 trials a check for busy has to be done so as to start freshly.

v2: updated the commit message
v4: check for SEND_BUSY after write (Imre)

---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 58 +++++++++------------
 1 file changed, 26 insertions(+), 32 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_aux.c +2 -24
index 21b50a5c8a85..abe8047fac39 100644
@@ -226,6 +226,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	int i, ret, recv_bytes;
 	int try, clock = 0;
 	u32 status;
+	u32 send_ctl;
 	bool vdd;
 
 	ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
@@ -273,45 +274,36 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	 * it using the same AUX CH simultaneously
 	 */
 
-	/* Try to wait for any previous AUX channel activity */
-	for (try = 0; try < 3; try++) {
-		status = intel_de_read_notrace(i915, ch_ctl);
-		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
-			break;
-		msleep(1);
-	}
-	/* just trace the final value */
-	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-
-	if (try == 3) {
-		const u32 status = intel_de_read(i915, ch_ctl);
-
-		if (status != intel_dp->aux_busy_last_status) {
-			drm_WARN(&i915->drm, 1,
-				 "%s: not started (status 0x%08x)\n",
-				 intel_dp->aux.name, status);
-			intel_dp->aux_busy_last_status = status;
-		}
-
-		ret = -EBUSY;
-		goto out;
-	}
-
 	/* Only 5 data registers! */
 	if (drm_WARN_ON(&i915->drm, send_bytes > 20 || recv_size > 20)) {
 		ret = -E2BIG;
 		goto out;
 	}
+	send_ctl = intel_dp->get_aux_send_ctl(intel_dp,

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 311

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +3 -5
+					      send_bytes,
+					      aux_clock_divider);
+	send_ctl |= aux_send_ctl_flags;
 
 	while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) {
-		u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
-							  send_bytes,
-							  aux_clock_divider);
-
-		send_ctl |= aux_send_ctl_flags;

You can't move the send_ctl assignment outside the loop, because the loop changes aux_clock_divider which affects send_ctl.

Please take your time with the next version, and don't try to rush it, and we'll get this done quicker.

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 288

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +1 -2
-
-		/* Must try at least 3 times according to DP spec */
+		/* Re-visit : Must try at least 3 times according to DP spec */

How is this change helpful?

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +5 -0
 		for (try = 0; try < 5; try++) {
+			/* Try to wait for any previous AUX channel activity */
+			status = intel_dp_aux_wait_done(intel_dp);
+			/* just trace the final value */
+			trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
+

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 304

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +10 -0
+			if (status & DP_AUX_CH_CTL_SEND_BUSY) {
+				drm_WARN(&i915->drm, 1,
+					 "%s: not started, previous Tx still in process (status 0x%08x)\n",
+					 intel_dp->aux.name, status);
+				intel_dp->aux_busy_last_status = status;
+				if (try > 3) {
+					ret = -EBUSY;
+					goto out;
+				} else
+					continue;

If one branch needs braces, all of them do.

Quoted 14 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +3 -0
+			}
+
 			/* Load the send data into the aux channel data registers */
 			for (i = 0; i < send_bytes; i += 4)
 				intel_de_write(i915, ch_data[i >> 2],
@@ -321,6 +313,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 			/* Send the command and wait for it to complete */
 			intel_de_write(i915, ch_ctl, send_ctl);
 
+			/* TODO: if typeC then 4.2ms else 800us. For DG2 add 1.5ms for both cases */
 			status = intel_dp_aux_wait_done(intel_dp);
 
 			/* Clear done status and any errors */

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 332

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +2 -1
@@ -335,7 +328,8 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 			 *   Timeout errors from the HW already meet this
 			 *   requirement so skip to next iteration
 			 */
-			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
+			if (status & (DP_AUX_CH_CTL_TIME_OUT_ERROR |
+						DP_AUX_CH_CTL_SEND_BUSY))

The indentation is off.

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +0 -0
 				continue;
 
 			if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#4 lore raw
Quoted 90 lines

-----Original Message-----
From: Nikula, Jani <[email protected]>
Sent: Monday, June 19, 2023 5:37 PM
To: Murthy, Arun R <[email protected]>; intel- [email protected]
Cc: Deak, Imre <[email protected]>; Kahola, Mika <[email protected]>; Murthy, Arun R <[email protected]>
Subject: Re: [PATCHv4] drm/i915/display/dp: On AUX xfer timeout restart freshly

Quoted 64 lines · Arun R Murthy

At the beginning of the aux transfer a check for aux control busy bit is done. Then as per the spec on aux transfer timeout, need to retry freshly for 3 times with a delay which is taken care by the control register.
On each of these 3 trials a check for busy has to be done so as to start freshly.

v2: updated the commit message
v4: check for SEND_BUSY after write (Imre)

---
 drivers/gpu/drm/i915/display/intel_dp_aux.c | 58
+++++++++------------
 1 file changed, 26 insertions(+), 32 deletions(-)
drivers/gpu/drm/i915/display/intel_dp_aux.c +3 -24
index 21b50a5c8a85..abe8047fac39 100644
@@ -226,6 +226,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	int i, ret, recv_bytes;
 	int try, clock = 0;
 	u32 status;
+	u32 send_ctl;
 	bool vdd;
 
 	ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
@@ -273,45 +274,36 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp,
 	 * it using the same AUX CH simultaneously
 	 */
 
-	/* Try to wait for any previous AUX channel activity */
-	for (try = 0; try < 3; try++) {
-		status = intel_de_read_notrace(i915, ch_ctl);
-		if ((status & DP_AUX_CH_CTL_SEND_BUSY) == 0)
-			break;
-		msleep(1);
-	}
-	/* just trace the final value */
-	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
-
-	if (try == 3) {
-		const u32 status = intel_de_read(i915, ch_ctl);
-
-		if (status != intel_dp->aux_busy_last_status) {
-			drm_WARN(&i915->drm, 1,
-				 "%s: not started (status 0x%08x)\n",
-				 intel_dp->aux.name, status);
-			intel_dp->aux_busy_last_status = status;
-		}
-
-		ret = -EBUSY;
-		goto out;
-	}
-
 	/* Only 5 data registers! */
 	if (drm_WARN_ON(&i915->drm, send_bytes > 20 || recv_size > 20)) {
 		ret = -E2BIG;
 		goto out;
 	}
+	send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
+					      send_bytes,

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 312

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +2 -5
+					      aux_clock_divider);
+	send_ctl |= aux_send_ctl_flags;
 
 	while ((aux_clock_divider = intel_dp-
 get_aux_clock_divider(intel_dp, clock++))) {
-		u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp,
-							  send_bytes,
-							  aux_clock_divider);
-
-		send_ctl |= aux_send_ctl_flags;

You can't move the send_ctl assignment outside the loop, because the loop changes aux_clock_divider which affects send_ctl.

Quoted 2 lines

Please take your time with the next version, and don't try to rush it, and we'll get this done quicker.

Sure.

Quoted 6 lines

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 288

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +1 -2
-
-		/* Must try at least 3 times according to DP spec */
+		/* Re-visit : Must try at least 3 times according to DP spec */

How is this change helpful?

There was a comment on the earlier patch for the retry count. Here we are retrying for 5 times but the spec says retry for 3 times. Need to revisit this to see if there is any WA/recommendation in Bspec and to update the same with link or revert it to 3 times.

Quoted 13 lines

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 291

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +1 -0
 		for (try = 0; try < 5; try++) {
+			/* Try to wait for any previous AUX channel activity

*/

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +3 -0
+			status = intel_dp_aux_wait_done(intel_dp);
+			/* just trace the final value */
+			trace_i915_reg_rw(false, ch_ctl, status, sizeof(status),

true);

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +4 -0
+
+			if (status & DP_AUX_CH_CTL_SEND_BUSY) {
+				drm_WARN(&i915->drm, 1,
+					 "%s: not started, previous Tx still in

process (status 0x%08x)\n",

Quoted 10 lines

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 304

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +7 -0
+					 intel_dp->aux.name, status);
+				intel_dp->aux_busy_last_status = status;
+				if (try > 3) {
+					ret = -EBUSY;
+					goto out;
+				} else
+					continue;

If one branch needs braces, all of them do.

Ok.

Thanks and Regards,
Arun R Murthy
--------------------

Quoted 35 lines

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +2 -0
+			}
+
 			/* Load the send data into the aux channel data

registers */

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +0 -0
 			for (i = 0; i < send_bytes; i += 4)

intel_de_write(i915, ch_data[i >> 2], @@ -

321,6 +313,7 @@

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 5 lines

intel_dp_aux_xfer(struct intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_dp_aux.c +1 -0
 			/* Send the command and wait for it to complete */
 			intel_de_write(i915, ch_ctl, send_ctl);
 
+			/* TODO: if typeC then 4.2ms else 800us. For DG2

add 1.5ms for

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +1 -0
+both cases */
 			status = intel_dp_aux_wait_done(intel_dp);
 
 			/* Clear done status and any errors */ @@ -335,7

+328,8 @@

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp,

Quoted 7 lines

intel_dp_aux_xfer(struct intel_dp *intel_dp,

drivers/gpu/drm/i915/display/intel_dp_aux.c +2 -1
 			 *   Timeout errors from the HW already meet this
 			 *   requirement so skip to next iteration
 			 */
-			if (status & DP_AUX_CH_CTL_TIME_OUT_ERROR)
+			if (status & (DP_AUX_CH_CTL_TIME_OUT_ERROR |
+
	DP_AUX_CH_CTL_SEND_BUSY))

The indentation is off.

drivers/gpu/drm/i915/display/intel_dp_aux.c intel_dp_aux_xfer(struct intel_dp *intel_dp, · line 335

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_dp_aux.c +0 -0
 				continue;
 
 			if (status & DP_AUX_CH_CTL_RECEIVE_ERROR) {

--
Jani Nikula, Intel Open Source Graphics Center

#5 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)
URL : https://patchwork.freedesktop.org/series/119055/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13285 -> Patchwork_119055v4
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/index.html

Participating hosts (43 -> 42)
------------------------------

Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_119055v4 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_module_load@load:
- bat-adlp-11: [PASS][1] -> [ABORT][2] ([i915#4423])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-adlp-11/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-adlp-11/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][5] -> [INCOMPLETE][6] ([i915#7609] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][7] -> [DMESG-FAIL][8] ([i915#4258] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@guc:
- bat-rpls-1: [PASS][9] -> [DMESG-WARN][10] ([i915#7852])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-rpls-1/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-7: [PASS][11] -> [ABORT][12] ([i915#4983])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-dg1-7/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-dg1-7/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][13] -> [DMESG-FAIL][14] ([i915#8497])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-mtlp-8/igt@i915_selftest@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-mtlp-8/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][15] -> [DMESG-WARN][16] ([i915#7794])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-rpls-1/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][17] ([i915#6367])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@workarounds:
- bat-dg1-5: [PASS][18] -> [ABORT][19] ([i915#4983])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-dg1-5/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-dg1-5/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][20] ([i915#6687] / [i915#8668])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-2/igt@[email protected]

* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-bsw-n3050: NOTRUN -> [SKIP][21] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/fi-bsw-n3050/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][22] -> [FAIL][23] ([i915#7932])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc:
- fi-bsw-nick: NOTRUN -> [SKIP][24] ([fdo#109271]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/fi-bsw-nick/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [ABORT][25] ([i915#7911] / [i915#7913]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/fi-bsw-nick/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/fi-bsw-nick/igt@i915_selftest@[email protected]
- fi-bsw-n3050: [ABORT][27] ([i915#7911] / [i915#7913]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/fi-bsw-n3050/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/fi-bsw-n3050/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@migrate:
- bat-mtlp-8: [DMESG-FAIL][29] ([i915#7699]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-mtlp-8/igt@i915_selftest@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-mtlp-8/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][31] ([i915#7913]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-rpls-2/igt@i915_selftest@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rpls-2/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [SKIP][33] ([i915#3555] / [i915#4579]) -> [ABORT][34] ([i915#4579] / [i915#8260])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/bat-rplp-1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/bat-rplp-1/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7794]: https://gitlab.freedesktop.org/drm/intel/issues/7794
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668

Build changes
-------------

* Linux: CI_DRM_13285 -> Patchwork_119055v4

CI-20190529: 20190529
CI_DRM_13285: 13953a220ac9e1babdab06d31d546ce799102c03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7336: b7d168f61bef72a3e84e72eeee1767fac577d70d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119055v4: 13953a220ac9e1babdab06d31d546ce799102c03 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

76724b2fbee7 drm/i915/display/dp: On AUX xfer timeout restart freshly

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/index.html

#6 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)

In reply to Arun R Murthy
== Series Details ==

== Series Details ==

Series: drm/i915/display/dp: On AUX xfer timeout restart freshly (rev4)
URL : https://patchwork.freedesktop.org/series/119055/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13285_full -> Patchwork_119055v4_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_119055v4_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_119055v4_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_119055v4_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_eio@kms:
- shard-snb: [PASS][1] -> [DMESG-WARN][2] +34 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-snb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb1/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-snb: NOTRUN -> [DMESG-WARN][3] +13 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb1/igt@kms_flip@[email protected]

#### Warnings ####

* igt@kms_dp_aux_dev:
- shard-snb: [SKIP][4] ([fdo#109271]) -> [DMESG-FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-snb5/igt@kms_dp_aux_dev.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb5/igt@kms_dp_aux_dev.html

Known issues
------------

Here are the changes found in Patchwork_119055v4_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][6] -> [FAIL][7] ([i915#7742])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-4/igt@drm_fdinfo@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-4/igt@drm_fdinfo@[email protected]

* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [PASS][8] -> [ABORT][9] ([i915#7461] / [i915#8211])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-glk5/igt@gem_barrier_race@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-glk9/igt@gem_barrier_race@[email protected]

* igt@gem_exec_whisper@basic-fds-priority-all:
- shard-tglu: [PASS][10] -> [INCOMPLETE][11] ([i915#6755] / [i915#7392])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-tglu-5/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-tglu-9/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-tglu: [PASS][12] -> [FAIL][13] ([i915#3989] / [i915#454])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-tglu-9/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-tglu-3/igt@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [PASS][14] -> [SKIP][15] ([i915#1397]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-7/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-6/igt@[email protected]

* igt@kms_cursor_legacy@forked-move@pipe-b:
- shard-rkl: [PASS][16] -> [INCOMPLETE][17] ([i915#8011]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-1/igt@kms_cursor_legacy@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][18] -> [ABORT][19] ([i915#180])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-apl1/igt@kms_flip@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-rkl: NOTRUN -> [SKIP][20] ([i915#4579] / [i915#6953] / [i915#8228])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-1/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-5@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][21] ([i915#5176]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][22] ([i915#4579] / [i915#5176]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][23] ([i915#4579] / [i915#5235]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][25] ([i915#5235]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +13 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-vga-1.html

#### Possible fixes ####

* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][27] ([i915#5784]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-dg1-15/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-dg1-16/igt@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][29] ([i915#2842]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-1/igt@gem_exec_fair@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-2/igt@gem_exec_fair@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-dg1}: [SKIP][31] ([i915#1937] / [i915#4579]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-dg1-18/igt@i915_pm_lpsp@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-dg1-19/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-dg1}: [SKIP][33] ([i915#1397]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-dg1-18/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-dg1-19/igt@[email protected]

* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-rkl: [SKIP][35] ([i915#1397]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-6/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-rkl: [FAIL][37] ([fdo#103375]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-rkl-7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-rkl-4/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-2:
- shard-glk: [FAIL][39] ([i915#2521]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-glk5/igt@kms_async_flips@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-glk9/igt@kms_async_flips@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-snb: [SKIP][41] ([fdo#109271]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-snb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-snb6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][43] ([i915#2346]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-apl6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-apl4/igt@[email protected]

* igt@kms_cursor_legacy@forked-bo@pipe-b:
- {shard-dg1}: [INCOMPLETE][45] ([i915#8011] / [i915#8347]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-dg1-19/igt@kms_cursor_legacy@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-dg1-18/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][47] ([i915#2122]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-glk6/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-dp1:
- shard-apl: [FAIL][49] ([i915#79]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-apl6/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-apl4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][51] ([i915#79]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-glk3/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-glk3/igt@kms_flip@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglu: [FAIL][53] ([i915#2681] / [i915#3591]) -> [WARN][54] ([i915#2681])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13285/shard-tglu-7/igt@i915_pm_rc6_residency@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/shard-tglu-7/igt@i915_pm_rc6_residency@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502

Build changes
-------------

* Linux: CI_DRM_13285 -> Patchwork_119055v4

CI-20190529: 20190529
CI_DRM_13285: 13953a220ac9e1babdab06d31d546ce799102c03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7336: b7d168f61bef72a3e84e72eeee1767fac577d70d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_119055v4: 13953a220ac9e1babdab06d31d546ce799102c03 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119055v4/index.html