Skip to contentSkip to conversation

watchdog-buddy-dont-copy-the-cpumask-in-watchdog_next_cpu.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Jun 19, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: watchdog/buddy: don't copy the cpumask in watchdog_next_cpu()
has been removed from the -mm tree. Its filename was
watchdog-buddy-dont-copy-the-cpumask-in-watchdog_next_cpu.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Douglas Anderson <[email protected]>
Subject: watchdog/buddy: don't copy the cpumask in watchdog_next_cpu()
Date: Fri, 26 May 2023 18:41:37 -0700

There's no reason to make a copy of the "watchdog_cpus" locally in watchdog_next_cpu(). Making a copy wouldn't make things any more race free and we're just reading the value so there's no need for a copy.

---

 kernel/watchdog_buddy.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/watchdog_buddy.c renamed from kernel/watchdog_buddy.c~watchdog-buddy-dont-copy-the-cpumask-in-watchdog_next_cpu +2 -3
@@ -10,12 +10,11 @@ static cpumask_t __read_mostly watchdog_
 
 static unsigned int watchdog_next_cpu(unsigned int cpu)
 {
-	cpumask_t cpus = watchdog_cpus;
 	unsigned int next_cpu;
 
-	next_cpu = cpumask_next(cpu, &cpus);
+	next_cpu = cpumask_next(cpu, &watchdog_cpus);
 	if (next_cpu >= nr_cpu_ids)
-		next_cpu = cpumask_first(&cpus);
+		next_cpu = cpumask_first(&watchdog_cpus);
 
 	if (next_cpu == cpu)
 		return nr_cpu_ids;

_

Patches currently in -mm which might be from [email protected] are