Skip to contentSkip to conversation

Remove some e500/MPC85xx evaluation platforms

PATCH Applied Paul Gortmaker 2 participants 4 messages Jun 20, 2023 – Jul 3, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover Remove some e500/MPC85xx evaluation platforms

v1: https://lore.kernel.org/all/[email protected]/

v1 --> v2:
-don't remove MPC8568MDS or P1021 or P1012 platforms as per discussion -drop commit #4 that removed kernel fragments still in use elsewhere. -trivial refresh for the updated baseline of linux-next

In a similar theme to the e300/MPC83xx evaluation platform removal[1], this targets removal of two of the oldest e500/MPC85xx evaluation boards that were produced in limited numbers and primarily made available to hardware/software developers to shape their own boards and BSPs.

We start with the MPC8540-ADS[2] and MPC8560-ADS[3] -- based on the revision history in the user's guide[4], these near-identical platforms date back to at least 2002. These boards are probably a part of the very small few that still exist from the ppc ---> powerpc transition. Typical of evaluation boards, and as the picture[3] shows, these boards had a large footprint in order to break out connectors to evaluate as many features as possible.

For reference, I will note that for comparison that I retired our SBC8560 support over a decade ago, in v3.6 (2012, in commit b048b4e17cbb) and I don't think a single person complained.

Next, position yourself about 2007, and the MPC8548CDS (and variants) appeared as a vehicle to showcase the then new e500-v2 processor family, in a PCI-X card form factor with an additional backplane and the CPU on yet another daughter-card. Not very "hobbyist" friendly. As the saying goes, a picture[5] is worth 1000 words. It was quite the 3D beast.

Again, for comparison, and perhaps well overdue, I'd requested removal of our SBC8548 support in Jan 2021 (c12adb067844, v5.15).

Testing included builds of defconfig, mpc85xx_defconfig, mpc85xx_smp_defconfig and corenet32_smp_defconfig

As there is obviously no rush for this to be in v6.5, a defer to v6.6 would be perfectly fine. In any case it is is based off linux-next from today.

Paul.
--

[1] https://lore.kernel.org/all/[email protected]/
[2] https://www.nxp.com/products/no-longer-manufactured/application-development-system-for-mpc8540:MPC8540ADS
[3] https://www.nxp.com/products/no-longer-manufactured/application-development-system-for-mpc8560:MPC8560ADS
[4] https://www.nxp.com/docs/en/reference-manual/MPC8560ADSUG.pdf
[5] https://www.flickr.com/photos/daiharuki/905150424/in/photostream/

Cc Scott Wood <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Li Yang <[email protected]>
Cc Claudiu Manoil <[email protected]>
Cc Pali Rohár <[email protected]>

---

Paul Gortmaker (2):
powerpc: drop MPC8540_ADS and MPC8560_ADS platform support
powerpc: drop MPC85xx_CDS platform support

 arch/powerpc/boot/Makefile                    |   5 -
 arch/powerpc/boot/dts/fsl/mpc8540ads.dts      | 355 ----------------
 arch/powerpc/boot/dts/fsl/mpc8541cds.dts      | 375 -----------------
 arch/powerpc/boot/dts/fsl/mpc8548cds.dtsi     | 302 --------------
 arch/powerpc/boot/dts/fsl/mpc8548cds_32b.dts  |  82 ----
 arch/powerpc/boot/dts/fsl/mpc8548cds_36b.dts  |  82 ----
 arch/powerpc/boot/dts/fsl/mpc8555cds.dts      | 375 -----------------
 arch/powerpc/boot/dts/fsl/mpc8560ads.dts      | 388 ------------------
 .../configs/85xx/mpc8540_ads_defconfig        |  47 ---
 .../configs/85xx/mpc8560_ads_defconfig        |  50 ---
 .../configs/85xx/mpc85xx_cds_defconfig        |  52 ---
 arch/powerpc/configs/mpc85xx_base.config      |   3 -
 arch/powerpc/platforms/85xx/Makefile          |   3 -
 arch/powerpc/platforms/85xx/mpc85xx_ads.c     | 162 --------
 arch/powerpc/platforms/85xx/mpc85xx_cds.c     | 387 -----------------
 15 files changed, 2668 deletions(-)
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8540ads.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8541cds.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds.dtsi
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds_32b.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds_36b.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8555cds.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8560ads.dts
 delete mode 100644 arch/powerpc/configs/85xx/mpc8540_ads_defconfig
 delete mode 100644 arch/powerpc/configs/85xx/mpc8560_ads_defconfig
 delete mode 100644 arch/powerpc/configs/85xx/mpc85xx_cds_defconfig
 delete mode 100644 arch/powerpc/platforms/85xx/mpc85xx_ads.c
 delete mode 100644 arch/powerpc/platforms/85xx/mpc85xx_cds.c
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/2 powerpc: drop MPC8540_ADS and MPC8560_ADS platform support

Based on the revision history in the manual(s), these e500-v1 platforms were first available around 2002.

Like a lot of evaluation boards, they attempted to provide break-out connectors for all possible features, and that combined with four PCI-X slots (and the age/era) meant for a considerably large board.

As I recall it, from a Linux point of view, the biggest difference between 8540 and 8560 was in the UART implementation, and that is reflected in a diff of the defconfigs.

In any case, these are over 20 years old, and by today's standards only have a small amount of DDR1 memory, and were not widely available.

Given that, it makes sense to remove support from them in 2023.

Cc Scott Wood <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
---
 arch/powerpc/boot/Makefile                    |   2 -
 arch/powerpc/boot/dts/fsl/mpc8540ads.dts      | 355 ----------------
 arch/powerpc/boot/dts/fsl/mpc8560ads.dts      | 388 ------------------
 .../configs/85xx/mpc8540_ads_defconfig        |  47 ---
 .../configs/85xx/mpc8560_ads_defconfig        |  50 ---
 arch/powerpc/configs/mpc85xx_base.config      |   2 -
 arch/powerpc/platforms/85xx/Makefile          |   2 -
 arch/powerpc/platforms/85xx/mpc85xx_ads.c     | 162 --------
 8 files changed, 1008 deletions(-)
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8540ads.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8560ads.dts
 delete mode 100644 arch/powerpc/configs/85xx/mpc8540_ads_defconfig
 delete mode 100644 arch/powerpc/configs/85xx/mpc8560_ads_defconfig
 delete mode 100644 arch/powerpc/platforms/85xx/mpc85xx_ads.c
arch/powerpc/boot/Makefile +0 -2
index bf8976563e02..cf728cb3e9a9 100644
@@ -342,8 +342,6 @@ image-$(CONFIG_MPC834x_ITX)		+= cuImage.mpc8349emitx \
 image-$(CONFIG_ASP834x)			+= dtbImage.asp834x-redboot
 
 # Board ports in arch/powerpc/platform/85xx/Kconfig
-image-$(CONFIG_MPC8540_ADS)		+= cuImage.mpc8540ads
-image-$(CONFIG_MPC8560_ADS)		+= cuImage.mpc8560ads
 image-$(CONFIG_MPC85xx_CDS)		+= cuImage.mpc8541cds \
 					   cuImage.mpc8548cds_32b \
 					   cuImage.mpc8555cds
arch/powerpc/boot/dts/fsl/mpc8540ads.dts deleted +0 -355

355 lines not on this page · raw message

arch/powerpc/boot/dts/fsl/mpc8560ads.dts deleted +0 -388

388 lines not on this page · raw message

arch/powerpc/configs/85xx/mpc8540_ads_defconfig deleted +0 -47

47 lines not on this page · raw message

arch/powerpc/configs/85xx/mpc8560_ads_defconfig deleted +0 -50

50 lines not on this page · raw message

arch/powerpc/configs/mpc85xx_base.config +0 -2
index 85907b776908..e13bcf83bd1d 100644
@@ -1,7 +1,5 @@
 CONFIG_MATH_EMULATION=y
 CONFIG_MPC8536_DS=y
-CONFIG_MPC8540_ADS=y
-CONFIG_MPC8560_ADS=y
 CONFIG_MPC85xx_CDS=y
 CONFIG_MPC85xx_DS=y
 CONFIG_MPC85xx_MDS=y
arch/powerpc/platforms/85xx/Makefile +0 -2
index e3d977624e33..4bb473ca51b4 100644
@@ -12,8 +12,6 @@ obj-y += common.o
 obj-$(CONFIG_BSC9131_RDB) += bsc913x_rdb.o
 obj-$(CONFIG_BSC9132_QDS) += bsc913x_qds.o
 obj-$(CONFIG_C293_PCIE)   += c293pcie.o
-obj-$(CONFIG_MPC8540_ADS) += mpc85xx_ads.o
-obj-$(CONFIG_MPC8560_ADS) += mpc85xx_ads.o
 obj-$(CONFIG_MPC85xx_CDS) += mpc85xx_cds.o
 obj-$(CONFIG_MPC8536_DS)  += mpc8536_ds.o
 obj8259-$(CONFIG_PPC_I8259)   += mpc85xx_8259.o
arch/powerpc/platforms/85xx/mpc85xx_ads.c deleted +0 -162

162 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

PATCH v2 2/2 powerpc: drop MPC85xx_CDS platform support

In reply to Paul Gortmaker

The MPC8541/8548/8555 Configurable Development System (CDS) were the vehicle used to provide evaluation of the 1st e500-v2 CPUs around 2007.

Similar to the earlier MPC83xx-MDS systems we removed, the "brains" exist on a PCI-X card, but additional connectors exist to the right of the PCI-X slot, two structural metal pins are used to provide stability in a vertical ATX mounting, and the CPU is now on a daughter-card vs. a clamped down BGA.

Given the extra complexity and risk of connector damage, the 8548CDS I had access to came pre-assembled in a basic white Antec case common for that era, and I'm inclined to assume that was the default.

Power was typical "Pentium4" 2005 ATX - the main 20 pin connector went to the PCI ATX form factor backplane, and the 4 pin black/yellow went to the CPU card.

Like previous evaluation boards, they attempted to provide break-out connectors for as many features as possible, and that made for a fairly complex looking system.

In any case, these are over 15 years old, and fairly complex systems, originally made for a small group of industry related people, and made for use where quiet fan operation wasn't important. Given that, it makes sense to remove support from them in 2023.

Cc Scott Wood <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
---
 arch/powerpc/boot/Makefile                    |   3 -
 arch/powerpc/boot/dts/fsl/mpc8541cds.dts      | 375 -----------------
 arch/powerpc/boot/dts/fsl/mpc8548cds.dtsi     | 302 --------------
 arch/powerpc/boot/dts/fsl/mpc8548cds_32b.dts  |  82 ----
 arch/powerpc/boot/dts/fsl/mpc8548cds_36b.dts  |  82 ----
 arch/powerpc/boot/dts/fsl/mpc8555cds.dts      | 375 -----------------
 .../configs/85xx/mpc85xx_cds_defconfig        |  52 ---
 arch/powerpc/configs/mpc85xx_base.config      |   1 -
 arch/powerpc/platforms/85xx/Makefile          |   1 -
 arch/powerpc/platforms/85xx/mpc85xx_cds.c     | 387 ------------------
 10 files changed, 1660 deletions(-)
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8541cds.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds.dtsi
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds_32b.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8548cds_36b.dts
 delete mode 100644 arch/powerpc/boot/dts/fsl/mpc8555cds.dts
 delete mode 100644 arch/powerpc/configs/85xx/mpc85xx_cds_defconfig
 delete mode 100644 arch/powerpc/platforms/85xx/mpc85xx_cds.c
arch/powerpc/boot/Makefile +0 -3
index cf728cb3e9a9..968aee2025b8 100644
@@ -342,9 +342,6 @@ image-$(CONFIG_MPC834x_ITX)		+= cuImage.mpc8349emitx \
 image-$(CONFIG_ASP834x)			+= dtbImage.asp834x-redboot
 
 # Board ports in arch/powerpc/platform/85xx/Kconfig
-image-$(CONFIG_MPC85xx_CDS)		+= cuImage.mpc8541cds \
-					   cuImage.mpc8548cds_32b \
-					   cuImage.mpc8555cds
 image-$(CONFIG_MPC85xx_MDS)		+= cuImage.mpc8568mds
 image-$(CONFIG_MPC85xx_DS)		+= cuImage.mpc8544ds \
 					   cuImage.mpc8572ds
arch/powerpc/boot/dts/fsl/mpc8541cds.dts deleted +0 -375

375 lines not on this page · raw message

arch/powerpc/boot/dts/fsl/mpc8548cds.dtsi deleted +0 -302

302 lines not on this page · raw message

arch/powerpc/boot/dts/fsl/mpc8548cds_32b.dts deleted +0 -82

82 lines not on this page · raw message

arch/powerpc/boot/dts/fsl/mpc8548cds_36b.dts deleted +0 -82

82 lines not on this page · raw message

arch/powerpc/boot/dts/fsl/mpc8555cds.dts deleted +0 -375

375 lines not on this page · raw message

arch/powerpc/configs/85xx/mpc85xx_cds_defconfig deleted +0 -52

52 lines not on this page · raw message

arch/powerpc/configs/mpc85xx_base.config +0 -1
index e13bcf83bd1d..a1e4d72ed39d 100644
@@ -1,6 +1,5 @@
 CONFIG_MATH_EMULATION=y
 CONFIG_MPC8536_DS=y
-CONFIG_MPC85xx_CDS=y
 CONFIG_MPC85xx_DS=y
 CONFIG_MPC85xx_MDS=y
 CONFIG_MPC85xx_RDB=y
arch/powerpc/platforms/85xx/Makefile +0 -1
index 4bb473ca51b4..43c34f26f108 100644
@@ -12,7 +12,6 @@ obj-y += common.o
 obj-$(CONFIG_BSC9131_RDB) += bsc913x_rdb.o
 obj-$(CONFIG_BSC9132_QDS) += bsc913x_qds.o
 obj-$(CONFIG_C293_PCIE)   += c293pcie.o
-obj-$(CONFIG_MPC85xx_CDS) += mpc85xx_cds.o
 obj-$(CONFIG_MPC8536_DS)  += mpc8536_ds.o
 obj8259-$(CONFIG_PPC_I8259)   += mpc85xx_8259.o
 obj-$(CONFIG_MPC85xx_DS)  += mpc85xx_ds.o $(obj8259-y)
arch/powerpc/platforms/85xx/mpc85xx_cds.c deleted +0 -387

387 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw
In reply to Paul Gortmaker
Quoted 8 lines · Paul Gortmaker

v1: https://lore.kernel.org/all/[email protected]/

v1 --> v2:
-don't remove MPC8568MDS or P1021 or P1012 platforms as per discussion -drop commit #4 that removed kernel fragments still in use elsewhere. -trivial refresh for the updated baseline of linux-next

[...]

Applied to powerpc/next.

[1/2] powerpc: drop MPC8540_ADS and MPC8560_ADS platform support

      https://git.kernel.org/powerpc/c/384e338a9187e479349c97c9cfb36f6060708db8
[2/2] powerpc: drop MPC85xx_CDS platform support
      https://git.kernel.org/powerpc/c/b751ed04bc5e1b76f2885b846ea8289792a37166

cheers