Skip to contentSkip to conversation

bnxt_en: Link representors to PCI device

PATCH Applied Ivan Vecera 6 participants 8 messages Jun 20, 2023 – Jun 21, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bnxt_en: Link representors to PCI device

Link VF representors to parent PCI device to benefit from systemd defined naming scheme.

Without this change the representor is visible as ethN.

---
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c +1 -0
index 2f1a1f2d2157..1467b94a6427 100644
@@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
 	struct net_device *pf_dev = bp->dev;
 	u16 max_mtu;
 
+	SET_NETDEV_DEV(dev, &bp->pdev->dev);
 	dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
 	dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
 	/* Just inherit all the featues of the parent PF as the VF-R
Signature · 1 line
2.39.3
Acked-by on v1 1/1
#2 lore raw
In reply to Ivan Vecera
Quoted 7 lines · Ivan Vecera

Link VF representors to parent PCI device to benefit from systemd defined naming scheme.

Without this change the representor is visible as ethN.

Quoted 20 lines
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c +1 -1
index 2f1a1f2d2157..1467b94a6427 100644
@@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
        struct net_device *pf_dev = bp->dev;
        u16 max_mtu;
 
+       SET_NETDEV_DEV(dev, &bp->pdev->dev);
        dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
        dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
        /* Just inherit all the featues of the parent PF as the VF-R
--

2.39.3

Signature · 11 lines
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.
maintainer
#3 lore raw
Quoted 11 lines · On Tue, 20 Jun 2023 22:19:32 +0530 Sriharsha Basavapatna wrote:

This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

Your emails to the list must not include any legal note of this nature. I'll have to manually delete your review tag from the system.

maintainer Reviewed-by
#6 lore raw
Quoted 9 lines · Simon Horman
Quoted 7 lines · Michael Chan
Quoted 6 lines · Ivan Vecera

Link VF representors to parent PCI device to benefit from systemd defined naming scheme.

Without this change the representor is visible as ethN.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Thanks.

nit:) broadcon -> broadcom

Typo fixed.

#7 lore raw
In reply to Ivan Vecera
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 20 Jun 2023 16:48:55 +0200 you wrote:

Link VF representors to parent PCI device to benefit from systemd defined naming scheme.

Without this change the representor is visible as ethN.

[...]

Here is the summary with links:
- [net-next] bnxt_en: Link representors to PCI device

    https://git.kernel.org/netdev/net-next/c/7ad7b7023fcb

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html