Skip to contentSkip to conversation

dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

PATCH Superseded Dylan Hung 2 participants 4 messages Jun 21, 2023 – Jun 30, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dylan Hung

author
#0 lore raw

PATCH 1/1 dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

Add reset definitions of AST2600 I3C and MAC controllers.

---
 include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
include/dt-bindings/clock/ast2600-clock.h +12 -1
index e149eee61588..07377589f8f4 100644
@@ -90,7 +90,18 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
-#define ASPEED_RESET_I3C_DMA		39
+
+#define ASPEED_RESET_MAC4		53
+#define ASPEED_RESET_MAC3		52
+
+#define ASPEED_RESET_I3C5		45
+#define ASPEED_RESET_I3C4		44
+#define ASPEED_RESET_I3C3		43
+#define ASPEED_RESET_I3C2		42
+#define ASPEED_RESET_I3C1		41
+#define ASPEED_RESET_I3C0		40
+#define ASPEED_RESET_I3C		39
+
 #define ASPEED_RESET_PWM		37
 #define ASPEED_RESET_PECI		36
 #define ASPEED_RESET_MII		35
Signature · 1 line
2.25.1
#1 lore raw
Quoted 12 lines · Dylan Hung

Add reset definitions of AST2600 I3C and MAC controllers.

---
 include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
include/dt-bindings/clock/ast2600-clock.h +0 -0
index e149eee61588..07377589f8f4 100644

include/dt-bindings/clock/ast2600-clock.h line 93

Quoted 4 lines
include/dt-bindings/clock/ast2600-clock.h +0 -1
@@ -90,7 +90,18 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
-#define ASPEED_RESET_I3C_DMA		39

This will break all the users.

Best regards,
Krzysztof

author
#2 lore raw
Quoted 36 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:[email protected]]
Sent: Wednesday, June 21, 2023 6:11 PM
To: Dylan Hung <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: BMC-SW <[email protected]>
Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

Review

Quoted 8 lines · Dylan Hung

Add reset definitions of AST2600 I3C and MAC controllers.

---
 include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/include/dt-bindings/clock/ast2600-clock.h

include/dt-bindings/clock/ast2600-clock.h line 93

Quoted 8 lines

index e149eee61588..07377589f8f4 100644

include/dt-bindings/clock/ast2600-clock.h +0 -1
@@ -90,7 +90,18 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
-#define ASPEED_RESET_I3C_DMA		39

This will break all the users.

Best regards,
Krzysztof

author
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 21 lines

-----Original Message-----
From: Krzysztof Kozlowski [mailto:[email protected]]
Sent: Wednesday, June 21, 2023 6:11 PM
To: Dylan Hung <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: BMC-SW <[email protected]>
Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions

Review

Quoted 8 lines · Dylan Hung

Add reset definitions of AST2600 I3C and MAC controllers.

---
 include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/include/dt-bindings/clock/ast2600-clock.h

Quoted 11 lines

include/dt-bindings/clock/ast2600-clock.h line 93

Quoted 8 lines

index e149eee61588..07377589f8f4 100644

include/dt-bindings/clock/ast2600-clock.h +0 -1
@@ -90,7 +90,18 @@
 /* Only list resets here that are not part of a clock gate + reset pair */
 #define ASPEED_RESET_ADC		55
 #define ASPEED_RESET_JTAG_MASTER2	54
-#define ASPEED_RESET_I3C_DMA		39

This will break all the users.

This define was created but never used. However, if you have concerns about it, I can include it back in V2.

Quoted 2 lines

Best regards,
Krzysztof