Skip to contentSkip to conversation

perf test: Remove x permission from lib/stat_output.sh

PATCH In review Namhyung Kim 2 participants 2 messages Jun 22, 2023 perf events

lore
Share & tools
lore

Namhyung Kim

author maintainer
#0 lore raw

PATCH 1/1 perf test: Remove x permission from lib/stat_output.sh

The commit fc51fc87b1b8 factored out the helper functions to a library but the new file had execute permission. Due to the way it detects the shell test scripts, it showed up in the perf test list unexpectedly.

  $ ./perf test list 2>&1 | grep 86
   76: x86 bp modify
   77: x86 Sample parsing
   78: x86 hybrid
   86:                        <---- (here)
  $ ./perf test -v 86
   86:                                                                 :
  --- start ---
  test child forked, pid 1932207
  test child finished with 0
  ---- end ----
  : Ok

As it's a collection of library functions, it should not run as is. Let's remove the execute permission.

Fixes fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
Cc Kan Liang <[email protected]>
Cc Andi Kleen <[email protected]>
---
 tools/perf/tests/shell/lib/stat_output.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
tools/perf/tests/shell/lib/stat_output.sh +0 -0
old mode 100755
new mode 100644
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines · Namhyung Kim

The commit fc51fc87b1b8 factored out the helper functions to a library but the new file had execute permission. Due to the way it detects the shell test scripts, it showed up in the perf test list unexpectedly.

  $ ./perf test list 2>&1 | grep 86
   76: x86 bp modify
   77: x86 Sample parsing
   78: x86 hybrid
   86:                        <---- (here)
  $ ./perf test -v 86
   86:                                                                 :
  --- start ---
  test child forked, pid 1932207
  test child finished with 0
  ---- end ----
  : Ok
Quoted 7 lines

As it's a collection of library functions, it should not run as is. Let's remove the execute permission.

Fixes fc51fc87b1b8 ("perf test: Move all the check functions of stat CSV output to lib")
Cc Kan Liang <[email protected]>
Cc Andi Kleen <[email protected]>

Thanks,
Ian

Quoted 11 lines
---
 tools/perf/tests/shell/lib/stat_output.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 tools/perf/tests/shell/lib/stat_output.sh
tools/perf/tests/shell/lib/stat_output.sh +0 -1
old mode 100755
new mode 100644
--

2.41.0.162.gfafddb0af9-goog