Skip to contentSkip to conversation

pipe: remove redundant initialization of pointer buf

PATCH New Colin Ian King 1 participant 1 message Jun 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pipe: remove redundant initialization of pointer buf

The pointer buf is being initialized with a value that is never read. Buf is being re-assigned later on, the initialization is redundant and can be removed. Cleans up clang scan build warning:

fs/pipe.c:492:24: warning: Value stored to 'buf' during its initialization is never read [deadcode.DeadStores]

---
 fs/pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/pipe.c +1 -1
index 2d88f73f585a..71b6b0545e0f 100644
@@ -489,7 +489,7 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
 		head = pipe->head;
 		if (!pipe_full(head, pipe->tail, pipe->max_usage)) {
 			unsigned int mask = pipe->ring_size - 1;
-			struct pipe_buffer *buf = &pipe->bufs[head & mask];
+			struct pipe_buffer *buf;
 			struct page *page = pipe->tmp_page;
 			int copied;
 
Signature · 1 line
2.39.2