xfs: remove redundant initializations of pointers drop_leaf and save_leaf
Subsystems (2)
PATCH 1/1 xfs: remove redundant initializations of pointers drop_leaf and save_leaf
Pointers drop_leaf and save_leaf are initialized with values that are never read, they are being re-assigned later on just before they are used. Remove the redundant early initializations and keep the later assignments at the point where they are used. Cleans up two clang scan build warnings:
fs/xfs/libxfs/xfs_attr_leaf.c:2288:29: warning: Value stored to 'drop_leaf' during its initialization is never read [deadcode.DeadStores] fs/xfs/libxfs/xfs_attr_leaf.c:2289:29: warning: Value stored to 'save_leaf' during its initialization is never read [deadcode.DeadStores]
--- fs/xfs/libxfs/xfs_attr_leaf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/xfs/libxfs/xfs_attr_leaf.c +2 -2
@@ -2285,8 +2285,8 @@ xfs_attr3_leaf_unbalance(struct xfs_da_state_blk *drop_blk, struct xfs_da_state_blk *save_blk) { - struct xfs_attr_leafblock *drop_leaf = drop_blk->bp->b_addr; -struct xfs_attr_leafblock *save_leaf = save_blk->bp->b_addr; + struct xfs_attr_leafblock *drop_leaf; +struct xfs_attr_leafblock *save_leaf;struct xfs_attr3_icleaf_hdr drophdr;struct xfs_attr3_icleaf_hdr savehdr;struct xfs_attr_leaf_entry *entry;
Signature · 1 line
2.39.2
Quoted 11 lines · Colin Ian King
Pointers
drop_leafandsave_leafare initialized with values that are never read, they are being re-assigned later on just before they are used. Remove the redundant early initializations and keep the later assignments at the point where they are used. Cleans up two clang scan build warnings:
fs/xfs/libxfs/xfs_attr_leaf.c:2288:29: warning: Value stored to 'drop_leaf' during its initialization is never read [deadcode.DeadStores]fs/xfs/libxfs/xfs_attr_leaf.c:2289:29: warning: Value stored to 'save_leaf' during its initialization is never read [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
I'll change this to remove the /second/ initialization below the variable declarations for a net -2 LOC.
--D
Quoted 22 lines
--- fs/xfs/libxfs/xfs_attr_leaf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/xfs/libxfs/xfs_attr_leaf.c +2
-2@@ -2285,8 +2285,8 @@ xfs_attr3_leaf_unbalance(struct xfs_da_state_blk *drop_blk, struct xfs_da_state_blk *save_blk) { - struct xfs_attr_leafblock *drop_leaf = drop_blk->bp->b_addr; -struct xfs_attr_leafblock *save_leaf = save_blk->bp->b_addr; + struct xfs_attr_leafblock *drop_leaf; +struct xfs_attr_leafblock *save_leaf;struct xfs_attr3_icleaf_hdr drophdr;struct xfs_attr3_icleaf_hdr savehdr;struct xfs_attr_leaf_entry *entry;Signature · 1 line
2.39.2