Skip to contentSkip to conversation

pc-bios/s390-ccw/Makefile: Use -z noexecstack to silence linker warning

PATCH In review Thomas Huth 2 participants 2 messages Jun 22, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pc-bios/s390-ccw/Makefile: Use -z noexecstack to silence linker warning

Recent versions of ld complain when linking the s390-ccw bios:

/usr/bin/ld: warning: start.o: missing .note.GNU-stack section implies
executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in
a future version of the linker

We can silence the warning by telling the linker to mark the stack as not executable.

---
 pc-bios/s390-ccw/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
pc-bios/s390-ccw/Makefile +1 -1
index 2e8cc015aa..acfcd1e71a 100644
@@ -55,7 +55,7 @@ config-cc.mak: Makefile
 	    $(call cc-option,-march=z900,-march=z10)) 3> config-cc.mak
 -include config-cc.mak
 
-LDFLAGS += -Wl,-pie -nostdlib
+LDFLAGS += -Wl,-pie -nostdlib -z noexecstack
 
 build-all: s390-ccw.img s390-netboot.img
 
Signature · 1 line
2.39.3
Acked-by on v1 1/1
#1 lore raw

Am 22.06.23 um 15:08 schrieb Thomas Huth:

Quoted 20 lines

Recent versions of ld complain when linking the s390-ccw bios:

/usr/bin/ld: warning: start.o: missing .note.GNU-stack section implies
executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in
a future version of the linker

We can silence the warning by telling the linker to mark the stack as not executable.

---
  pc-bios/s390-ccw/Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
pc-bios/s390-ccw/Makefile +0 -0
index 2e8cc015aa..acfcd1e71a 100644

pc-bios/s390-ccw/Makefile config-cc.mak: Makefile · line 60

Quoted 7 lines
pc-bios/s390-ccw/Makefile +1 -1
@@ -55,7 +55,7 @@ config-cc.mak: Makefile
  	    $(call cc-option,-march=z900,-march=z10)) 3> config-cc.mak
  -include config-cc.mak
 
-LDFLAGS += -Wl,-pie -nostdlib
+LDFLAGS += -Wl,-pie -nostdlib -z noexecstack
 
  build-all: s390-ccw.img s390-netboot.img

In the end this should not matter as the resulting binary is not loaded by an elf loader so this should be fine