Skip to contentSkip to conversation

s390x: Align __bss_end to a halfword boundary

PATCH In review Thomas Huth 2 participants 2 messages Jun 23, 2023 – Jun 26, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x: Align __bss_end to a halfword boundary

We are using the "larl" instruction to load the address of __bss_end, and this instruction can only deal with even addresses, so we have to make sure that this symbol is aligned accordingly. Otherwise this will cause a failure with the new binutils 2.40 and Clang:

/usr/bin/ld: s390x/cstart64.o(.init+0x6a): misaligned symbol `__bss_end'

              (0x2c0d1) for relocation R_390_PC32DBL
---
 s390x/flat.lds.S | 1 +
 1 file changed, 1 insertion(+)
s390x/flat.lds.S +1 -0
index 0cb7e383..5e91ecac 100644
@@ -37,6 +37,7 @@ SECTIONS
 	. = ALIGN(16);
 	__bss_start = .;
 	.bss : { *(.bss) }
+	. = ALIGN(2);
 	__bss_end = .;
 	. = ALIGN(4K);
 	edata = .;
Signature · 1 line
2.39.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Fri, 23 Jun 2023 11:39:41 +0200 Thomas Huth <[email protected]> wrote:

We are using the "larl" instruction to load the address of __bss_end, and this instruction can only deal with even addresses, so we have to make sure that this symbol is aligned accordingly. Otherwise this will cause a failure with the new binutils 2.40 and Clang:

/usr/bin/ld: s390x/cstart64.o(.init+0x6a): misaligned symbol `__bss_end'

              (0x2c0d1) for relocation R_390_PC32DBL
Quoted 16 lines
---
 s390x/flat.lds.S | 1 +
 1 file changed, 1 insertion(+)
s390x/flat.lds.S +1 -0
index 0cb7e383..5e91ecac 100644
@@ -37,6 +37,7 @@ SECTIONS
 	. = ALIGN(16);
 	__bss_start = .;
 	.bss : { *(.bss) }
+	. = ALIGN(2);
 	__bss_end = .;
 	. = ALIGN(4K);
 	edata = .;