Skip to contentSkip to conversation

leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency

PATCH Applied Arnd Bergmann 2 participants 2 messages Jun 23, 2023 – Jul 13, 2023 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency

From: Arnd Bergmann <[email protected]>

A recent rework accidentally lost the dependency on LEDS_CLASS, which leads to a link error when LED support is disbled:

x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'

Add back the dependency that was there originally.

Fixes a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
---
 drivers/leds/simple/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/simple/Kconfig +1 -0
index 44fa0f93cb3b3..02443e745ff3b 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config LEDS_SIEMENS_SIMATIC_IPC
 	tristate "LED driver for Siemens Simatic IPCs"
+	depends on LEDS_CLASS
 	depends on SIEMENS_SIMATIC_IPC
 	help
 	  This option enables support for the LEDs of several Industrial PCs
Signature · 1 line
2.39.2
maintainer Applied
#1 lore raw
Quoted 8 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent rework accidentally lost the dependency on LEDS_CLASS, which leads to a link error when LED support is disbled:

x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'

Quoted 7 lines

Add back the dependency that was there originally.

Fixes a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
---
 drivers/leds/simple/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]