media: tc358746: select CONFIG_GENERIC_PHY
Subsystems (2)
PATCH 1/1 media: tc358746: select CONFIG_GENERIC_PHY
From: Arnd Bergmann <[email protected]>
The tc358746 driver selects CONFIG_GENERIC_PHY_MIPI_DPHY and links to that, but this fails when CONFIG_GENERIC_PHY is disabled, because Kbuild then never enters the drivers/phy directory for building object files:
ERROR: modpost: "phy_mipi_dphy_get_default_config_for_hsclk" [drivers/media/i2c/tc358746.ko] undefined!
Add an explicit 'select GENERIC_PHY' here to ensure that the directory is entered, and add another dependency on that symbol so make it more obvious what is going on if another driver has the same problem, as this will produce a Kconfig warning.
--- drivers/media/i2c/Kconfig | 1 + drivers/phy/Kconfig | 1 + 2 files changed, 2 insertions(+)
drivers/media/i2c/Kconfig +1 -0
@@ -1305,6 +1305,7 @@ config VIDEO_TC358746 select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER select V4L2_FWNODE + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY select REGMAP_I2C help
drivers/phy/Kconfig +1 -0
@@ -18,6 +18,7 @@ config GENERIC_PHY config GENERIC_PHY_MIPI_DPHY bool + depends on GENERIC_PHY help Generic MIPI D-PHY support.
Signature · 7 lines
2.39.2 -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Hi Arnd,
thanks for the patch.
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The tc358746 driver selects
CONFIG_GENERIC_PHY_MIPI_DPHYand links to that, but this fails whenCONFIG_GENERIC_PHYis disabled, becauseKbuildthen never enters thedrivers/phydirectory for building object files:ERROR: modpost: "
phy_mipi_dphy_get_default_config_for_hsclk" [drivers/media/i2c/tc358746.ko] undefined!
Quoted 7 lines
Add an explicit 'select
GENERIC_PHY' here to ensure that the directory is entered, and add another dependency on that symbol so make it more obvious what is going on if another driver has the same problem, as this will produce aKconfigwarning.Fixes 80a21da360516 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 33 lines
--- drivers/media/i2c/Kconfig | 1 + drivers/phy/Kconfig | 1 + 2 files changed, 2 insertions(+)drivers/media/i2c/Kconfig +1
-0@@ -1305,6 +1305,7 @@ config VIDEO_TC358746 select VIDEO_V4L2_SUBDEV_API select MEDIA_CONTROLLER select V4L2_FWNODE + select GENERIC_PHY select GENERIC_PHY_MIPI_DPHY select REGMAP_I2C helpdrivers/phy/Kconfig +1
-0@@ -18,6 +18,7 @@ config GENERIC_PHY config GENERIC_PHY_MIPI_DPHY bool + depends on GENERIC_PHY help Generic MIPI D-PHY support.Signature · 1 line
2.39.2