Skip to contentSkip to conversation

dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example

PATCH Applied Andrew Davis 4 participants 4 messages Jun 23, 2023 – Jun 26, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example

The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon compatible hint. Remove the same from the example in this binding.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +1 -1
index 0c98d913747bb..e6289fbe69070 100644
@@ -101,7 +101,7 @@ examples:
         };
 
         clock-controller@4140 {
-            compatible = "ti,am654-ehrpwm-tbclk", "syscon";
+            compatible = "ti,am654-ehrpwm-tbclk";
             reg = <0x4140 0x18>;
             #clock-cells = <1>;
         };
Signature · 1 line
2.39.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Andrew Davis

The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon compatible hint. Remove the same from the example in this binding.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the quick fix.

Stephen should apply this.

Rob

maintainer
#2 lore raw
In reply to Andrew Davis
Quoted 8 lines · Andrew Davis

The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon compatible hint. Remove the same from the example in this binding.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk'] is too short
from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk'] is too short
from schema $id: http://devicetree.org/schemas/clock/ti,am654-ehrpwm-tbclk.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.