perf: Replace deprecated -target with --target= for Clang
Subsystems (2)
PATCH 1/1 perf: Replace deprecated -target with --target= for Clang
-target has been deprecated since Clang 3.4 in 2013. Use the preferred --target=bpf form instead. This matches how we use --target= in scripts/Makefile.clang.
--- tools/perf/Documentation/perf-config.txt | 2 +- tools/perf/Makefile.perf | 4 ++-- tools/perf/util/llvm-utils.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-)
tools/perf/Documentation/perf-config.txt +1 -1
@@ -669,7 +669,7 @@ llvm.*:: "$CLANG_OPTIONS $PERF_BPF_INC_OPTIONS $KERNEL_INC_OPTIONS " \ "-Wno-unused-value -Wno-pointer-sign " \ "-working-directory $WORKING_DIR " \ - "-c \"$CLANG_SOURCE\" -target bpf $CLANG_EMIT_LLVM -O2 -o - $LLVM_OPTIONS_PIPE" + "-c \"$CLANG_SOURCE\" --target=bpf $CLANG_EMIT_LLVM -O2 -o - $LLVM_OPTIONS_PIPE" llvm.clang-opt:: Options passed to clang.
tools/perf/Makefile.perf +2 -2
@@ -1057,7 +1057,7 @@ $(SKEL_TMP_OUT) $(LIBAPI_OUTPUT) $(LIBBPF_OUTPUT) $(LIBPERF_OUTPUT) $(LIBSUBCMD_ ifdef BUILD_BPF_SKEL BPFTOOL := $(SKEL_TMP_OUT)/bootstrap/bpftool # Get Clang's default includes on this system, as opposed to those seen by -# '-target bpf'. This fixes "missing" files on some architectures/distros, +# '--target=bpf'. This fixes "missing" files on some architectures/distros, # such as asm/byteorder.h, asm/socket.h, asm/sockios.h, sys/cdefs.h etc. # # Use '-idirafter': Don't interfere with include mechanics except where the
@@ -1081,7 +1081,7 @@ $(BPFTOOL): | $(SKEL_TMP_OUT) OUTPUT=$(SKEL_TMP_OUT)/ bootstrap $(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) | $(SKEL_TMP_OUT) - $(QUIET_CLANG)$(CLANG) -g -O2 -target bpf -Wall -Werror $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \ + $(QUIET_CLANG)$(CLANG) -g -O2 --target=bpf -Wall -Werror $(BPF_INCLUDE) $(TOOLS_UAPI_INCLUDE) \ -c $(filter util/bpf_skel/%.bpf.c,$^) -o $@ $(SKEL_OUT)/%.skel.h: $(SKEL_TMP_OUT)/%.bpf.o | $(BPFTOOL)
tools/perf/util/llvm-utils.c +2 -2
@@ -25,7 +25,7 @@"$CLANG_OPTIONS $PERF_BPF_INC_OPTIONS $KERNEL_INC_OPTIONS " \"-Wno-unused-value -Wno-pointer-sign " \"-working-directory $WORKING_DIR " \ -"-c \"$CLANG_SOURCE\" -target bpf $CLANG_EMIT_LLVM -g -O2 -o - $LLVM_OPTIONS_PIPE" +"-c \"$CLANG_SOURCE\" --target=bpf $CLANG_EMIT_LLVM -g -O2 -o - $LLVM_OPTIONS_PIPE" struct llvm_param llvm_param = { .clang_path = "clang",
@@ -569,7 +569,7 @@ int llvm__compile_bpf(const char *path, void **p_obj_buf,pr_err ("ERROR:\tunable to compile %s\n" , path);pr_err ("Hint:\tCheck error message shown above.\n" );pr_err ("Hint:\tYou can also pre-compile it into .o using:\n" ); -pr_err (" \t\tclang -target bpf -O2 -c %s\n" , path); +pr_err (" \t\tclang --target=bpf -O2 -c %s\n" , path);pr_err (" \twith proper -I and -D options.\n" ); goto errout; }
Signature · 1 line
2.41.0.178.g377b9f9a00-goog
Quoted 6 lines · Fangrui Song
-target has been deprecated since Clang 3.4 in 2013. Use the preferred --target=bpf form instead. This matches how we use --target= in
scripts/Makefile.clang.
Namhyung Kim
AppliedHi Fangui and Yonghong,
Quoted 4 lines · Yonghong Song
On 6/23/23 5:27 PM, Fangrui Song wrote:
Quoted 8 lines
Quoted 6 lines
-target has been deprecated since Clang 3.4 in 2013. Use the preferred --target=bpf form instead. This matches how we use --target= in
scripts/Makefile.clang.Acked-by Yonghong Song <[email protected]>
After 10 years of deprecation, time to change. :)
Applied to perf-tools-next, thanks!
Quoted 12 lines · Namhyung Kim
Hi Fangui and Yonghong,
Quoted 8 lines · Yonghong Song
Quoted 4 lines · Fangrui Song
-target has been deprecated since Clang 3.4 in 2013. Use the preferred --target=bpf form instead. This matches how we use --target= in
scripts/Makefile.clang.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Acked-by Yonghong Song <[email protected]>After 10 years of deprecation, time to change. :)
Applied to perf-tools-next, thanks!
Thank you!
Signature · 1 line
宋方睿