Skip to contentSkip to conversation

xen/arm: arm32: Allow Xen to boot on unidentified CPUs

PATCH In review Ayan Kumar Halder 3 participants 3 messages Jun 26, 2023 – Jun 29, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xen/arm: arm32: Allow Xen to boot on unidentified CPUs

Currently if the processor id is not identified (ie it is missing in proc-v7.S) , then Xen boot fails quite early.
We have removed this restriction as for some CPUs (eg Cortex-R52), there isn't any special initialization required.

---
Changes from -

v1 - "[PATCH v1] xen/arm: arm32: Add support to identify the Cortex-R52 processor" No need to add R52 proc id and empty stubs as there is no cpu initialization required.

 xen/arch/arm/arm32/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/arm/arm32/head.S +1 -1
index f9f7be9588..3e88178552 100644
@@ -324,7 +324,7 @@ cpu_init:
         PRINT("- Missing processor info: ")
         print_reg r4
         PRINT(" -\r\n")
-        b     fail
+        b     cpu_init_done
 1:
         /* Jump to cpu_init */
         ldr   r1, [r1, #PROCINFO_cpu_init]  /* r1 := vaddr(init func) */
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Ayan Kumar Halder

Currently if the processor id is not identified (ie it is missing in proc-v7.S) , then Xen boot fails quite early.
We have removed this restriction as for some CPUs (eg Cortex-R52), there isn't any special initialization required.

Quoted 27 lines

---
Changes from -

v1 - "[PATCH v1] xen/arm: arm32: Add support to identify the Cortex-R52 processor" No need to add R52 proc id and empty stubs as there is no cpu initialization required.

 xen/arch/arm/arm32/head.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/arm/arm32/head.S +1 -1
index f9f7be9588..3e88178552 100644
@@ -324,7 +324,7 @@ cpu_init:
         PRINT("- Missing processor info: ")
         print_reg r4
         PRINT(" -\r\n")
-        b     fail
+        b     cpu_init_done
 1:
         /* Jump to cpu_init */
         ldr   r1, [r1, #PROCINFO_cpu_init]  /* r1 := vaddr(init func) */
Signature · 1 line
2.25.1
#2 lore raw

Hi,

Quoted 9 lines · Stefano Stabellini
Quoted 6 lines · Ayan Kumar Halder

Currently if the processor id is not identified (ie it is missing in proc-v7.S) , then Xen boot fails quite early.
We have removed this restriction as for some CPUs (eg Cortex-R52), there isn't any special initialization required.

I have committed it.

Cheers,

Signature · 1 line
Julien Grall