Skip to contentSkip to conversation

drm/amdgpu: remove duplicated doorbell range init for sdma v4.4.2

PATCH In review Le Ma 2 participants 2 messages Jun 27, 2023

Subsystems (2)
lore
Share & tools
lore

Le Ma

author
#0 lore raw

PATCH 1/1 drm/amdgpu: remove duplicated doorbell range init for sdma v4.4.2

Handled in earlier phase

---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c +0 -5
index 6be19ffc502b..f413898dda37 100644
@@ -902,11 +902,6 @@ static int sdma_v4_4_2_inst_start(struct amdgpu_device *adev,
 		WREG32_SDMA(i, regSDMA_CNTL, temp);
 
 		if (!amdgpu_sriov_vf(adev)) {
-			ring = &adev->sdma.instance[i].ring;
-			adev->nbio.funcs->sdma_doorbell_range(adev, i,
-				ring->use_doorbell, ring->doorbell_index,
-				adev->doorbell_index.sdma_doorbell_range);
-
 			if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) {
 				/* unhalt engine */
 				temp = RREG32_SDMA(i, regSDMA_F32_CNTL);
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

Regards,
Hawking
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Le Ma
Sent: Tuesday, June 27, 2023 11:56
To: [email protected]
Subject: [PATCH 1/1] drm/amdgpu: remove duplicated doorbell range init for sdma v4.4.2

Handled in earlier phase

---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c +0 -5
index 6be19ffc502b..f413898dda37 100644
@@ -902,11 +902,6 @@ static int sdma_v4_4_2_inst_start(struct amdgpu_device *adev,
                WREG32_SDMA(i, regSDMA_CNTL, temp);
 
                if (!amdgpu_sriov_vf(adev)) {
-                       ring = &adev->sdma.instance[i].ring;
-                       adev->nbio.funcs->sdma_doorbell_range(adev, i,
-                               ring->use_doorbell, ring->doorbell_index,
-                               adev->doorbell_index.sdma_doorbell_range);
-
                        if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) {
                                /* unhalt engine */
                                temp = RREG32_SDMA(i, regSDMA_F32_CNTL);

--
2.38.1