Skip to contentSkip to conversation

PCI: vmd: Clean up an indentation issue reported by Smatch

PATCH Applied [email protected] 2 participants 2 messages Jun 27, 2023 – Aug 30, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: vmd: Clean up an indentation issue reported by Smatch

From: Xinghui Li <[email protected]>

There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"

Fix it and remove the unnecessary if.

---
 drivers/pci/controller/vmd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/pci/controller/vmd.c +1 -4
index 990630ec57c6..356bbeb548fe 100644
@@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev)
 	struct vmd_dev *vmd = pci_get_drvdata(pdev);
 	int err, i;
 
-       if (vmd->irq_domain)
-               vmd_set_msi_remapping(vmd, true);
-       else
-               vmd_set_msi_remapping(vmd, false);
+	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
 
 	for (i = 0; i < vmd->msix_count; i++) {
 		err = devm_request_irq(dev, vmd->irqs[i].virq,
Signature · 1 line
2.39.3
#1 lore raw

Hello,

Quoted 5 lines

There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"

Fix it and remove the unnecessary if.

Applied to controller/vmd, thank you!

[1/1] PCI: vmd: Fix inconsistent indentation in vmd_resume()

      https://git.kernel.org/pci/pci/c/1bae18a3eeee

	Krzysztof